From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v2] ASoC: Intel: bxt-da7219-max98357a: support MAX98390 speaker amp
Date: Thu, 02 Jul 2020 02:52:03 +0800 [thread overview]
Message-ID: <202007020245.V1BE3daY%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 10253 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <1593596211-28344-1-git-send-email-brent.lu@intel.com>
References: <1593596211-28344-1-git-send-email-brent.lu@intel.com>
TO: Brent Lu <brent.lu@intel.com>
TO: alsa-devel(a)alsa-project.org
CC: Cezary Rojewski <cezary.rojewski@intel.com>
CC: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>
CC: Liam Girdwood <liam.r.girdwood@linux.intel.com>
CC: Jie Yang <yang.jie@linux.intel.com>
CC: Mark Brown <broonie@kernel.org>
CC: Jaroslav Kysela <perex@perex.cz>
CC: Takashi Iwai <tiwai@suse.com>
CC: Kai Vehmanen <kai.vehmanen@linux.intel.com>
CC: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Hi Brent,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on sound/for-next v5.8-rc3 next-20200701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Brent-Lu/ASoC-Intel-bxt-da7219-max98357a-support-MAX98390-speaker-amp/20200701-174420
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
config: i386-randconfig-m021-20200701 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
sound/soc/intel/boards/bxt_da7219_max98357a.c:683 bxt_card_late_probe() error: uninitialized symbol 'widgets'.
sound/soc/intel/boards/bxt_da7219_max98357a.c:683 bxt_card_late_probe() error: uninitialized symbol 'num_widgets'.
sound/soc/intel/boards/bxt_da7219_max98357a.c:689 bxt_card_late_probe() error: uninitialized symbol 'controls'.
sound/soc/intel/boards/bxt_da7219_max98357a.c:689 bxt_card_late_probe() error: uninitialized symbol 'num_controls'.
sound/soc/intel/boards/bxt_da7219_max98357a.c:695 bxt_card_late_probe() error: uninitialized symbol 'routes'.
sound/soc/intel/boards/bxt_da7219_max98357a.c:695 bxt_card_late_probe() error: uninitialized symbol 'num_routes'.
# https://github.com/0day-ci/linux/commit/27dccaf17142fa2cfe38b279782b1d72aa6dd041
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 27dccaf17142fa2cfe38b279782b1d72aa6dd041
vim +/widgets +683 sound/soc/intel/boards/bxt_da7219_max98357a.c
27dccaf17142fa Brent Lu 2020-07-01 648
625de2bf2ed163 Jeeja KP 2017-02-07 649 #define NAME_SIZE 32
ba210346779464 Jeeja KP 2017-01-24 650 static int bxt_card_late_probe(struct snd_soc_card *card)
ba210346779464 Jeeja KP 2017-01-24 651 {
ba210346779464 Jeeja KP 2017-01-24 652 struct bxt_card_private *ctx = snd_soc_card_get_drvdata(card);
ba210346779464 Jeeja KP 2017-01-24 653 struct bxt_hdmi_pcm *pcm;
4510112217116d Kuninori Morimoto 2018-01-29 654 struct snd_soc_component *component = NULL;
27dccaf17142fa Brent Lu 2020-07-01 655 const struct snd_kcontrol_new *controls;
27dccaf17142fa Brent Lu 2020-07-01 656 const struct snd_soc_dapm_widget *widgets;
27dccaf17142fa Brent Lu 2020-07-01 657 const struct snd_soc_dapm_route *routes;
27dccaf17142fa Brent Lu 2020-07-01 658 int num_controls, num_widgets, num_routes, err, i = 0;
625de2bf2ed163 Jeeja KP 2017-02-07 659 char jack_name[NAME_SIZE];
ba210346779464 Jeeja KP 2017-01-24 660
27dccaf17142fa Brent Lu 2020-07-01 661 switch (ctx->spkamp) {
27dccaf17142fa Brent Lu 2020-07-01 662 case SPKAMP_MAX98357A:
27dccaf17142fa Brent Lu 2020-07-01 663 controls = max98357a_controls;
27dccaf17142fa Brent Lu 2020-07-01 664 num_controls = ARRAY_SIZE(max98357a_controls);
27dccaf17142fa Brent Lu 2020-07-01 665 widgets = max98357a_widgets;
27dccaf17142fa Brent Lu 2020-07-01 666 num_widgets = ARRAY_SIZE(max98357a_widgets);
27dccaf17142fa Brent Lu 2020-07-01 667 routes = max98357a_routes;
27dccaf17142fa Brent Lu 2020-07-01 668 num_routes = ARRAY_SIZE(max98357a_routes);
27dccaf17142fa Brent Lu 2020-07-01 669 break;
27dccaf17142fa Brent Lu 2020-07-01 670 case SPKAMP_MAX98390:
27dccaf17142fa Brent Lu 2020-07-01 671 controls = max98390_controls;
27dccaf17142fa Brent Lu 2020-07-01 672 num_controls = ARRAY_SIZE(max98390_controls);
27dccaf17142fa Brent Lu 2020-07-01 673 widgets = max98390_widgets;
27dccaf17142fa Brent Lu 2020-07-01 674 num_widgets = ARRAY_SIZE(max98390_widgets);
27dccaf17142fa Brent Lu 2020-07-01 675 routes = max98390_routes;
27dccaf17142fa Brent Lu 2020-07-01 676 num_routes = ARRAY_SIZE(max98390_routes);
27dccaf17142fa Brent Lu 2020-07-01 677 break;
27dccaf17142fa Brent Lu 2020-07-01 678 default:
27dccaf17142fa Brent Lu 2020-07-01 679 dev_err(card->dev, "Invalid speaker amplifier %d\n", ctx->spkamp);
27dccaf17142fa Brent Lu 2020-07-01 680 break;
27dccaf17142fa Brent Lu 2020-07-01 681 }
27dccaf17142fa Brent Lu 2020-07-01 682
27dccaf17142fa Brent Lu 2020-07-01 @683 err = snd_soc_dapm_new_controls(&card->dapm, widgets, num_widgets);
27dccaf17142fa Brent Lu 2020-07-01 684 if (err) {
27dccaf17142fa Brent Lu 2020-07-01 685 dev_err(card->dev, "Fail to new widgets\n");
27dccaf17142fa Brent Lu 2020-07-01 686 return err;
27dccaf17142fa Brent Lu 2020-07-01 687 }
27dccaf17142fa Brent Lu 2020-07-01 688
27dccaf17142fa Brent Lu 2020-07-01 @689 err = snd_soc_add_card_controls(card, controls, num_controls);
27dccaf17142fa Brent Lu 2020-07-01 690 if (err) {
27dccaf17142fa Brent Lu 2020-07-01 691 dev_err(card->dev, "Fail to add controls\n");
27dccaf17142fa Brent Lu 2020-07-01 692 return err;
27dccaf17142fa Brent Lu 2020-07-01 693 }
27dccaf17142fa Brent Lu 2020-07-01 694
27dccaf17142fa Brent Lu 2020-07-01 @695 err = snd_soc_dapm_add_routes(&card->dapm, routes, num_routes);
27dccaf17142fa Brent Lu 2020-07-01 696 if (err) {
27dccaf17142fa Brent Lu 2020-07-01 697 dev_err(card->dev, "Fail to add routes\n");
27dccaf17142fa Brent Lu 2020-07-01 698 return err;
27dccaf17142fa Brent Lu 2020-07-01 699 }
27dccaf17142fa Brent Lu 2020-07-01 700
536cfd2f375d36 Pierre-Louis Bossart 2019-05-30 701 if (soc_intel_is_glk())
c011245a197017 Yong Zhi 2019-02-13 702 snd_soc_dapm_add_routes(&card->dapm, gemini_map,
c011245a197017 Yong Zhi 2019-02-13 703 ARRAY_SIZE(gemini_map));
c011245a197017 Yong Zhi 2019-02-13 704 else
c011245a197017 Yong Zhi 2019-02-13 705 snd_soc_dapm_add_routes(&card->dapm, broxton_map,
c011245a197017 Yong Zhi 2019-02-13 706 ARRAY_SIZE(broxton_map));
c011245a197017 Yong Zhi 2019-02-13 707
98ff5c262f27aa Guennadi Liakhovetski 2020-01-24 708 if (list_empty(&ctx->hdmi_pcm_list))
98ff5c262f27aa Guennadi Liakhovetski 2020-01-24 709 return -EINVAL;
98ff5c262f27aa Guennadi Liakhovetski 2020-01-24 710
98ff5c262f27aa Guennadi Liakhovetski 2020-01-24 711 if (ctx->common_hdmi_codec_drv) {
57ad18906f2427 Kai Vehmanen 2019-10-29 712 pcm = list_first_entry(&ctx->hdmi_pcm_list, struct bxt_hdmi_pcm,
57ad18906f2427 Kai Vehmanen 2019-10-29 713 head);
57ad18906f2427 Kai Vehmanen 2019-10-29 714 component = pcm->codec_dai->component;
57ad18906f2427 Kai Vehmanen 2019-10-29 715 return hda_dsp_hdmi_build_controls(card, component);
98ff5c262f27aa Guennadi Liakhovetski 2020-01-24 716 }
57ad18906f2427 Kai Vehmanen 2019-10-29 717
ba210346779464 Jeeja KP 2017-01-24 718 list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) {
4510112217116d Kuninori Morimoto 2018-01-29 719 component = pcm->codec_dai->component;
625de2bf2ed163 Jeeja KP 2017-02-07 720 snprintf(jack_name, sizeof(jack_name),
625de2bf2ed163 Jeeja KP 2017-02-07 721 "HDMI/DP, pcm=%d Jack", pcm->device);
625de2bf2ed163 Jeeja KP 2017-02-07 722 err = snd_soc_card_jack_new(card, jack_name,
625de2bf2ed163 Jeeja KP 2017-02-07 723 SND_JACK_AVOUT, &broxton_hdmi[i],
625de2bf2ed163 Jeeja KP 2017-02-07 724 NULL, 0);
625de2bf2ed163 Jeeja KP 2017-02-07 725
625de2bf2ed163 Jeeja KP 2017-02-07 726 if (err)
625de2bf2ed163 Jeeja KP 2017-02-07 727 return err;
625de2bf2ed163 Jeeja KP 2017-02-07 728
625de2bf2ed163 Jeeja KP 2017-02-07 729 err = hdac_hdmi_jack_init(pcm->codec_dai, pcm->device,
625de2bf2ed163 Jeeja KP 2017-02-07 730 &broxton_hdmi[i]);
ba210346779464 Jeeja KP 2017-01-24 731 if (err < 0)
ba210346779464 Jeeja KP 2017-01-24 732 return err;
625de2bf2ed163 Jeeja KP 2017-02-07 733
625de2bf2ed163 Jeeja KP 2017-02-07 734 i++;
ba210346779464 Jeeja KP 2017-01-24 735 }
ba210346779464 Jeeja KP 2017-01-24 736
4510112217116d Kuninori Morimoto 2018-01-29 737 return hdac_hdmi_jack_port_init(component, &card->dapm);
ba210346779464 Jeeja KP 2017-01-24 738 }
ba210346779464 Jeeja KP 2017-01-24 739
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41848 bytes --]
next reply other threads:[~2020-07-01 18:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 18:52 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-01 9:36 [PATCH v2] ASoC: Intel: bxt-da7219-max98357a: support MAX98390 speaker amp Brent Lu
2020-07-01 9:36 ` Brent Lu
2020-07-01 15:49 ` Pierre-Louis Bossart
2020-07-01 15:49 ` Pierre-Louis Bossart
2020-07-01 22:23 ` Mark Brown
2020-07-01 22:23 ` Mark Brown
2020-07-07 13:22 ` Dan Carpenter
2020-07-07 13:22 ` Dan Carpenter
2020-07-07 13:22 ` Dan Carpenter
2020-07-07 15:57 ` Pierre-Louis Bossart
2020-07-07 15:57 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007020245.V1BE3daY%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.