From: Thomas Huth <thuth@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>, qemu-devel@nongnu.org
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Janosch Frank <frankja@linux.ibm.com>
Subject: [PULL SUBSYSTEM s390x 09/11] pc-bios: s390x: Make u32 ptr check explicit
Date: Thu, 2 Jul 2020 13:50:43 +0200 [thread overview]
Message-ID: <20200702115045.6171-10-thuth@redhat.com> (raw)
In-Reply-To: <20200702115045.6171-1-thuth@redhat.com>
From: Janosch Frank <frankja@linux.ibm.com>
Let's make it a bit more clear that we check the full 64 bits to fit
into the 32 we return.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Suggested-by: David Hildenbrand <david@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20200624075226.92728-11-frankja@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
pc-bios/s390-ccw/helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/helper.h b/pc-bios/s390-ccw/helper.h
index 32a453b634..dfcfea0ff0 100644
--- a/pc-bios/s390-ccw/helper.h
+++ b/pc-bios/s390-ccw/helper.h
@@ -19,7 +19,7 @@
/* Avoids compiler warnings when casting a pointer to a u32 */
static inline uint32_t ptr2u32(void *ptr)
{
- IPL_assert((uint64_t)ptr <= 0xffffffff, "ptr2u32: ptr too large");
+ IPL_assert((uint64_t)ptr <= 0xffffffffull, "ptr2u32: ptr too large");
return (uint32_t)(uint64_t)ptr;
}
--
2.18.1
next prev parent reply other threads:[~2020-07-02 11:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 11:50 [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update Thomas Huth
2020-07-02 11:50 ` [PULL SUBSYSTEM s390x 01/11] pc-bios: s390x: cio.c cleanup and compile fix Thomas Huth
2020-07-02 11:50 ` [PULL SUBSYSTEM s390x 02/11] pc-bios: s390x: Consolidate timing functions into time.h Thomas Huth
2020-07-02 11:50 ` [PULL SUBSYSTEM s390x 03/11] pc-bios: s390x: Move sleep and yield to helper.h Thomas Huth
2020-07-02 11:50 ` [PULL SUBSYSTEM s390x 04/11] pc-bios: s390x: Get rid of magic offsets into the lowcore Thomas Huth
2020-07-02 11:50 ` [PULL SUBSYSTEM s390x 05/11] pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64 Thomas Huth
2020-07-02 11:50 ` [PULL SUBSYSTEM s390x 06/11] pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR Thomas Huth
2020-07-02 11:50 ` [PULL SUBSYSTEM s390x 07/11] pc-bios: s390x: Move panic() into header and add infinite loop Thomas Huth
2020-07-02 11:50 ` [PULL SUBSYSTEM s390x 08/11] pc-bios: s390x: Use ebcdic2ascii table Thomas Huth
2020-07-02 11:50 ` Thomas Huth [this message]
2020-07-02 11:50 ` [PULL SUBSYSTEM s390x 10/11] pc-bios/s390-ccw: Generate and include dependency files in the Makefile Thomas Huth
2020-07-02 11:50 ` [PULL SUBSYSTEM s390x 11/11] pc-bios/s390: Update s390-ccw bios binaries with the latest changes Thomas Huth
2020-07-02 12:01 ` [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update no-reply
2020-07-02 12:14 ` no-reply
2020-07-02 12:32 ` no-reply
2020-07-03 10:02 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702115045.6171-10-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.