From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45AAFC433DF for ; Thu, 2 Jul 2020 16:34:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E5A720760 for ; Thu, 2 Jul 2020 16:34:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726670AbgGBQeW (ORCPT ); Thu, 2 Jul 2020 12:34:22 -0400 Received: from muru.com ([72.249.23.125]:60416 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726415AbgGBQeW (ORCPT ); Thu, 2 Jul 2020 12:34:22 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E2B738062; Thu, 2 Jul 2020 16:35:14 +0000 (UTC) Date: Thu, 2 Jul 2020 09:34:19 -0700 From: Tony Lindgren To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ulf Hansson , linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 1/1] arch: arm: mach-omap2: mmc: Move omap_mmc_notify_cover_event() prototype Message-ID: <20200702163419.GL37466@atomide.com> References: <20200701102317.235032-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200701102317.235032-1-lee.jones@linaro.org> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org * Lee Jones [200701 03:24]: > When building the kernel with W=1 the build system complains of: > > drivers/mmc/host/omap.c:854:6: warning: no previous prototype for ‘omap_mmc_notify_cover_event’ [-Wmissing-prototypes] > 854 | void omap_mmc_notify_cover_event(struct device *dev, int num, int is_closed) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > If we move the prototype into a shared headerfile the build system > will be satisfied. Rather than create a whole new headerfile just > for this purpose, it makes sense to use the already existing > mmc-omap.h. Looks good to me and should not conflict with anything so feel free to queue along with your other patches: Acked-by: Tony Lindgren > Cc: Ulf Hansson > Cc: linux-mmc@vger.kernel.org > Cc: Tony Lindgren > Cc: linux-omap@vger.kernel.org > Signed-off-by: Lee Jones > --- > arch/arm/mach-omap2/mmc.h | 4 ---- > include/linux/platform_data/mmc-omap.h | 3 +++ > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-omap2/mmc.h b/arch/arm/mach-omap2/mmc.h > index 7f4e053c34344..b5533e93cb632 100644 > --- a/arch/arm/mach-omap2/mmc.h > +++ b/arch/arm/mach-omap2/mmc.h > @@ -16,7 +16,3 @@ static inline int omap_msdi_reset(struct omap_hwmod *oh) > return 0; > } > #endif > - > -/* called from board-specific card detection service routine */ > -extern void omap_mmc_notify_cover_event(struct device *dev, int slot, > - int is_closed); > diff --git a/include/linux/platform_data/mmc-omap.h b/include/linux/platform_data/mmc-omap.h > index 9acf0e87aa9be..f0b8947e6b07d 100644 > --- a/include/linux/platform_data/mmc-omap.h > +++ b/include/linux/platform_data/mmc-omap.h > @@ -116,3 +116,6 @@ struct omap_mmc_platform_data { > > } slots[OMAP_MMC_MAX_SLOTS]; > }; > + > +extern void omap_mmc_notify_cover_event(struct device *dev, int slot, > + int is_closed); > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B08C433DF for ; Thu, 2 Jul 2020 16:35:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79BFD207D4 for ; Thu, 2 Jul 2020 16:35:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fEyb4pEb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79BFD207D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Mymhty7eHxtwNTdW2xXAZ1BxsrZg2CvWZp637hm0Gww=; b=fEyb4pEbCzwvxH4O8HoFnMVbn LNL7abeEmvcjSdMQRea7cbrdJYkVhYcCC9A2dMf7rkvb8pmkxa3ZaM2hkN5elhqIP6VnANsgeecvP tC1VuaIDmNx2zT0Dr4TGlmuwQ4J2jaBYe2wFhqZQeW3oQ/VFScwdJdMwcJkoWCBv3op60LzWntSUY rWUndArkNwAZfYVzWu3gQljLxkHsHzmpiIz5+JMXXqBoMKUsspXxSXKD9EoiuO5ecGwP1Ai5p92// EfSjy5zhKcHgdAl2P8OvtfDK3JdW4EUPQ5i0oC2Cd4AdWIWDy+vro5uEF9x76RPMMDuIwmBO8avXB QDSTEKY1g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr2AL-0001v2-7g; Thu, 02 Jul 2020 16:34:25 +0000 Received: from muru.com ([72.249.23.125]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr2AI-0001uX-LB for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 16:34:23 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E2B738062; Thu, 2 Jul 2020 16:35:14 +0000 (UTC) Date: Thu, 2 Jul 2020 09:34:19 -0700 From: Tony Lindgren To: Lee Jones Subject: Re: [PATCH 1/1] arch: arm: mach-omap2: mmc: Move omap_mmc_notify_cover_event() prototype Message-ID: <20200702163419.GL37466@atomide.com> References: <20200701102317.235032-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200701102317.235032-1-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_123422_765978_266B6C8E X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPiBbMjAwNzAxIDAzOjI0XToKPiBXaGVu IGJ1aWxkaW5nIHRoZSBrZXJuZWwgd2l0aCBXPTEgdGhlIGJ1aWxkIHN5c3RlbSBjb21wbGFpbnMg b2Y6Cj4gCj4gIGRyaXZlcnMvbW1jL2hvc3Qvb21hcC5jOjg1NDo2OiB3YXJuaW5nOiBubyBwcmV2 aW91cyBwcm90b3R5cGUgZm9yIOKAmG9tYXBfbW1jX25vdGlmeV9jb3Zlcl9ldmVudOKAmSBbLVdt aXNzaW5nLXByb3RvdHlwZXNdCj4gIDg1NCB8IHZvaWQgb21hcF9tbWNfbm90aWZ5X2NvdmVyX2V2 ZW50KHN0cnVjdCBkZXZpY2UgKmRldiwgaW50IG51bSwgaW50IGlzX2Nsb3NlZCkKPiAgfCBefn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn4KPiAKPiBJZiB3ZSBtb3ZlIHRoZSBwcm90b3R5cGUgaW50 byBhIHNoYXJlZCBoZWFkZXJmaWxlIHRoZSBidWlsZCBzeXN0ZW0KPiB3aWxsIGJlIHNhdGlzZmll ZC4gIFJhdGhlciB0aGFuIGNyZWF0ZSBhIHdob2xlIG5ldyBoZWFkZXJmaWxlIGp1c3QKPiBmb3Ig dGhpcyBwdXJwb3NlLCBpdCBtYWtlcyBzZW5zZSB0byB1c2UgdGhlIGFscmVhZHkgZXhpc3RpbmcK PiBtbWMtb21hcC5oLgoKTG9va3MgZ29vZCB0byBtZSBhbmQgc2hvdWxkIG5vdCBjb25mbGljdCB3 aXRoIGFueXRoaW5nIHNvIGZlZWwKZnJlZSB0byBxdWV1ZSBhbG9uZyB3aXRoIHlvdXIgb3RoZXIg cGF0Y2hlczoKCkFja2VkLWJ5OiBUb255IExpbmRncmVuIDx0b255QGF0b21pZGUuY29tPgoKCj4g Q2M6IFVsZiBIYW5zc29uIDx1bGYuaGFuc3NvbkBsaW5hcm8ub3JnPgo+IENjOiBsaW51eC1tbWNA dmdlci5rZXJuZWwub3JnCj4gQ2M6IFRvbnkgTGluZGdyZW4gPHRvbnlAYXRvbWlkZS5jb20+Cj4g Q2M6IGxpbnV4LW9tYXBAdmdlci5rZXJuZWwub3JnCj4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVz IDxsZWUuam9uZXNAbGluYXJvLm9yZz4KPiAtLS0KPiAgYXJjaC9hcm0vbWFjaC1vbWFwMi9tbWMu aCAgICAgICAgICAgICAgfCA0IC0tLS0KPiAgaW5jbHVkZS9saW51eC9wbGF0Zm9ybV9kYXRhL21t Yy1vbWFwLmggfCAzICsrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgNCBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vbWFjaC1vbWFwMi9tbWMuaCBi L2FyY2gvYXJtL21hY2gtb21hcDIvbW1jLmgKPiBpbmRleCA3ZjRlMDUzYzM0MzQ0Li5iNTUzM2U5 M2NiNjMyIDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtL21hY2gtb21hcDIvbW1jLmgKPiArKysgYi9h cmNoL2FybS9tYWNoLW9tYXAyL21tYy5oCj4gQEAgLTE2LDcgKzE2LDMgQEAgc3RhdGljIGlubGlu ZSBpbnQgb21hcF9tc2RpX3Jlc2V0KHN0cnVjdCBvbWFwX2h3bW9kICpvaCkKPiAgCXJldHVybiAw Owo+ICB9Cj4gICNlbmRpZgo+IC0KPiAtLyogY2FsbGVkIGZyb20gYm9hcmQtc3BlY2lmaWMgY2Fy ZCBkZXRlY3Rpb24gc2VydmljZSByb3V0aW5lICovCj4gLWV4dGVybiB2b2lkIG9tYXBfbW1jX25v dGlmeV9jb3Zlcl9ldmVudChzdHJ1Y3QgZGV2aWNlICpkZXYsIGludCBzbG90LAo+IC0JCQkJCWlu dCBpc19jbG9zZWQpOwo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3BsYXRmb3JtX2RhdGEv bW1jLW9tYXAuaCBiL2luY2x1ZGUvbGludXgvcGxhdGZvcm1fZGF0YS9tbWMtb21hcC5oCj4gaW5k ZXggOWFjZjBlODdhYTliZS4uZjBiODk0N2U2YjA3ZCAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2xp bnV4L3BsYXRmb3JtX2RhdGEvbW1jLW9tYXAuaAo+ICsrKyBiL2luY2x1ZGUvbGludXgvcGxhdGZv cm1fZGF0YS9tbWMtb21hcC5oCj4gQEAgLTExNiwzICsxMTYsNiBAQCBzdHJ1Y3Qgb21hcF9tbWNf cGxhdGZvcm1fZGF0YSB7Cj4gIAo+ICAJfSBzbG90c1tPTUFQX01NQ19NQVhfU0xPVFNdOwo+ICB9 Owo+ICsKPiArZXh0ZXJuIHZvaWQgb21hcF9tbWNfbm90aWZ5X2NvdmVyX2V2ZW50KHN0cnVjdCBk ZXZpY2UgKmRldiwgaW50IHNsb3QsCj4gKwkJCQkJaW50IGlzX2Nsb3NlZCk7Cj4gLS0gCj4gMi4y NS4xCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==