From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Thu, 2 Jul 2020 17:55:59 +0100 From: Catalin Marinas Subject: Re: [PATCH v6 1/2] crash_core, vmcoreinfo: Append 'MAX_PHYSMEM_BITS' to vmcoreinfo Message-ID: <20200702165558.GH22241@gaia> References: <1589395957-24628-1-git-send-email-bhsharma@redhat.com> <1589395957-24628-2-git-send-email-bhsharma@redhat.com> <20200702110003.GC22241@gaia> <20200702120855.GD21026@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200702120855.GD21026@dhcp-128-65.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Dave Young Cc: Mark Rutland , Kazuhito Hagio , Michael Ellerman , Bhupesh Sharma , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Paul Mackerras , Benjamin Herrenschmidt , Boris Petkov , James Morse , Thomas Gleixner , bhupesh.linux@gmail.com, Will Deacon , Ingo Molnar , linux-arm-kernel@lists.infradead.org, Dave Anderson On Thu, Jul 02, 2020 at 08:08:55PM +0800, Dave Young wrote: > Hi Catalin, > On 07/02/20 at 12:00pm, Catalin Marinas wrote: > > On Thu, May 14, 2020 at 12:22:36AM +0530, Bhupesh Sharma wrote: > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > index 9f1557b98468..18175687133a 100644 > > > --- a/kernel/crash_core.c > > > +++ b/kernel/crash_core.c > > > @@ -413,6 +413,7 @@ static int __init crash_save_vmcoreinfo_init(void) > > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > > VMCOREINFO_STRUCT_SIZE(mem_section); > > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > > + VMCOREINFO_NUMBER(MAX_PHYSMEM_BITS); > > > #endif > > > VMCOREINFO_STRUCT_SIZE(page); > > > VMCOREINFO_STRUCT_SIZE(pglist_data); > > > > I can queue this patch via the arm64 tree (together with the second one) > > but I'd like an ack from the kernel/crash_core.c maintainers. They don't > > seem to have been cc'ed either (only the kexec list). > > For the VMCOREINFO part, I'm fine with the changes, but since I do not > understand the arm64 pieces so I would like to leave to arm64 people to > review. If arm64 bits are good enough, feel free to add: > > Acked-by: Dave Young Thanks. -- Catalin _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89915C433E0 for ; Thu, 2 Jul 2020 16:58:07 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02EB62088E for ; Thu, 2 Jul 2020 16:58:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02EB62088E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49yPRb0BFyzDqvy for ; Fri, 3 Jul 2020 02:58:03 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=cmarinas@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49yPPM4XrCzDqts for ; Fri, 3 Jul 2020 02:56:07 +1000 (AEST) Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A88D12084C; Thu, 2 Jul 2020 16:56:01 +0000 (UTC) Date: Thu, 2 Jul 2020 17:55:59 +0100 From: Catalin Marinas To: Dave Young Subject: Re: [PATCH v6 1/2] crash_core, vmcoreinfo: Append 'MAX_PHYSMEM_BITS' to vmcoreinfo Message-ID: <20200702165558.GH22241@gaia> References: <1589395957-24628-1-git-send-email-bhsharma@redhat.com> <1589395957-24628-2-git-send-email-bhsharma@redhat.com> <20200702110003.GC22241@gaia> <20200702120855.GD21026@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702120855.GD21026@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kazuhito Hagio , Bhupesh Sharma , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Paul Mackerras , Boris Petkov , James Morse , Thomas Gleixner , bhupesh.linux@gmail.com, Will Deacon , Ingo Molnar , linux-arm-kernel@lists.infradead.org, Dave Anderson Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Jul 02, 2020 at 08:08:55PM +0800, Dave Young wrote: > Hi Catalin, > On 07/02/20 at 12:00pm, Catalin Marinas wrote: > > On Thu, May 14, 2020 at 12:22:36AM +0530, Bhupesh Sharma wrote: > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > index 9f1557b98468..18175687133a 100644 > > > --- a/kernel/crash_core.c > > > +++ b/kernel/crash_core.c > > > @@ -413,6 +413,7 @@ static int __init crash_save_vmcoreinfo_init(void) > > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > > VMCOREINFO_STRUCT_SIZE(mem_section); > > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > > + VMCOREINFO_NUMBER(MAX_PHYSMEM_BITS); > > > #endif > > > VMCOREINFO_STRUCT_SIZE(page); > > > VMCOREINFO_STRUCT_SIZE(pglist_data); > > > > I can queue this patch via the arm64 tree (together with the second one) > > but I'd like an ack from the kernel/crash_core.c maintainers. They don't > > seem to have been cc'ed either (only the kexec list). > > For the VMCOREINFO part, I'm fine with the changes, but since I do not > understand the arm64 pieces so I would like to leave to arm64 people to > review. If arm64 bits are good enough, feel free to add: > > Acked-by: Dave Young Thanks. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77698C433E0 for ; Thu, 2 Jul 2020 16:57:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E66E2088E for ; Thu, 2 Jul 2020 16:57:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DCjEv6eS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E66E2088E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TnPl/CddySfdZmlztDkCAQ+B0B6INOwicu2Lj2P6ZaI=; b=DCjEv6eSSXpJy7PBtsEGSl7GW F7EGjMPYN48r/KEkw4/0L37JBaV1c9Vfr1I6MHkpqYxtZpp2IBgjvW+Ojsd2qHr+06VWEyPS29WEG If2EP0YfaIVqmCuRmu0kTr7Rf7i3QhMJ0q7w4FokJTyTA67Hn6UNZGGn+BXVhKqvgg+HsBQpWAr7P YbvoqMwAtah4PlpAvnDLy9vmis859PFFXCAyD3GAhHIadBxlI5QdlpGtWWTFCmXsBmsJi9+r5LbZm 65lNbjok4u0Hw7uOf89/2a4f3LtPF/5wecFGl6/0Lmig5lwKJsA/9n6Cuydjl11fwnyTH0kzrsxBK Mxy5ebwWg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr2VM-0005qe-VY; Thu, 02 Jul 2020 16:56:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr2VJ-0005pM-5Q; Thu, 02 Jul 2020 16:56:05 +0000 Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A88D12084C; Thu, 2 Jul 2020 16:56:01 +0000 (UTC) Date: Thu, 2 Jul 2020 17:55:59 +0100 From: Catalin Marinas To: Dave Young Subject: Re: [PATCH v6 1/2] crash_core, vmcoreinfo: Append 'MAX_PHYSMEM_BITS' to vmcoreinfo Message-ID: <20200702165558.GH22241@gaia> References: <1589395957-24628-1-git-send-email-bhsharma@redhat.com> <1589395957-24628-2-git-send-email-bhsharma@redhat.com> <20200702110003.GC22241@gaia> <20200702120855.GD21026@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200702120855.GD21026@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_125605_301179_B13A1E7B X-CRM114-Status: GOOD ( 18.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kazuhito Hagio , Michael Ellerman , Bhupesh Sharma , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Paul Mackerras , Benjamin Herrenschmidt , Boris Petkov , James Morse , Thomas Gleixner , bhupesh.linux@gmail.com, Will Deacon , Ingo Molnar , linux-arm-kernel@lists.infradead.org, Dave Anderson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 02, 2020 at 08:08:55PM +0800, Dave Young wrote: > Hi Catalin, > On 07/02/20 at 12:00pm, Catalin Marinas wrote: > > On Thu, May 14, 2020 at 12:22:36AM +0530, Bhupesh Sharma wrote: > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > index 9f1557b98468..18175687133a 100644 > > > --- a/kernel/crash_core.c > > > +++ b/kernel/crash_core.c > > > @@ -413,6 +413,7 @@ static int __init crash_save_vmcoreinfo_init(void) > > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > > VMCOREINFO_STRUCT_SIZE(mem_section); > > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > > + VMCOREINFO_NUMBER(MAX_PHYSMEM_BITS); > > > #endif > > > VMCOREINFO_STRUCT_SIZE(page); > > > VMCOREINFO_STRUCT_SIZE(pglist_data); > > > > I can queue this patch via the arm64 tree (together with the second one) > > but I'd like an ack from the kernel/crash_core.c maintainers. They don't > > seem to have been cc'ed either (only the kexec list). > > For the VMCOREINFO part, I'm fine with the changes, but since I do not > understand the arm64 pieces so I would like to leave to arm64 people to > review. If arm64 bits are good enough, feel free to add: > > Acked-by: Dave Young Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C097BC433E1 for ; Thu, 2 Jul 2020 16:56:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A25852088E for ; Thu, 2 Jul 2020 16:56:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726929AbgGBQ4F (ORCPT ); Thu, 2 Jul 2020 12:56:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:58856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbgGBQ4E (ORCPT ); Thu, 2 Jul 2020 12:56:04 -0400 Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A88D12084C; Thu, 2 Jul 2020 16:56:01 +0000 (UTC) Date: Thu, 2 Jul 2020 17:55:59 +0100 From: Catalin Marinas To: Dave Young Cc: Bhupesh Sharma , Mark Rutland , Kazuhito Hagio , Will Deacon , Michael Ellerman , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Paul Mackerras , James Morse , Benjamin Herrenschmidt , Boris Petkov , Thomas Gleixner , bhupesh.linux@gmail.com, linuxppc-dev@lists.ozlabs.org, Ingo Molnar , linux-arm-kernel@lists.infradead.org, Dave Anderson Subject: Re: [PATCH v6 1/2] crash_core, vmcoreinfo: Append 'MAX_PHYSMEM_BITS' to vmcoreinfo Message-ID: <20200702165558.GH22241@gaia> References: <1589395957-24628-1-git-send-email-bhsharma@redhat.com> <1589395957-24628-2-git-send-email-bhsharma@redhat.com> <20200702110003.GC22241@gaia> <20200702120855.GD21026@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702120855.GD21026@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 02, 2020 at 08:08:55PM +0800, Dave Young wrote: > Hi Catalin, > On 07/02/20 at 12:00pm, Catalin Marinas wrote: > > On Thu, May 14, 2020 at 12:22:36AM +0530, Bhupesh Sharma wrote: > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > index 9f1557b98468..18175687133a 100644 > > > --- a/kernel/crash_core.c > > > +++ b/kernel/crash_core.c > > > @@ -413,6 +413,7 @@ static int __init crash_save_vmcoreinfo_init(void) > > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > > VMCOREINFO_STRUCT_SIZE(mem_section); > > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > > + VMCOREINFO_NUMBER(MAX_PHYSMEM_BITS); > > > #endif > > > VMCOREINFO_STRUCT_SIZE(page); > > > VMCOREINFO_STRUCT_SIZE(pglist_data); > > > > I can queue this patch via the arm64 tree (together with the second one) > > but I'd like an ack from the kernel/crash_core.c maintainers. They don't > > seem to have been cc'ed either (only the kexec list). > > For the VMCOREINFO part, I'm fine with the changes, but since I do not > understand the arm64 pieces so I would like to leave to arm64 people to > review. If arm64 bits are good enough, feel free to add: > > Acked-by: Dave Young Thanks. -- Catalin