All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	"Lad, Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v3 2/6] serial: core: Allow detach and attach serial device for console
Date: Thu, 2 Jul 2020 12:35:53 -0700	[thread overview]
Message-ID: <20200702193553.GN53169@atomide.com> (raw)
In-Reply-To: <CAMuHMdXvummZiDBu72WJmdanyP2r4dab8SbVLZaTRNrBfnRmTw@mail.gmail.com>

Hi,

* Geert Uytterhoeven <geert@linux-m68k.org> [200702 14:50]:
> On Sun, May 24, 2020 at 7:11 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > any special reason for this change ? It is not really explained in the
> > commit description.
> 
> Indeed. Why this change?

For a kernel console, we want it to work for important oopses
etc without trying to enable DMA or power on regulators for example.

And we want to get rid of pm_runtime_irq_safe() usage as that takes
a permanent usage count on the parent device. This causes issue where
uart can keep an interconnect instance from idling with let's say
genpd :)

Also, we cannot easily make the serial driver PM runtime generic
without removing the pm_runtime_irq_safe() dependency as it would
currently wrongly impose the same nasty dependency to all the serial
drivers.

So when a kernel console is attached, we want to keep it from idling.

For PM related testing, just detaching kernel console and configuring
it's autosuspend timeout works nicely with dmesg -w. Or actually in
that case using pstore console is even better.

Andy has a series pending for generic serial PM runtime support,
I guess he's going to be posting it as soon as the pending regressions
are dealt with.

Regards,

Tony

  reply	other threads:[~2020-07-02 19:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17 11:40 [PATCH v3 0/6] serial: Disable DMA and PM on kernel console Andy Shevchenko
2020-02-17 11:40 ` [PATCH v3 1/6] serial: core: Switch to use DEVICE_ATTR_RO() Andy Shevchenko
2020-02-17 11:40 ` [PATCH v3 2/6] serial: core: Allow detach and attach serial device for console Andy Shevchenko
2020-05-24 17:10   ` Guenter Roeck
2020-05-25 10:38     ` Andy Shevchenko
2020-05-25 13:59       ` Guenter Roeck
2020-07-02 14:48     ` Geert Uytterhoeven
2020-07-02 19:35       ` Tony Lindgren [this message]
2020-07-02 20:03         ` Geert Uytterhoeven
2020-07-02 20:35           ` Guenter Roeck
2020-07-02 20:39           ` Tony Lindgren
2020-07-03 11:31       ` Geert Uytterhoeven
2020-07-04 15:43         ` Andy Shevchenko
2020-07-04 16:33           ` Andy Shevchenko
2020-02-17 11:40 ` [PATCH v3 3/6] serial: 8250_port: Switch to use DEVICE_ATTR_RW() Andy Shevchenko
2020-02-17 11:40 ` [PATCH v3 4/6] serial: 8250_port: Use dev_*() instead of pr_*() Andy Shevchenko
2020-02-17 11:40 ` [PATCH v3 5/6] serial: 8250_port: Don't use power management for kernel console Andy Shevchenko
2020-02-17 11:40 ` [PATCH v3 6/6] serial: 8250_port: Disable DMA operations " Andy Shevchenko
2020-02-17 22:51 ` [PATCH v3 0/6] serial: Disable DMA and PM on " Tony Lindgren
2020-02-18  8:58 ` Petr Mladek
2020-02-24  9:09   ` Andy Shevchenko
2020-02-24 12:23     ` Petr Mladek
2020-03-10 13:44       ` Andy Shevchenko
2020-03-17 18:50         ` Greg Kroah-Hartman
2020-03-17 14:23       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702193553.GN53169@atomide.com \
    --to=tony@atomide.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.