Re: [RFC PATCH v1] ufs: introduce async ufs interface initialization

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3440 bytes --]

Hi Kiwoong,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on scsi/for-next]
[also build test WARNING on mkp-scsi/for-next]
[cannot apply to v5.8-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kiwoong-Kim/ufs-introduce-async-ufs-interface-initialization/20200702-163018
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 003a086ffc0d1affbb8300b36225fb8150a2d40a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/scsi/ufs/ufshcd.c:8329:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
           if (!ufshcd_is_ufs_dev_active(hba)) {
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/scsi/ufs/ufshcd.c:8360:9: note: uninitialized use occurs here
           return ret;
                  ^~~
   drivers/scsi/ufs/ufshcd.c:8329:2: note: remove the 'if' if its condition is always true
           if (!ufshcd_is_ufs_dev_active(hba)) {
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/scsi/ufs/ufshcd.c:8327:9: note: initialize the variable 'ret' to silence this warning
           int ret;
                  ^
                   = 0
   1 warning generated.

vim +8329 drivers/scsi/ufs/ufshcd.c

  8324	
  8325	static int ufshcd_post_resume(struct ufs_hba *hba)
  8326	{
  8327		int ret;
  8328	
> 8329		if (!ufshcd_is_ufs_dev_active(hba)) {
  8330			ret = ufshcd_set_dev_pwr_mode(hba, UFS_ACTIVE_PWR_MODE);
  8331			if (ret)
  8332				goto out;
  8333		}
  8334	
  8335		if (ufshcd_keep_autobkops_enabled_except_suspend(hba))
  8336			ufshcd_enable_auto_bkops(hba);
  8337		else
  8338			/*
  8339			 * If BKOPs operations are urgently needed at this moment then
  8340			 * keep auto-bkops enabled or else disable it.
  8341			 */
  8342			ufshcd_urgent_bkops(hba);
  8343	
  8344		hba->clk_gating.is_suspended = false;
  8345	
  8346		if (hba->clk_scaling.is_allowed)
  8347			ufshcd_resume_clkscaling(hba);
  8348	
  8349		/* Enable Auto-Hibernate if configured */
  8350		ufshcd_auto_hibern8_enable(hba);
  8351	
  8352		if (hba->dev_info.b_rpm_dev_flush_capable) {
  8353			hba->dev_info.b_rpm_dev_flush_capable = false;
  8354			cancel_delayed_work(&hba->rpm_dev_flush_recheck_work);
  8355		}
  8356	
  8357		/* Schedule clock gating in case of no access to UFS device yet */
  8358		ufshcd_release(hba);
  8359	out:
  8360		return ret;
  8361	}
  8362	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 75316 bytes --]