From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Send hotplug event if edid had changed
Date: Fri, 03 Jul 2020 08:31:59 +0800 [thread overview]
Message-ID: <20200703003159.GN3874@shao2-debian> (raw)
In-Reply-To: <20200630002700.5451-4-kunal1.joshi@intel.com>
[-- Attachment #1: Type: text/plain, Size: 5574 bytes --]
Hi Kunal,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on linus/master v5.8-rc3]
[cannot apply to drm-intel/for-linux-next next-20200701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kunal-Joshi/Send-a-hotplug-when-edid-changes/20200630-152626
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/display/intel_hotplug.c:286:6: warning: Variable 'old_epoch_counter' is not assigned a value. [unassignedVariable]
u64 old_epoch_counter;
^
>> drivers/gpu/drm/i915/display/intel_hotplug.c:295:6: warning: Uninitialized variable: old_epoch_counter [uninitvar]
if (old_epoch_counter != connector->base.epoch_counter)
^
# https://github.com/0day-ci/linux/commit/52973bbb22573f4d170806d2ade0a8871be92d89
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 52973bbb22573f4d170806d2ade0a8871be92d89
vim +/old_epoch_counter +286 drivers/gpu/drm/i915/display/intel_hotplug.c
77913b39addfaa8 drivers/gpu/drm/i915/intel_hotplug.c Jani Nikula 2015-06-18 279
3944709df8e9298 drivers/gpu/drm/i915/display/intel_hotplug.c Imre Deak 2019-07-11 280 enum intel_hotplug_state
3944709df8e9298 drivers/gpu/drm/i915/display/intel_hotplug.c Imre Deak 2019-07-11 281 intel_encoder_hotplug(struct intel_encoder *encoder,
8c8919c7c99f097 drivers/gpu/drm/i915/display/intel_hotplug.c Imre Deak 2020-03-30 282 struct intel_connector *connector)
77913b39addfaa8 drivers/gpu/drm/i915/intel_hotplug.c Jani Nikula 2015-06-18 283 {
dba14b27dd3ca5c drivers/gpu/drm/i915/intel_hotplug.c Ville Syrjälä 2018-01-17 284 struct drm_device *dev = connector->base.dev;
77913b39addfaa8 drivers/gpu/drm/i915/intel_hotplug.c Jani Nikula 2015-06-18 285 enum drm_connector_status old_status;
52973bbb22573f4 drivers/gpu/drm/i915/display/intel_hotplug.c Stanislav Lisovskiy 2020-06-30 @286 u64 old_epoch_counter;
52973bbb22573f4 drivers/gpu/drm/i915/display/intel_hotplug.c Stanislav Lisovskiy 2020-06-30 287 bool ret = false;
77913b39addfaa8 drivers/gpu/drm/i915/intel_hotplug.c Jani Nikula 2015-06-18 288
f4224a4cb16c248 drivers/gpu/drm/i915/display/intel_hotplug.c Pankaj Bharadiya 2020-01-28 289 drm_WARN_ON(dev, !mutex_is_locked(&dev->mode_config.mutex));
dba14b27dd3ca5c drivers/gpu/drm/i915/intel_hotplug.c Ville Syrjälä 2018-01-17 290 old_status = connector->base.status;
77913b39addfaa8 drivers/gpu/drm/i915/intel_hotplug.c Jani Nikula 2015-06-18 291
dba14b27dd3ca5c drivers/gpu/drm/i915/intel_hotplug.c Ville Syrjälä 2018-01-17 292 connector->base.status =
dba14b27dd3ca5c drivers/gpu/drm/i915/intel_hotplug.c Ville Syrjälä 2018-01-17 293 drm_helper_probe_detect(&connector->base, NULL, false);
6c5ed5ae353cdf1 drivers/gpu/drm/i915/intel_hotplug.c Maarten Lankhorst 2017-04-06 294
52973bbb22573f4 drivers/gpu/drm/i915/display/intel_hotplug.c Stanislav Lisovskiy 2020-06-30 @295 if (old_epoch_counter != connector->base.epoch_counter)
52973bbb22573f4 drivers/gpu/drm/i915/display/intel_hotplug.c Stanislav Lisovskiy 2020-06-30 296 ret = true;
77913b39addfaa8 drivers/gpu/drm/i915/intel_hotplug.c Jani Nikula 2015-06-18 297
52973bbb22573f4 drivers/gpu/drm/i915/display/intel_hotplug.c Stanislav Lisovskiy 2020-06-30 298 if (ret) {
52973bbb22573f4 drivers/gpu/drm/i915/display/intel_hotplug.c Stanislav Lisovskiy 2020-06-30 299 DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %s to %s(epoch counter %llu)\n",
dba14b27dd3ca5c drivers/gpu/drm/i915/intel_hotplug.c Ville Syrjälä 2018-01-17 300 connector->base.base.id,
dba14b27dd3ca5c drivers/gpu/drm/i915/intel_hotplug.c Ville Syrjälä 2018-01-17 301 connector->base.name,
77913b39addfaa8 drivers/gpu/drm/i915/intel_hotplug.c Jani Nikula 2015-06-18 302 drm_get_connector_status_name(old_status),
52973bbb22573f4 drivers/gpu/drm/i915/display/intel_hotplug.c Stanislav Lisovskiy 2020-06-30 303 drm_get_connector_status_name(connector->base.status),
52973bbb22573f4 drivers/gpu/drm/i915/display/intel_hotplug.c Stanislav Lisovskiy 2020-06-30 304 connector->base.epoch_counter);
3944709df8e9298 drivers/gpu/drm/i915/display/intel_hotplug.c Imre Deak 2019-07-11 305 return INTEL_HOTPLUG_CHANGED;
77913b39addfaa8 drivers/gpu/drm/i915/intel_hotplug.c Jani Nikula 2015-06-18 306 }
52973bbb22573f4 drivers/gpu/drm/i915/display/intel_hotplug.c Stanislav Lisovskiy 2020-06-30 307 return INTEL_HOTPLUG_UNCHANGED;
52973bbb22573f4 drivers/gpu/drm/i915/display/intel_hotplug.c Stanislav Lisovskiy 2020-06-30 308 }
77913b39addfaa8 drivers/gpu/drm/i915/intel_hotplug.c Jani Nikula 2015-06-18 309
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2020-07-03 0:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 0:26 [Intel-gfx] [PATCH v6 0/3] Send a hotplug when edid changes Kunal Joshi
2020-06-30 0:26 ` [Intel-gfx] [PATCH v6 1/3] drm: Add helper to compare edids Kunal Joshi
2020-06-30 0:26 ` [Intel-gfx] [PATCH v6 2/3] drm: Introduce epoch counter to drm_connector Kunal Joshi
2020-06-30 0:27 ` [Intel-gfx] [PATCH v6 3/3] drm/i915: Send hotplug event if edid had changed Kunal Joshi
2020-07-03 0:31 ` kernel test robot [this message]
2020-06-30 14:37 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Send a hotplug when edid changes (rev10) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-07-02 8:51 [Intel-gfx] [PATCH v6 3/3] drm/i915: Send hotplug event if edid had changed kernel test robot
2020-06-26 9:13 [Intel-gfx] [PATCH v6 0/3] Send a hotplug when edid changes Kunal Joshi
2020-06-26 9:13 ` [Intel-gfx] [PATCH v6 3/3] drm/i915: Send hotplug event if edid had changed Kunal Joshi
2020-06-23 18:57 [PATCH v6 0/3] Send a hotplug when edid changes Kunal Joshi
2020-06-23 18:57 ` [Intel-gfx] [PATCH v6 3/3] drm/i915: Send hotplug event if edid had changed Kunal Joshi
2020-06-25 8:36 ` Maarten Lankhorst
2020-06-25 10:46 ` Lisovskiy, Stanislav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703003159.GN3874@shao2-debian \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.