From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31184C433E0 for ; Fri, 3 Jul 2020 08:57:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00C3A20836 for ; Fri, 3 Jul 2020 08:57:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593766634; bh=MlIcJE04yAgAAu3tlEad3BGw8TeJnm5KnC11ClCsEGw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XuFeUK/TVlKU5vWr3zhLAmbR9KcVRfqwV6cMlsP2i7LugBCkDMas5jdfXVeBasgy9 fzYqmrcvg7QeUNxzXwnqoL3QLcizlJ8nuUOS+lcvJWcnfK8AGjeZq+IdX8rZ1b8cWj ugcdjN5BxrQ9o2hVgJnAH/j6MdwsonObTHLrPYiQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726183AbgGCI5N (ORCPT ); Fri, 3 Jul 2020 04:57:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:56526 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725915AbgGCI5N (ORCPT ); Fri, 3 Jul 2020 04:57:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 81DE7207DA; Fri, 3 Jul 2020 08:57:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593766633; bh=MlIcJE04yAgAAu3tlEad3BGw8TeJnm5KnC11ClCsEGw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=euAJ/1Cw+cgiXEPyHS9lPiM9oRuLjCyR7qxcAX4anVUzRd1giMMZ51g2svuiS7cTS fstfZh0fW506I7sgzzeTDhF2hXUCXMnlz3sMcA2kAAJeTIYoa9xEXLyN/3+Cg7od37 siNlDSUl3NXsjgaeql2HhidPfVxmFXgjKqYQ+shY= Date: Fri, 3 Jul 2020 10:57:17 +0200 From: Greg Kroah-Hartman To: Chris Dickens Cc: linux-usb , Felipe Balbi , andrzej.p@samsung.com Subject: Re: [PATCH] usb: gadget: composite: Remove dedicated OS Feature Descriptors request Message-ID: <20200703085717.GA2514858@kroah.com> References: <20200703072436.GB2225285@kroah.com> <20200703083534.5292-1-christopher.a.dickens@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200703083534.5292-1-christopher.a.dickens@gmail.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Jul 03, 2020 at 01:35:34AM -0700, Chris Dickens wrote: > Currently Microsoft OS Feature Descriptors are handled using a > separately allocated USB request, however everything about this USB > request is identical to the USB request used for all other control > responses. Simplify the code by removing this separate USB request and > using the same USB request as all other control responses. > > While at it, simplify the composite_ep0_queue() function by removing the > req and gfp_flags arguments. The former is no longer necessary with a > single USB request and the latter is always GFP_ATOMIC. > > Signed-off-by: Chris Dickens > --- > drivers/usb/gadget/composite.c | 69 +++++----------------------------- > drivers/usb/gadget/configfs.c | 11 ------ > include/linux/usb/composite.h | 9 ----- > 3 files changed, 9 insertions(+), 80 deletions(-) Did you confirm by testing that this actually works with a real device that wants to talk to Windows with those feature descriptors? thanks, greg k-h