From: Jean Delvare <jdelvare@suse.de>
To: Krzysztof Halasa <khalasa@piap.pl>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH 2/2] soc: ixp4xx: Really select helper drivers automatically
Date: Fri, 3 Jul 2020 10:27:41 +0200 [thread overview]
Message-ID: <20200703102741.6b0b03a2@endymion> (raw)
In-Reply-To: <20200703102617.0b9f933e@endymion>
Kconfig claims that the ixp4xx-qmgr and ixp4xx-npe helper drivers
are selected automatically as needed. However this is not what the
Kconfig entries are doing. Convert depends to select to match the
help texts.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Krzysztof Halasa <khalasa@piap.pl>
---
drivers/crypto/Kconfig | 4 +++-
drivers/net/ethernet/xscale/Kconfig | 7 ++++---
drivers/net/wan/Kconfig | 4 +++-
3 files changed, 10 insertions(+), 5 deletions(-)
--- linux-5.7.orig/drivers/net/ethernet/xscale/Kconfig 2020-06-01 01:49:15.000000000 +0200
+++ linux-5.7/drivers/net/ethernet/xscale/Kconfig 2020-06-23 13:05:23.071767146 +0200
@@ -6,8 +6,7 @@
config NET_VENDOR_XSCALE
bool "Intel XScale IXP devices"
default y
- depends on NET_VENDOR_INTEL && (ARM && ARCH_IXP4XX && \
- IXP4XX_NPE && IXP4XX_QMGR)
+ depends on NET_VENDOR_INTEL && (ARM && ARCH_IXP4XX)
---help---
If you have a network (Ethernet) card belonging to this class, say Y.
@@ -20,9 +19,11 @@ if NET_VENDOR_XSCALE
config IXP4XX_ETH
tristate "Intel IXP4xx Ethernet support"
- depends on ARM && ARCH_IXP4XX && IXP4XX_NPE && IXP4XX_QMGR
+ depends on ARM && ARCH_IXP4XX
select PHYLIB
select NET_PTP_CLASSIFY
+ select IXP4XX_NPE
+ select IXP4XX_QMGR
---help---
Say Y here if you want to use built-in Ethernet ports
on IXP4xx processor.
--- linux-5.7.orig/drivers/net/wan/Kconfig 2020-06-01 01:49:15.000000000 +0200
+++ linux-5.7/drivers/net/wan/Kconfig 2020-06-23 13:05:23.072767157 +0200
@@ -315,8 +315,10 @@ config DSCC4_PCI_RST
config IXP4XX_HSS
tristate "Intel IXP4xx HSS (synchronous serial port) support"
- depends on HDLC && IXP4XX_NPE && IXP4XX_QMGR
+ depends on HDLC
depends on ARCH_IXP4XX
+ select IXP4XX_NPE
+ select IXP4XX_QMGR
help
Say Y here if you want to use built-in HSS ports
on IXP4xx processor.
--- linux-5.7.orig/drivers/crypto/Kconfig 2020-06-01 01:49:15.000000000 +0200
+++ linux-5.7/drivers/crypto/Kconfig 2020-06-25 00:04:11.570461001 +0200
@@ -308,11 +308,13 @@ config CRYPTO_DEV_TALITOS2
config CRYPTO_DEV_IXP4XX
tristate "Driver for IXP4xx crypto hardware acceleration"
- depends on ARCH_IXP4XX && IXP4XX_QMGR && IXP4XX_NPE
+ depends on ARCH_IXP4XX
select CRYPTO_LIB_DES
select CRYPTO_AEAD
select CRYPTO_AUTHENC
select CRYPTO_SKCIPHER
+ select IXP4XX_NPE
+ select IXP4XX_QMGR
help
Driver for the IXP4xx NPE crypto engine.
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2020-07-03 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 8:26 [PATCH 1/2] soc: ixp4xx: List the whole directory in MAINTAINERS Jean Delvare
2020-07-03 8:27 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703102741.6b0b03a2@endymion \
--to=jdelvare@suse.de \
--cc=khalasa@piap.pl \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.