From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F113C433DF for ; Fri, 3 Jul 2020 11:11:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D787C20672 for ; Fri, 3 Jul 2020 11:11:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D787C20672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B06986EB59; Fri, 3 Jul 2020 11:11:14 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id C50E36EB59 for ; Fri, 3 Jul 2020 11:11:12 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 13F9780635; Fri, 3 Jul 2020 13:11:09 +0200 (CEST) Date: Fri, 3 Jul 2020 13:11:08 +0200 From: Sam Ravnborg To: Thomas Zimmermann Subject: Re: [PATCH v2 12/14] drm/ast: Replace struct ast_crtc with struct drm_crtc Message-ID: <20200703111108.GA3928@ravnborg.org> References: <20200702115029.5281-1-tzimmermann@suse.de> <20200702115029.5281-13-tzimmermann@suse.de> <20200703063848.GA1690637@ravnborg.org> <59bd0ea8-ab95-5e37-287c-021c33e6556d@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <59bd0ea8-ab95-5e37-287c-021c33e6556d@suse.de> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=kEpzv6bw_eon_2oUgLIA:9 a=CjuIK1q_8ugA:10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@redhat.com, emil.l.velikov@gmail.com, kraxel@redhat.com, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Thomas. On Fri, Jul 03, 2020 at 08:51:31AM +0200, Thomas Zimmermann wrote: > Hi Sam > > Am 03.07.20 um 08:38 schrieb Sam Ravnborg: > > Hi Thomas. > > > > Just browsing code.. > > > > On Thu, Jul 02, 2020 at 01:50:27PM +0200, Thomas Zimmermann wrote: > >> Struct ast_crtc has been cleaned up and it's now a wrapper around the > >> DRM CRTC structure struct drm_crtc. This patch converts the driver to > >> struct drm_crtc and removes struct ast_crtc. > >> > >> Signed-off-by: Thomas Zimmermann > > > > Why is it we cannot embed struct drm_crtc? > > I want to do that in a later patchset. The conversion to managed code is > fairly large, so thought it might be better to do it in several rounds. Understood, and several rounds are good. > > This patchset is only for modesetting. I have another patchset that > converts the memory management to managed interfaces. After that the > final patchset will address device structures. Embedding everything CRTC > and other structures in struct ast_private would be part of this. > > If you prefer a longer patchset that does everything, let me know. > > > And I also failed to see where is is de-allocated - but surely I miss > > something obvious here. > > It's freed in ast_crtc_destroy(). Ohh, one of the places that worked/works because struct crtc was/is the first member. I get it now, thanks for the explanation. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel