All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Sven Auhagen <sven.auhagen@voleatech.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/1 v2] netfilter: Restore the CT mark in Flow Offload
Date: Sat, 4 Jul 2020 02:11:33 +0200	[thread overview]
Message-ID: <20200704001133.GA1023@salvia> (raw)
In-Reply-To: <20200601111209.fluj44n5utfoicko@SvensMacBookAir.sven.lan>

Hi Sven,

On Mon, Jun 01, 2020 at 01:12:09PM +0200, Sven Auhagen wrote:
> The skb mark is often used in TC action at egress.
> In order to have the skb mark set we can add it to the
> skb when we do a flow offload lookup from the CT mark.

Thanks for your patch.

I can see a use case for this, however, enabling the skb->mark =
ct->mark restoration is not very flexible.

Every time a default behaviour like this is introduced in the
netfilter codebase, there is someone following up to request a toggle
to enable / to disable it.

  reply	other threads:[~2020-07-04  0:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01 11:12 [PATCH 1/1 v2] netfilter: Restore the CT mark in Flow Offload Sven Auhagen
2020-07-04  0:11 ` Pablo Neira Ayuso [this message]
2020-07-04  4:53   ` Sven Auhagen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200704001133.GA1023@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=sven.auhagen@voleatech.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.