From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:5042:0:0:0:0:0 with SMTP id a2csp4020520lfm; Sun, 5 Jul 2020 04:48:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxETnTpYZC5UmaAeFjNgBQaqor3z8rW7x8+czKMicrdq7hXuK4ARou+nVZAeXUpbLDY49lk X-Received: by 2002:a5b:a91:: with SMTP id h17mr326705ybq.148.1593949713928; Sun, 05 Jul 2020 04:48:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593949713; cv=none; d=google.com; s=arc-20160816; b=1CeDv+FppcbcqPmDcmkjiZj/15QtTbvSctkeXx5sSw3ezhCsjsTQVVtxIE799GOJw3 j4uDyyAqrGQezbRRK3RV/i/Bd/J5QP0wgPO8jcTckukuJLR7L8G5qjpx/I/frrFLrm9n GKbxgYU1FDbcYeVnQJ+LJV4mc1gQQM4YXzj6tpCs69VZ8Nv7nb37YMgTxgzVcxOJvgdV yoVvMQUnCfTfh/u/YehMHYKesS7sblHPcjJqFAicDr3Q/20WSITsUnxOng0aYQWxjxLR aiEkth9xxxyQa55KBaNR8CUROKkp1fWokYrxuF2eLRKHyvKDdcxQKa0gIGMLJcsg9/uz NvXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-disposition:in-reply-to :mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=lZKE5ibmmhD5CoUCw8ft6VuFKZl2+IRVJsKFBAgOpXg=; b=w1S28IgBTFPxdFL1G0JUDTC5ryIynvy+ahnT/4jh4diA4Crf75gv5dXE/2vdHpS6bj ESZv7TZbUbjQIt3/BdcYskOikdn7czFKv8/lPkPR6PJkX3S9/rM4WCiMLl4/lJTc8v4k XoniIMVlfTpCXnS0vZYf5Yk16OVnsFGzGFWBVylB6ESh1KMmH8fw6ySFPbrjrk38BMnD 0G600E/nav1xeQHWEUZ+bTFxAEMfudvZCjXTLMbMLopVBd1cJwpN2O/w3IMUJTg2Aotg /ODRoqfxE35/Q9ByaUNbw/mkmWLqe/AMY+llogqwE68f4Rv9bA6fTVkzjvBHn9lovz8W M0mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=V6AvlJbO; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id r16si2094270ybk.393.2020.07.05.04.48.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Jul 2020 04:48:33 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=V6AvlJbO; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:40258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1js38L-0002GO-Bq for alex.bennee@linaro.org; Sun, 05 Jul 2020 07:48:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1js38E-0002GI-Lq for qemu-arm@nongnu.org; Sun, 05 Jul 2020 07:48:26 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:60613 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1js38D-0008Dw-9b for qemu-arm@nongnu.org; Sun, 05 Jul 2020 07:48:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593949704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lZKE5ibmmhD5CoUCw8ft6VuFKZl2+IRVJsKFBAgOpXg=; b=V6AvlJbOKVSXRIErQc5riW8hxq2CFNE14ZGbFuTAUuv24uusysNg2hBS5YbSECoynkT/CX KrzNzGfG/JuBkoGxUGTTc9pnKsXmfPZWz3LbxCh2QyRSo/ZBFTF+XGR4Uvumc0lKyHaIqc PtmrvDbw+tSFlCxpAwb2N1I17vpTaRQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-280-8dDD7IKRMcqVd4TBFasqlA-1; Sun, 05 Jul 2020 07:48:20 -0400 X-MC-Unique: 8dDD7IKRMcqVd4TBFasqlA-1 Received: by mail-wr1-f70.google.com with SMTP id b8so23837070wro.19 for ; Sun, 05 Jul 2020 04:48:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lZKE5ibmmhD5CoUCw8ft6VuFKZl2+IRVJsKFBAgOpXg=; b=mCkEBi5I3PwYBbktwfsRAXujWw+KA511sEghhfSc4jiuLNmq+oXz4pkwTq3NM8UvPF XwxjRSQ/W9fvOLOepS7k/2VhBgV0vub4449UUgYaVkH3Y3mbcMU8+KWPibephkjWdB5G beyMNjCXA7L470ud+kD2tJBi4j8ln9i41ed8fj9fCsOBP0xfzoTbznyPvP9utjT5x9Dm eeohi735/ueldcPAwAFuPLZ68+xFM5lwJFvsJ4giOrojc2EMx9ThiHf4guqUiBQSG9yI pCQ9FMRxmerpt4EobUylCCeLHNr3iYLRPJgPgUYCzbd+g13FwuGfpx2G7lQxbhXO5CGe XCFg== X-Gm-Message-State: AOAM531uDCsm6z4U53aeRunCSNKJEchUGcGeKf6sDVXjyaWwsH3/7E3q qrSCqjVFi/mnEVw8T1IaKcOIpfuo+Be6KM6NVaF3/B+T9Y1VzaTglQ2s97fVS+lOuHRVjNpYbe5 L+4yXBvAuERyY X-Received: by 2002:adf:f3cd:: with SMTP id g13mr42135500wrp.45.1593949699398; Sun, 05 Jul 2020 04:48:19 -0700 (PDT) X-Received: by 2002:adf:f3cd:: with SMTP id g13mr42135475wrp.45.1593949698782; Sun, 05 Jul 2020 04:48:18 -0700 (PDT) Received: from redhat.com (bzq-79-182-31-92.red.bezeqint.net. [79.182.31.92]) by smtp.gmail.com with ESMTPSA id t16sm21374048wru.9.2020.07.05.04.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2020 04:48:17 -0700 (PDT) Date: Sun, 5 Jul 2020 07:48:14 -0400 From: "Michael S. Tsirkin" To: Gerd Hoffmann Subject: Re: [PATCH v4 08/21] microvm/acpi: add minimal acpi support Message-ID: <20200704053018-mutt-send-email-mst@kernel.org> References: <20200702204859.9876-1-kraxel@redhat.com> <20200702204859.9876-9-kraxel@redhat.com> <20200703084039-mutt-send-email-mst@kernel.org> <20200703192510.laaeku6kvudcs4g2@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: <20200703192510.laaeku6kvudcs4g2@sirius.home.kraxel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.61; envelope-from=mst@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/05 05:57:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Thomas Huth , Eduardo Habkost , Sergio Lopez , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , Igor Mammedov , Richard Henderson Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: NGT7HsWcLN1M On Fri, Jul 03, 2020 at 09:25:10PM +0200, Gerd Hoffmann wrote: > On Fri, Jul 03, 2020 at 09:09:43AM -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 02, 2020 at 10:48:46PM +0200, Gerd Hoffmann wrote: > > > + /* copy AML table into ACPI tables blob and patch header there */ > > > + g_array_append_vals(table_data, dsdt->buf->data, dsdt->buf->len); > > > + build_header(linker, table_data, > > > + (void *)(table_data->data + table_data->len - dsdt->buf->len), > > > + "DSDT", dsdt->buf->len, 5, NULL, NULL); > > > > Why 5? Just curious ... > > IIRC because the hw reduced hardware profile needs acpi 5+ ... > > take care, > Gerd Well ACPI spec 5 says revision value is 2. Let's use standard practice in ACPI code, and add comments near each value documenting earliest spec revision where this appeared, chapter where they came from and some verbatim text that both explains and can be searched for in later spec revisions. In fact, same applies to a bunch of other code in this patchset which just uses macros which does not help all that much as they don't appear in spec as is. Can you pls go over it and add such comments where appropriate? -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB3C8C433E0 for ; Sun, 5 Jul 2020 11:49:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A728520723 for ; Sun, 5 Jul 2020 11:49:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AB1fSki6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A728520723 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1js38m-0002mK-Vt for qemu-devel@archiver.kernel.org; Sun, 05 Jul 2020 07:49:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1js38E-0002GC-DU for qemu-devel@nongnu.org; Sun, 05 Jul 2020 07:48:26 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:47729 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1js38C-0008Do-9c for qemu-devel@nongnu.org; Sun, 05 Jul 2020 07:48:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593949702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lZKE5ibmmhD5CoUCw8ft6VuFKZl2+IRVJsKFBAgOpXg=; b=AB1fSki6NI2IC6j6EbrZxyhP2qV2maiajOZuNtNdXB9j3xaTs/XGZDA+T5wn9aKf+51Y+f d50BIAvh5FhZYc52aOsSzQhrV2Z+f3GYvBMQEsjKwbuklIrVKqe/CrDKq3kPJt9ij2pTDN 8+4830O8ojcmanhso7aXSmqx+ryG+fU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-30-o4tTGj0nPXyyyaEj8nnpXQ-1; Sun, 05 Jul 2020 07:48:20 -0400 X-MC-Unique: o4tTGj0nPXyyyaEj8nnpXQ-1 Received: by mail-wm1-f70.google.com with SMTP id e15so41493322wme.8 for ; Sun, 05 Jul 2020 04:48:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lZKE5ibmmhD5CoUCw8ft6VuFKZl2+IRVJsKFBAgOpXg=; b=jdiWoD3D2zfyp/xxq1t7KB5D/IPMHNvY1Gw82G5KA3O3dPvbfA0uBsBodanUlAIpeb wpYzgrnI38z9GzvHL9oCePPRx4EWRRQqmx8E+6Q11m4sYM8Ao8ge9udrnqALukQFHdjt pZzCBQZPHL6yyNCoNusqfpgiK6UoOlQ61zOdO0VN2afZoI4/4rWik6jA/PHgDuidvzOb yhCKWr58wojG3HZWCJZeBbhsYim1NHGDZeV+rq5U42SOv4pHMJGLtp18dJak1718J4YW oGZaHyNT3AO7V8MRNcqIdpUxSk3ffXtTtXtEELti6IG/r+1EFkBN91iPwfL5Ys+RUPkw orFw== X-Gm-Message-State: AOAM532uleha0sCdFBbESHLjzwbZdrqWl2JixiOZZeypIE0mKjT0vu64 V/o1KARDm6S3OBfeiFYKopxD9ScnDhNYY0/TVFsNTnohmi1yts71HB5ifK4Fam09eA6IQVOETCY WOnUP5D/RrC19J+U= X-Received: by 2002:adf:f3cd:: with SMTP id g13mr42135508wrp.45.1593949699399; Sun, 05 Jul 2020 04:48:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxZ7kkRmqaAGVw+XCHJvhze8OibQl4KugR9vza8eK6nbSE3pjAmnBIRqqQXXN5vtllvHv1Yw== X-Received: by 2002:adf:f3cd:: with SMTP id g13mr42135475wrp.45.1593949698782; Sun, 05 Jul 2020 04:48:18 -0700 (PDT) Received: from redhat.com (bzq-79-182-31-92.red.bezeqint.net. [79.182.31.92]) by smtp.gmail.com with ESMTPSA id t16sm21374048wru.9.2020.07.05.04.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2020 04:48:17 -0700 (PDT) Date: Sun, 5 Jul 2020 07:48:14 -0400 From: "Michael S. Tsirkin" To: Gerd Hoffmann Subject: Re: [PATCH v4 08/21] microvm/acpi: add minimal acpi support Message-ID: <20200704053018-mutt-send-email-mst@kernel.org> References: <20200702204859.9876-1-kraxel@redhat.com> <20200702204859.9876-9-kraxel@redhat.com> <20200703084039-mutt-send-email-mst@kernel.org> <20200703192510.laaeku6kvudcs4g2@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: <20200703192510.laaeku6kvudcs4g2@sirius.home.kraxel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.61; envelope-from=mst@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/05 05:57:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Thomas Huth , Eduardo Habkost , Sergio Lopez , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Paolo Bonzini , Igor Mammedov , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jul 03, 2020 at 09:25:10PM +0200, Gerd Hoffmann wrote: > On Fri, Jul 03, 2020 at 09:09:43AM -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 02, 2020 at 10:48:46PM +0200, Gerd Hoffmann wrote: > > > + /* copy AML table into ACPI tables blob and patch header there */ > > > + g_array_append_vals(table_data, dsdt->buf->data, dsdt->buf->len); > > > + build_header(linker, table_data, > > > + (void *)(table_data->data + table_data->len - dsdt->buf->len), > > > + "DSDT", dsdt->buf->len, 5, NULL, NULL); > > > > Why 5? Just curious ... > > IIRC because the hw reduced hardware profile needs acpi 5+ ... > > take care, > Gerd Well ACPI spec 5 says revision value is 2. Let's use standard practice in ACPI code, and add comments near each value documenting earliest spec revision where this appeared, chapter where they came from and some verbatim text that both explains and can be searched for in later spec revisions. In fact, same applies to a bunch of other code in this patchset which just uses macros which does not help all that much as they don't appear in spec as is. Can you pls go over it and add such comments where appropriate? -- MST