From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] iio: magnetometer: bmc150: Add proper compatible for BMM150
Date: Sat, 4 Jul 2020 17:46:30 +0100 [thread overview]
Message-ID: <20200704174630.381cc2d3@archlinux> (raw)
In-Reply-To: <20200629100537.20365-2-krzk@kernel.org>
On Mon, 29 Jun 2020 12:05:37 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> The compatible for BMM150 should not have "_magn" suffix because, unlike
> two other Bosch devices, it is only a magnetometer.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Both applied to the togreg branch of iio.git and pushed out
as testing for the autobuilders to ignore them.
Thanks for tidying this up.
Jonathan
>
> ---
>
> Changes since v2:
> 1. Add compatible only for bmm150.
>
> Changes since v1:
> 1. New patch.
> ---
> drivers/iio/magnetometer/bmc150_magn_i2c.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/magnetometer/bmc150_magn_i2c.c b/drivers/iio/magnetometer/bmc150_magn_i2c.c
> index fb45b63c56e4..876e96005e33 100644
> --- a/drivers/iio/magnetometer/bmc150_magn_i2c.c
> +++ b/drivers/iio/magnetometer/bmc150_magn_i2c.c
> @@ -58,7 +58,8 @@ MODULE_DEVICE_TABLE(i2c, bmc150_magn_i2c_id);
> static const struct of_device_id bmc150_magn_of_match[] = {
> { .compatible = "bosch,bmc150_magn" },
> { .compatible = "bosch,bmc156_magn" },
> - { .compatible = "bosch,bmm150_magn" },
> + { .compatible = "bosch,bmm150_magn" }, /* deprecated compatible */
> + { .compatible = "bosch,bmm150" },
> { }
> };
> MODULE_DEVICE_TABLE(of, bmc150_magn_of_match);
next prev parent reply other threads:[~2020-07-04 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 10:05 [PATCH v3 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles Krzysztof Kozlowski
2020-06-29 10:05 ` [PATCH v3 2/2] iio: magnetometer: bmc150: Add proper compatible for BMM150 Krzysztof Kozlowski
2020-07-04 16:46 ` Jonathan Cameron [this message]
2020-07-13 19:05 ` [PATCH v3 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200704174630.381cc2d3@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.