From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F147C433E0 for ; Sun, 5 Jul 2020 23:32:31 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94F3020737 for ; Sun, 5 Jul 2020 23:32:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="d9f3r4Pd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PPgwtr4v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94F3020737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1DFDA16A0; Mon, 6 Jul 2020 01:31:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1DFDA16A0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1593991949; bh=gQmg+aViyd2eG4cg4uTdrGamN+wErKHFsIndgpKkrqY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=d9f3r4PdQrGkSsjoX0gElIyHeFIA5pEUp1uPdMwA692Cu9Jm8ar75vujmDwSJpJa+ pKQmWvLnJuO+sxQQiVM2Sbk9sIcTiYbHHqrxVYKDaRiFJ5OiPPNKj8T/lOheObVoyM TZniZmAab80vx3dPZhH5DkbtD5rwix8aGWdYvYeQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8CA89F801F9; Mon, 6 Jul 2020 01:31:38 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F13D8F80216; Mon, 6 Jul 2020 01:31:35 +0200 (CEST) Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EBCAEF800DA for ; Mon, 6 Jul 2020 01:31:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EBCAEF800DA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PPgwtr4v" Received: by mail-pl1-x643.google.com with SMTP id o1so8041712plk.1 for ; Sun, 05 Jul 2020 16:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Kau7zMY1dJtPnAeFjFb1bpRpxzhyG/k07bIDDi1B9Sw=; b=PPgwtr4vUclIXDDzRAzx5UNpfygKAAnwFGo8N6m019/7vON7mJvo2wH1tyFl8qwOtV KHIG72FyJXp+vEln8Jv+6+QDrjx6mpyRANzqfRjeiFJjJLP67GS0Ri3TBSmJhUpyQkBs o31T6l2WnekkjvWdXD22/yS29c9nuKKBzZ/L/RfmqD7zPsPk1BbHnUM73cikcLoFBzE3 R19e/XplnWi2I27+AM4A5D7XgwpXJsTg4zpbPuWYfOhyIw7KNSyuRmuxkYRkebGB1rnq RhGDwE7cRVFsc2H10tf/cgFFyK06+ACzKobIsXuqWmjPduu8wkmo168oGaP5kReeZyTy UYQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Kau7zMY1dJtPnAeFjFb1bpRpxzhyG/k07bIDDi1B9Sw=; b=WI5iva/Nh29Q6T+3N7PQJttyMNdOGIuXHbqgyStM0HyGrpqL4qes3OiwWA0dB8lAS+ BerILImbUIl9UXCKwRR3lksBPasX6GcubZe1u8J1VBeULR325wPdtVRGCy3DTxFfMTWE nAHnOtsrTY0usIxm6yviJdE8M5ey/W2YWJrPMR7u+luxSr6l4pHDI9aQQ4HzvoDR+KrD 4wlcGwI5JtvPYY/lWCAC7Y/QI54YqcZx2ce52rdbOWEWTs/bPq/RSi/R1Xr0VXXHF7d6 j9NQsRWcXxWnZ13EkGCPwPMPiwbABax3oncbkQzJ1XPZUVfE+P6Fbv/2DeQKXyHaajqD zCgg== X-Gm-Message-State: AOAM530tycgLkSr7JGOZyZHpVUn4ClYqA+y++MA877MbViaDADCHHsKR snuvH2PwaKbNkLxyPU5aId/GZ3NsMEg= X-Google-Smtp-Source: ABdhPJwy+14Q5gXEnZviYclyR6O6yWEYat7xQeoEtaSlw1qYCbD9Ewn8pytUK08Lmb2Gznh3U6KIOQ== X-Received: by 2002:a17:902:d68d:: with SMTP id v13mr40357626ply.10.1593991884792; Sun, 05 Jul 2020 16:31:24 -0700 (PDT) Received: from f3 (ae055068.dynamic.ppp.asahi-net.or.jp. [14.3.55.68]) by smtp.gmail.com with ESMTPSA id r191sm453948pfr.181.2020.07.05.16.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2020 16:31:24 -0700 (PDT) Date: Mon, 6 Jul 2020 08:31:19 +0900 From: Benjamin Poirier To: Jaroslav Kysela Subject: Re: [External] Re: [PATCH v2 2/2] ALSA: hda/realtek - Replace Lenovo Thinkpad X1 Carbon 7th quirk Message-ID: <20200705233119.GB2439@f3> References: <20200703080005.8942-1-benjamin.poirier@gmail.com> <20200703080005.8942-3-benjamin.poirier@gmail.com> <58a7791c-0db4-a585-c550-3d3e9576191c@perex.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: "alsa-devel@alsa-project.org" , Kailang Yang , Takashi Iwai , Hui Wang , Kai-Heng Feng , Vincent Bernat , Even Brenden , Mark Pearson X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2020-07-03 14:43 +0200, Jaroslav Kysela wrote: > Dne 03. 07. 20 v 12:59 Mark Pearson napsal(a): > > > > > -----Original Message----- > > > From: Alsa-devel On Behalf Of > > > Jaroslav Kysela > > > Sent: Friday, July 3, 2020 6:34 AM > > > > > > Dne 03. 07. 20 v 10:00 Benjamin Poirier napsal(a): > > > > As a result of commit d2cd795c4ece ("ALSA: hda - fixup for the bass > > > > speaker on Lenovo Carbon X1 7th gen"), the sound output level on my machine, an > > > > X1 Carbon 7th gen, was reduced to ~65% of its previous level when playing > > > > certain sounds. [1] > > > > > > > > > > > > Thank you for this work. Perhaps, Takashi will have some comments to > > > improve this quirk. > > Seconded - thank you! > > > > > > > > > > > It is possible that the X1 Carbon 8th gen would benefit from the same > > > > changes but I don't have a device to test that. Fixups are reordered so > > > > that the devices for 7th & 8th gen can share the same chain after the first > > > > fixup. The resulting chain is: > > > > > > 8th gen hardware should be similar, so the new fixup should be applied to this > > > hw, too. > > > > > We'll do some testing here and confirm the fixes on the X1C7 and X1C8 (and Yoga) > > > > Do let me know if there is any details Lenovo can provide that would help > > The functionality of this patch is same like the hda-verb command is > executed with the current kernel (run as root): > > hda-verb /dev/snd/hwC0D0 0x17 SET_CONNECT_SEL 1 > > You can control tweeters with 'Speaker' volume control. > And headphones and bass speakers with the 'Headphone' volume control. For other X1 users who might stumble upon this discussion; practical usage of the hda-verb trick requires a way to apply it automatically[1] and changes to the ucm profile[2]. [1] https://gist.github.com/hamidzr/dd81e429dc86f4327ded7a2030e7d7d9#gistcomment-3345062 [2] https://gist.github.com/hamidzr/dd81e429dc86f4327ded7a2030e7d7d9#gistcomment-3335517 I've added more information here: https://github.com/gobenji/thinkpad-x1-gen7-sound/tree/c5ebc9166e955934dab03d6c4fb5928cf28496b0#alternative-2---runtime-reconfiguration