From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7367836240696452178==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [PATCH] mt6625l: fix returnvar.cocci warnings Date: Mon, 06 Jul 2020 14:41:13 +0800 Message-ID: <20200706064113.GA31149@9cf1f7d5106f> In-Reply-To: <202007061455.Nn14Bg8E%lkp@intel.com> List-Id: --===============7367836240696452178== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kernel test robot drivers/misc/mediatek/btif/common/btif_dma_plat.c:393:5-10: Unneeded variab= le: "i_ret". Return "0" on line 468 drivers/misc/mediatek/btif/common/btif_dma_plat.c:587:14-19: Unneeded varia= ble: "i_ret". Return "- 1" on line 599 drivers/misc/mediatek/btif/common/btif_dma_plat.c:1375:14-19: Unneeded vari= able: "i_ret". Return "- 1" on line 1377 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: 5a3d075a983c ("mt6625l: include wifi-folder") Signed-off-by: kernel test robot --- tree: https://github.com/frank-w/BPI-R2-4.14 5.8-wifi head: 4b8951570a4f2ef564d134f5aa8779fd067af1c9 commit: 5a3d075a983c166a2a4294c272b47698e24c97c6 [5/11] mt6625l: include wi= fi-folder Please take the patch only if it's a positive warning. Thanks! btif_dma_plat.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) --- a/drivers/misc/mediatek/btif/common/btif_dma_plat.c +++ b/drivers/misc/mediatek/btif/common/btif_dma_plat.c @@ -390,7 +390,6 @@ int hal_btif_dma_clk_ctrl(P_MTK_DMA_INFO = int hal_btif_dma_hw_init(P_MTK_DMA_INFO_STR p_dma_info) { - int i_ret =3D 0; unsigned int dat =3D 0; unsigned long base =3D p_dma_info->base; unsigned long addr_h =3D 0; @@ -465,7 +464,7 @@ int hal_btif_dma_hw_init(P_MTK_DMA_INFO_ hal_btif_dma_ier_ctrl(p_dma_info, false); } = - return i_ret; + return 0; } = /*************************************************************************= **** @@ -584,7 +583,6 @@ int btif_rx_dma_ctrl(P_MTK_DMA_INFO_STR **************************************************************************= ***/ int hal_btif_vfifo_reset(P_MTK_DMA_INFO_STR p_dma_info) { - unsigned int i_ret =3D -1; P_DMA_VFIFO p_vfifo =3D p_dma_info->p_vfifo; P_MTK_BTIF_DMA_VFIFO p_mtk_dma_vfifo =3D container_of(p_vfifo, MTK_BTIF_DMA_VFIFO, @@ -596,7 +594,7 @@ int hal_btif_vfifo_reset(P_MTK_DMA_INFO_ p_mtk_dma_vfifo->wpt =3D 0; p_mtk_dma_vfifo->last_wpt_wrap =3D 0; BTIF_TRC_FUNC(); - return i_ret; + return -1; } = /*************************************************************************= **** @@ -1372,9 +1370,7 @@ int hal_dma_pm_ops(P_MTK_DMA_INFO_STR p_ int hal_dma_receive_data(P_MTK_DMA_INFO_STR p_dma_info, unsigned char *p_buf, const unsigned int max_len) { - unsigned int i_ret =3D -1; - - return i_ret; + return -1; } #endif =20 --===============7367836240696452178==--