From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Mon, 06 Jul 2020 07:12:53 +0000 Subject: Re: [PATCH 3/8] backlight: ili922x: Add missing kerneldoc descriptions for CHECK_FREQ_REG() args Message-Id: <20200706071253.GA2821869@dell> List-Id: References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-4-lee.jones@linaro.org> <20200625094051.u4hanl3rycczlwiy@holly.lan> In-Reply-To: <20200625094051.u4hanl3rycczlwiy@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Daniel Thompson Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , jingoohan1@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Software Engineering , linux-arm-kernel@lists.infradead.org On Thu, 25 Jun 2020, Daniel Thompson wrote: > On Wed, Jun 24, 2020 at 03:57:16PM +0100, Lee Jones wrote: > > Kerneldoc syntax is used, but not complete. Descriptions required. > > > > Prevents warnings like: > > > > drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 's' not described in 'CHECK_FREQ_REG' > > drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 'x' not described in 'CHECK_FREQ_REG' > > > > Cc: > > Cc: Bartlomiej Zolnierkiewicz > > Cc: Software Engineering > > Signed-off-by: Lee Jones > > --- > > drivers/video/backlight/ili922x.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c > > index 9c5aa3fbb2842..8cb4b9d3c3bba 100644 > > --- a/drivers/video/backlight/ili922x.c > > +++ b/drivers/video/backlight/ili922x.c > > @@ -107,6 +107,8 @@ > > * lower frequency when the registers are read/written. > > * The macro sets the frequency in the spi_transfer structure if > > * the frequency exceeds the maximum value. > > + * @s: pointer to controller side proxy for an SPI slave device > > What's wrong with "a pointer to an SPI device"? I've fixed this and applied the patch. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7528BC433DF for ; Mon, 6 Jul 2020 07:14:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40DA62070C for ; Mon, 6 Jul 2020 07:14:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cqDCTz9n"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="if9HBlA9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40DA62070C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k1wk2XLyqq4tL8fU5R8z1JKKrnaKVUjQDkwUnmZW51Q=; b=cqDCTz9n+M+62wB5cCDfXxTAR J0JesQHqrLm9NMn+gkZ5zHaCv4uwy8MzaJCw50iHVRJcAyIVx7tQYGdkOtet1442QUFfBRhOvEVwn RgDos1nvs5xWu3CbWcOpyOGJPub+FZ5yWIkcitzbFMkOagZPrT1rw/Tsu3Yw9yY1Uar7MfuNcWgij /Vkit6NnGdG1HNOruERypC+d6B0O/3MMYv7Gx6AQiU4QAj6r3S3rDs5EJ8dYkVHY7q2XyGKCpsbFH oFa9pin7uZLy8b+X0+lDn+dDBWQlDJIkkfCS7FEOdsh+Q2qcmPRU2dpQt3hAq/jR4vk4NLIyUzP/s seU8d+HZg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsLJG-0005YS-TE; Mon, 06 Jul 2020 07:13:02 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsLJD-0005Xr-NM for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 07:13:00 +0000 Received: by mail-wr1-x442.google.com with SMTP id j4so37185643wrp.10 for ; Mon, 06 Jul 2020 00:12:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=FoSjIG3VRw8M9fOU/dfLMuLezeTkp5UAh0BxNMHAjSU=; b=if9HBlA9VQz/DooWA8KmSxJ1gwN0Z/+q/abPRsudszDLAPA5Sax63WJuxR/o0W7YRW pY3+BOTmv9n1glV/nSTkzluey/r9TND8/Um1sbKlF7gaOJyxNkt3qpbkSHwhnPt2fgvA PrhvSA8l2QPunnrnOJDw73eRQ+4iGvqYbzEDWJziNcpx3AH93pN474NFD5hNkR34Avfq L4BIuECug2LTD7En9WA6bmt9HuCDKrCzb2FwCrCAH3wEUGUiENhaLPGCX2fuvKxC0OD9 s5DsLrUA93+Of8tTSSH4UjB1bRwCruHx5RgHBrpx2bvmK3cJDhrrequ1c+JCNU6MxS2u EJuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FoSjIG3VRw8M9fOU/dfLMuLezeTkp5UAh0BxNMHAjSU=; b=FtZ8q3RXgWGkU5SFt+pQNwiupwFjM06UgOalR7aSj+HzrTGsUDl6Vv2vrhDq72JQSV EhtiZ/Lg8FWcws201QvhhKo20SP4EfXlBgBVNdj7YYjVEUwXdDW/xsQfPzKMYXEezYg/ WfcL6ePOrIpeYi1hGWVECYNXvPIOwCwzcz3JrrlPIwftqZP866iJTTNbljA4eB6gptxG 02MaXnYjvgACIiEch+bfBWIOwL5mqNEq/+gpkvYHOCmL9KeR1NVPYiPwAYeMAiwwWSej g/MhnOkgo1YQjHJTD7VCkFdJalLdjx0z+EeL5u8Dy/abutWwUEiOif0fPMZFH79tUiQG 9Phw== X-Gm-Message-State: AOAM531EbzP3UBiJ38ZCD4hs8Sr0pc3VU3Z7r4YesuQQevNoiEtwJZwn EECe5p7Cwyfe8OgIfghwy9i8fw== X-Google-Smtp-Source: ABdhPJwLhBlFAKN26FXGsrKJ2/3ld4/TUj5IudfdjzM/ZuZS/dr7xAKMChCzQ/pTpQ6ikPiMmParcw== X-Received: by 2002:a5d:610a:: with SMTP id v10mr46895795wrt.108.1594019576099; Mon, 06 Jul 2020 00:12:56 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id 65sm22090235wmd.20.2020.07.06.00.12.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 00:12:55 -0700 (PDT) Date: Mon, 6 Jul 2020 08:12:53 +0100 From: Lee Jones To: Daniel Thompson Subject: Re: [PATCH 3/8] backlight: ili922x: Add missing kerneldoc descriptions for CHECK_FREQ_REG() args Message-ID: <20200706071253.GA2821869@dell> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-4-lee.jones@linaro.org> <20200625094051.u4hanl3rycczlwiy@holly.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200625094051.u4hanl3rycczlwiy@holly.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_031300_052696_2242FE86 X-CRM114-Status: GOOD ( 15.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , jingoohan1@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Software Engineering , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyNSBKdW4gMjAyMCwgRGFuaWVsIFRob21wc29uIHdyb3RlOgoKPiBPbiBXZWQsIEp1 biAyNCwgMjAyMCBhdCAwMzo1NzoxNlBNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBLZXJu ZWxkb2Mgc3ludGF4IGlzIHVzZWQsIGJ1dCBub3QgY29tcGxldGUuICBEZXNjcmlwdGlvbnMgcmVx dWlyZWQuCj4gPiAKPiA+IFByZXZlbnRzIHdhcm5pbmdzIGxpa2U6Cj4gPiAKPiA+ICBkcml2ZXJz L3ZpZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmM6MTE2OiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0 ZXIgb3IgbWVtYmVyICdzJyBub3QgZGVzY3JpYmVkIGluICdDSEVDS19GUkVRX1JFRycKPiA+ICBk cml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmM6MTE2OiB3YXJuaW5nOiBGdW5jdGlvbiBw YXJhbWV0ZXIgb3IgbWVtYmVyICd4JyBub3QgZGVzY3JpYmVkIGluICdDSEVDS19GUkVRX1JFRycK PiA+IAo+ID4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPgo+ID4gQ2M6IEJhcnRsb21pZWog Wm9sbmllcmtpZXdpY3ogPGIuem9sbmllcmtpZUBzYW1zdW5nLmNvbT4KPiA+IENjOiBTb2Z0d2Fy ZSBFbmdpbmVlcmluZyA8c2JhYmljQGRlbnguZGU+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9u ZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+ID4gLS0tCj4gPiAgZHJpdmVycy92aWRlby9iYWNr bGlnaHQvaWxpOTIyeC5jIHwgMiArKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KykKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2lsaTkyMngu YyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2lsaTkyMnguYwo+ID4gaW5kZXggOWM1YWEzZmJi Mjg0Mi4uOGNiNGI5ZDNjM2JiYSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvdmlkZW8vYmFja2xp Z2h0L2lsaTkyMnguYwo+ID4gKysrIGIvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvaWxpOTIyeC5j Cj4gPiBAQCAtMTA3LDYgKzEwNyw4IEBACj4gPiAgICoJbG93ZXIgZnJlcXVlbmN5IHdoZW4gdGhl IHJlZ2lzdGVycyBhcmUgcmVhZC93cml0dGVuLgo+ID4gICAqCVRoZSBtYWNybyBzZXRzIHRoZSBm cmVxdWVuY3kgaW4gdGhlIHNwaV90cmFuc2ZlciBzdHJ1Y3R1cmUgaWYKPiA+ICAgKgl0aGUgZnJl cXVlbmN5IGV4Y2VlZHMgdGhlIG1heGltdW0gdmFsdWUuCj4gPiArICogQHM6IHBvaW50ZXIgdG8g Y29udHJvbGxlciBzaWRlIHByb3h5IGZvciBhbiBTUEkgc2xhdmUgZGV2aWNlCj4gCj4gV2hhdCdz IHdyb25nIHdpdGggImEgcG9pbnRlciB0byBhbiBTUEkgZGV2aWNlIj8KCkkndmUgZml4ZWQgdGhp cyBhbmQgYXBwbGllZCB0aGUgcGF0Y2guCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlv ciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVu IHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBU d2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D5CCC433DF for ; Mon, 6 Jul 2020 07:13:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 430172070C for ; Mon, 6 Jul 2020 07:13:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="if9HBlA9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 430172070C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7360B6E0B7; Mon, 6 Jul 2020 07:12:59 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 915026E0B7 for ; Mon, 6 Jul 2020 07:12:57 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id a6so39614278wrm.4 for ; Mon, 06 Jul 2020 00:12:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=FoSjIG3VRw8M9fOU/dfLMuLezeTkp5UAh0BxNMHAjSU=; b=if9HBlA9VQz/DooWA8KmSxJ1gwN0Z/+q/abPRsudszDLAPA5Sax63WJuxR/o0W7YRW pY3+BOTmv9n1glV/nSTkzluey/r9TND8/Um1sbKlF7gaOJyxNkt3qpbkSHwhnPt2fgvA PrhvSA8l2QPunnrnOJDw73eRQ+4iGvqYbzEDWJziNcpx3AH93pN474NFD5hNkR34Avfq L4BIuECug2LTD7En9WA6bmt9HuCDKrCzb2FwCrCAH3wEUGUiENhaLPGCX2fuvKxC0OD9 s5DsLrUA93+Of8tTSSH4UjB1bRwCruHx5RgHBrpx2bvmK3cJDhrrequ1c+JCNU6MxS2u EJuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FoSjIG3VRw8M9fOU/dfLMuLezeTkp5UAh0BxNMHAjSU=; b=fFZmmO7tF6kOwA8EfL9Uyd7IIE6ZFphhTiEhoSy+JOq4HGtjuNKvXlTA9Bm7xjT6wb YVvahqAMOmqhUCpfazl6zbYjVGNJmO0PuMr+42OUqHp7GYrCv6KTxYIUJf8p0tf9M8Mz RtPShv9sakL14r2Cig3rUoTx1yGxnbSBBMkozMtMtAKr2VOIu7FHH9sAQygLJ1e6tovj u/glNANizpTM508wTo9MwzKahMLV3v7EVx5/x2tmiL6aVcr5l/sQQe3mNQBiPNSTikJk /sA1AWJUIpF8nuNh6KyLQybFNsDuS2z+kZpFMcMlgszu6J95roB6XZ9D4vcw/3uI4FMP qK1Q== X-Gm-Message-State: AOAM531LfKxcqJIYuUTu22l3HXrxx8Zw7KljKFxFNoZ5HDKxNPmqbXVC gnxG/KwRQH6uiHnQSGuo1JP9qw== X-Google-Smtp-Source: ABdhPJwLhBlFAKN26FXGsrKJ2/3ld4/TUj5IudfdjzM/ZuZS/dr7xAKMChCzQ/pTpQ6ikPiMmParcw== X-Received: by 2002:a5d:610a:: with SMTP id v10mr46895795wrt.108.1594019576099; Mon, 06 Jul 2020 00:12:56 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id 65sm22090235wmd.20.2020.07.06.00.12.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 00:12:55 -0700 (PDT) Date: Mon, 6 Jul 2020 08:12:53 +0100 From: Lee Jones To: Daniel Thompson Subject: Re: [PATCH 3/8] backlight: ili922x: Add missing kerneldoc descriptions for CHECK_FREQ_REG() args Message-ID: <20200706071253.GA2821869@dell> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-4-lee.jones@linaro.org> <20200625094051.u4hanl3rycczlwiy@holly.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200625094051.u4hanl3rycczlwiy@holly.lan> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , jingoohan1@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Software Engineering , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCAyNSBKdW4gMjAyMCwgRGFuaWVsIFRob21wc29uIHdyb3RlOgoKPiBPbiBXZWQsIEp1 biAyNCwgMjAyMCBhdCAwMzo1NzoxNlBNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBLZXJu ZWxkb2Mgc3ludGF4IGlzIHVzZWQsIGJ1dCBub3QgY29tcGxldGUuICBEZXNjcmlwdGlvbnMgcmVx dWlyZWQuCj4gPiAKPiA+IFByZXZlbnRzIHdhcm5pbmdzIGxpa2U6Cj4gPiAKPiA+ICBkcml2ZXJz L3ZpZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmM6MTE2OiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0 ZXIgb3IgbWVtYmVyICdzJyBub3QgZGVzY3JpYmVkIGluICdDSEVDS19GUkVRX1JFRycKPiA+ICBk cml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmM6MTE2OiB3YXJuaW5nOiBGdW5jdGlvbiBw YXJhbWV0ZXIgb3IgbWVtYmVyICd4JyBub3QgZGVzY3JpYmVkIGluICdDSEVDS19GUkVRX1JFRycK PiA+IAo+ID4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPgo+ID4gQ2M6IEJhcnRsb21pZWog Wm9sbmllcmtpZXdpY3ogPGIuem9sbmllcmtpZUBzYW1zdW5nLmNvbT4KPiA+IENjOiBTb2Z0d2Fy ZSBFbmdpbmVlcmluZyA8c2JhYmljQGRlbnguZGU+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9u ZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+ID4gLS0tCj4gPiAgZHJpdmVycy92aWRlby9iYWNr bGlnaHQvaWxpOTIyeC5jIHwgMiArKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KykKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2lsaTkyMngu YyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2lsaTkyMnguYwo+ID4gaW5kZXggOWM1YWEzZmJi Mjg0Mi4uOGNiNGI5ZDNjM2JiYSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvdmlkZW8vYmFja2xp Z2h0L2lsaTkyMnguYwo+ID4gKysrIGIvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvaWxpOTIyeC5j Cj4gPiBAQCAtMTA3LDYgKzEwNyw4IEBACj4gPiAgICoJbG93ZXIgZnJlcXVlbmN5IHdoZW4gdGhl IHJlZ2lzdGVycyBhcmUgcmVhZC93cml0dGVuLgo+ID4gICAqCVRoZSBtYWNybyBzZXRzIHRoZSBm cmVxdWVuY3kgaW4gdGhlIHNwaV90cmFuc2ZlciBzdHJ1Y3R1cmUgaWYKPiA+ICAgKgl0aGUgZnJl cXVlbmN5IGV4Y2VlZHMgdGhlIG1heGltdW0gdmFsdWUuCj4gPiArICogQHM6IHBvaW50ZXIgdG8g Y29udHJvbGxlciBzaWRlIHByb3h5IGZvciBhbiBTUEkgc2xhdmUgZGV2aWNlCj4gCj4gV2hhdCdz IHdyb25nIHdpdGggImEgcG9pbnRlciB0byBhbiBTUEkgZGV2aWNlIj8KCkkndmUgZml4ZWQgdGhp cyBhbmQgYXBwbGllZCB0aGUgcGF0Y2guCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlv ciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVu IHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBU d2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B30E2C433E1 for ; Mon, 6 Jul 2020 07:12:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A3102070C for ; Mon, 6 Jul 2020 07:12:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="if9HBlA9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728851AbgGFHM6 (ORCPT ); Mon, 6 Jul 2020 03:12:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728466AbgGFHM6 (ORCPT ); Mon, 6 Jul 2020 03:12:58 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96962C08C5E0 for ; Mon, 6 Jul 2020 00:12:57 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id f2so11635012wrp.7 for ; Mon, 06 Jul 2020 00:12:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=FoSjIG3VRw8M9fOU/dfLMuLezeTkp5UAh0BxNMHAjSU=; b=if9HBlA9VQz/DooWA8KmSxJ1gwN0Z/+q/abPRsudszDLAPA5Sax63WJuxR/o0W7YRW pY3+BOTmv9n1glV/nSTkzluey/r9TND8/Um1sbKlF7gaOJyxNkt3qpbkSHwhnPt2fgvA PrhvSA8l2QPunnrnOJDw73eRQ+4iGvqYbzEDWJziNcpx3AH93pN474NFD5hNkR34Avfq L4BIuECug2LTD7En9WA6bmt9HuCDKrCzb2FwCrCAH3wEUGUiENhaLPGCX2fuvKxC0OD9 s5DsLrUA93+Of8tTSSH4UjB1bRwCruHx5RgHBrpx2bvmK3cJDhrrequ1c+JCNU6MxS2u EJuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FoSjIG3VRw8M9fOU/dfLMuLezeTkp5UAh0BxNMHAjSU=; b=fygCgyfbhlRb21dLHTrydKVCQMXTNoJsNe40wy1yFu5hXn+Y4do6VDBFkhbL2vHGMI hzNnkU4Gxpp3fOd8n9NZVJWoDiVjcE1RdLzCWlPFTbg2Rxy9m1DhA0Y5LSvJameajPX1 Gd0w4V40ITeZipX66GhY1ANPG5a8mViAg1+nBEDYiXHMlE1MC2rwcLcrXCRtS+f43XS+ 9cqu/L9S28O0JMjnh/hZareGJL5l1b6InbG2M+q38953nFXfDWVE8/eLLN/5P5lK8R7k 7fkVcshP1feRAk/XsDGl8pZSLfIFu7Bj+XHjDsinYFOxPVipxlRs/xdx+b3y84xKeNpM LnCw== X-Gm-Message-State: AOAM531Okbs6FIFSvZ8WRSd+eP7qkhEIRV15FOKMTCQiBejj8qe6zuo9 lZZaZXUWn4KhBs0VzCQvquOhcQ== X-Google-Smtp-Source: ABdhPJwLhBlFAKN26FXGsrKJ2/3ld4/TUj5IudfdjzM/ZuZS/dr7xAKMChCzQ/pTpQ6ikPiMmParcw== X-Received: by 2002:a5d:610a:: with SMTP id v10mr46895795wrt.108.1594019576099; Mon, 06 Jul 2020 00:12:56 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id 65sm22090235wmd.20.2020.07.06.00.12.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 00:12:55 -0700 (PDT) Date: Mon, 6 Jul 2020 08:12:53 +0100 From: Lee Jones To: Daniel Thompson Cc: jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bartlomiej Zolnierkiewicz , Software Engineering Subject: Re: [PATCH 3/8] backlight: ili922x: Add missing kerneldoc descriptions for CHECK_FREQ_REG() args Message-ID: <20200706071253.GA2821869@dell> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-4-lee.jones@linaro.org> <20200625094051.u4hanl3rycczlwiy@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200625094051.u4hanl3rycczlwiy@holly.lan> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jun 2020, Daniel Thompson wrote: > On Wed, Jun 24, 2020 at 03:57:16PM +0100, Lee Jones wrote: > > Kerneldoc syntax is used, but not complete. Descriptions required. > > > > Prevents warnings like: > > > > drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 's' not described in 'CHECK_FREQ_REG' > > drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 'x' not described in 'CHECK_FREQ_REG' > > > > Cc: > > Cc: Bartlomiej Zolnierkiewicz > > Cc: Software Engineering > > Signed-off-by: Lee Jones > > --- > > drivers/video/backlight/ili922x.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c > > index 9c5aa3fbb2842..8cb4b9d3c3bba 100644 > > --- a/drivers/video/backlight/ili922x.c > > +++ b/drivers/video/backlight/ili922x.c > > @@ -107,6 +107,8 @@ > > * lower frequency when the registers are read/written. > > * The macro sets the frequency in the spi_transfer structure if > > * the frequency exceeds the maximum value. > > + * @s: pointer to controller side proxy for an SPI slave device > > What's wrong with "a pointer to an SPI device"? I've fixed this and applied the patch. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog