From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Mon, 06 Jul 2020 07:13:22 +0000 Subject: Re: [PATCH 5/8] backlight: ili922x: Add missing kerneldoc description for ili922x_reg_dump()'s arg Message-Id: <20200706071322.GB2821869@dell> List-Id: References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-6-lee.jones@linaro.org> <20200625094318.h6t22gkgi5d7wbv4@holly.lan> In-Reply-To: <20200625094318.h6t22gkgi5d7wbv4@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Daniel Thompson Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , jingoohan1@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Software Engineering , linux-arm-kernel@lists.infradead.org On Thu, 25 Jun 2020, Daniel Thompson wrote: > On Wed, Jun 24, 2020 at 03:57:18PM +0100, Lee Jones wrote: > > Kerneldoc syntax is used, but not complete. Descriptions required. > > > > Prevents warnings like: > > > > drivers/video/backlight/ili922x.c:298: warning: Function parameter or member 'spi' not described in 'ili922x_reg_dump' > > > > Cc: > > Cc: Bartlomiej Zolnierkiewicz > > Cc: Software Engineering > > Signed-off-by: Lee Jones > > --- > > drivers/video/backlight/ili922x.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c > > index cd41433b87aeb..26193f38234e7 100644 > > --- a/drivers/video/backlight/ili922x.c > > +++ b/drivers/video/backlight/ili922x.c > > @@ -295,6 +295,8 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value) > > #ifdef DEBUG > > /** > > * ili922x_reg_dump - dump all registers > > + * > > + * @spi: pointer to the controller side proxy for an SPI slave device > > Similar to previous... and I also noticed that there are several other > existing @spi descriptions in this file and it would be good to make > them consistent. I've fixed this and applied the patch. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49EE5C433E0 for ; Mon, 6 Jul 2020 07:14:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15C042070C for ; Mon, 6 Jul 2020 07:14:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aBQIyfKh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AAikv23Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15C042070C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OL6HIzdNyfwbNFljRQQrYMPSaowTJB7rrs+HyT7MtEg=; b=aBQIyfKhcQKCnxLKBE40uCHRZ ACEGDrquGXsUDgsx9IQMbdNecMEyUt4b0wdJHFzN9VFazzUJ1mvZAZOzmdLjKVHSs6L47NkYZDPto trZqcXZwzxrj43W/YYlT4YeJazYDBtSMplOYOaW2E5OHB3Iwgq8QDSyMqps4wZbC4w9W0+QZXFsqU o3ApcQC3UzPXdRrOgD2dN3Rn5f2TMkBJHiiI4cYEVQHeXN1OdcydSVciGBbiLouRfLZaK2rb5mmLm kEfe8ivhhEwV3QJCTxhGeWOMSHLH15f/9xBhUjmHkc7CBmX5zuGfYBmapK7SV7ovnE3fWZWrjEhDG qIqsP+V6A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsLJh-0005aZ-Bn; Mon, 06 Jul 2020 07:13:29 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsLJe-0005Zz-Qa for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 07:13:27 +0000 Received: by mail-wr1-x443.google.com with SMTP id s10so39560135wrw.12 for ; Mon, 06 Jul 2020 00:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=RMGnvxquvbu4QyMyyHqPaCsBLX3LZtSdXGrqjMwfS7E=; b=AAikv23ZIqKM8pfJvjReSBC3OGv4L4hsLmToMzvt7T4/lJmoiQ+k4CdAGRb0cV7S2W 5X8g98k0ELBNX7r3ltxzvzV7Us/w7LOjcAmp/SXbx8utOSJSEuFc7U0259FgO+PDubaM k24kALm57sxDO8COLitP2s3SUPG757vsPnwL9+lCTMT28+RB1XbGNbSOw46k+xJDdaBB VuFjAMTV3L6YEJCKAgb19Z1QDdVmigQUrNGym9PJiCpMP5CfkmNXCk2xvhJegjTQQ3vX WUTgp7t8gDULlaBYcJc9JBvRnTkdKprktwjq6xQVSs0pSfm931CCLVe8qirXmhGyS+aQ R6Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RMGnvxquvbu4QyMyyHqPaCsBLX3LZtSdXGrqjMwfS7E=; b=KCWXdb1wszmzq8Kq7nT4PXLrMCxsmjT6fiIGIIX/LPFuJa04TYmFTP9vYRdqopyorv qw/tuO8u3bIoGS1oPbcchOClEOyn4tm7/Aa3niKey1qbQntkLctfODlMpbXfCCXgkk3v d+9mE20CeKDlMrjGUEpr/OFcC8/0wjcd0dFK4ucas4Loc7B+HYoWXfI6MuG+hMh4zStp fXuXZ0fJYIU355qe7P9LoRbSCbqsWnJu1u6HawP9lSuzFrQU06WRpp1jUfCn47yfX4/4 nRm4l5FiAa6Ovx8p3OkeKLVu5dVBCQoG5WQerepXXjdib1quXL0+8fSlc60/6oMhNZtz 4flQ== X-Gm-Message-State: AOAM530V/y5AUiYwbXZFKapOjWNGLp1mNq0H+DpLpyv6bj+oktjH6X4J JrfOTEIgLkj0D0JjJ/U0wbxrLg== X-Google-Smtp-Source: ABdhPJzbRa4dAsAzugKpjzOIhWptwA1zAERFnuxhOgrcEveqI1bRWNiT7yGNRTf9jNNznRD5lbePTw== X-Received: by 2002:adf:ed02:: with SMTP id a2mr46518594wro.110.1594019605697; Mon, 06 Jul 2020 00:13:25 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id d13sm22969218wrq.89.2020.07.06.00.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 00:13:24 -0700 (PDT) Date: Mon, 6 Jul 2020 08:13:22 +0100 From: Lee Jones To: Daniel Thompson Subject: Re: [PATCH 5/8] backlight: ili922x: Add missing kerneldoc description for ili922x_reg_dump()'s arg Message-ID: <20200706071322.GB2821869@dell> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-6-lee.jones@linaro.org> <20200625094318.h6t22gkgi5d7wbv4@holly.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200625094318.h6t22gkgi5d7wbv4@holly.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_031326_878305_F9D69D44 X-CRM114-Status: GOOD ( 17.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , jingoohan1@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Software Engineering , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyNSBKdW4gMjAyMCwgRGFuaWVsIFRob21wc29uIHdyb3RlOgoKPiBPbiBXZWQsIEp1 biAyNCwgMjAyMCBhdCAwMzo1NzoxOFBNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBLZXJu ZWxkb2Mgc3ludGF4IGlzIHVzZWQsIGJ1dCBub3QgY29tcGxldGUuICBEZXNjcmlwdGlvbnMgcmVx dWlyZWQuCj4gPiAKPiA+IFByZXZlbnRzIHdhcm5pbmdzIGxpa2U6Cj4gPiAKPiA+ICBkcml2ZXJz L3ZpZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmM6Mjk4OiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0 ZXIgb3IgbWVtYmVyICdzcGknIG5vdCBkZXNjcmliZWQgaW4gJ2lsaTkyMnhfcmVnX2R1bXAnCj4g PiAKPiA+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4KPiA+IENjOiBCYXJ0bG9taWVqIFpv bG5pZXJraWV3aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+Cj4gPiBDYzogU29mdHdhcmUg RW5naW5lZXJpbmcgPHNiYWJpY0BkZW54LmRlPgo+ID4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVz IDxsZWUuam9uZXNAbGluYXJvLm9yZz4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvdmlkZW8vYmFja2xp Z2h0L2lsaTkyMnguYyB8IDIgKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCsp Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmMg Yi9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmMKPiA+IGluZGV4IGNkNDE0MzNiODdh ZWIuLjI2MTkzZjM4MjM0ZTcgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdo dC9pbGk5MjJ4LmMKPiA+ICsrKyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2lsaTkyMnguYwo+ ID4gQEAgLTI5NSw2ICsyOTUsOCBAQCBzdGF0aWMgaW50IGlsaTkyMnhfd3JpdGUoc3RydWN0IHNw aV9kZXZpY2UgKnNwaSwgdTggcmVnLCB1MTYgdmFsdWUpCj4gPiAgI2lmZGVmIERFQlVHCj4gPiAg LyoqCj4gPiAgICogaWxpOTIyeF9yZWdfZHVtcCAtIGR1bXAgYWxsIHJlZ2lzdGVycwo+ID4gKyAq Cj4gPiArICogQHNwaTogcG9pbnRlciB0byB0aGUgY29udHJvbGxlciBzaWRlIHByb3h5IGZvciBh biBTUEkgc2xhdmUgZGV2aWNlCj4gCj4gU2ltaWxhciB0byBwcmV2aW91cy4uLiBhbmQgSSBhbHNv IG5vdGljZWQgdGhhdCB0aGVyZSBhcmUgc2V2ZXJhbCBvdGhlcgo+IGV4aXN0aW5nIEBzcGkgZGVz Y3JpcHRpb25zIGluIHRoaXMgZmlsZSBhbmQgaXQgd291bGQgYmUgZ29vZCB0byBtYWtlCj4gdGhl bSBjb25zaXN0ZW50LgoKSSd2ZSBmaXhlZCB0aGlzIGFuZCBhcHBsaWVkIHRoZSBwYXRjaC4KCi0t IApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVy IFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29D cwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DD2C433E1 for ; Mon, 6 Jul 2020 07:13:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A0872070C for ; Mon, 6 Jul 2020 07:13:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AAikv23Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A0872070C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3441B89BFE; Mon, 6 Jul 2020 07:13:28 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0654D89BFE for ; Mon, 6 Jul 2020 07:13:27 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id z13so39614220wrw.5 for ; Mon, 06 Jul 2020 00:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=RMGnvxquvbu4QyMyyHqPaCsBLX3LZtSdXGrqjMwfS7E=; b=AAikv23ZIqKM8pfJvjReSBC3OGv4L4hsLmToMzvt7T4/lJmoiQ+k4CdAGRb0cV7S2W 5X8g98k0ELBNX7r3ltxzvzV7Us/w7LOjcAmp/SXbx8utOSJSEuFc7U0259FgO+PDubaM k24kALm57sxDO8COLitP2s3SUPG757vsPnwL9+lCTMT28+RB1XbGNbSOw46k+xJDdaBB VuFjAMTV3L6YEJCKAgb19Z1QDdVmigQUrNGym9PJiCpMP5CfkmNXCk2xvhJegjTQQ3vX WUTgp7t8gDULlaBYcJc9JBvRnTkdKprktwjq6xQVSs0pSfm931CCLVe8qirXmhGyS+aQ R6Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RMGnvxquvbu4QyMyyHqPaCsBLX3LZtSdXGrqjMwfS7E=; b=MEa7U+tyNgwZ68QYTfz+YxewIgsdA5sU6e8/+nlcfjOS259ioXyHbWPMMxtW6pSm+6 G2ty+p50CHAlIjUwtHZ0pFjb1h9ZW5CEMfUB5dlwWDEUpRr1VO97mcyHCUSndCtlDwAk +5G7npP4/7xYKFzaZgIQOeE1gIxYC4OwzTmg58QYyUzTO2y2wnniOObZDRwQxYDfg6On VkeJz31ST7F0TJP4vplOSdmijmYmK16Cmryxu9fu0oH0qaQhC6FBJuoDn4RwtDIL4A+W PaNukAIMYKTqxtRGObkK2gstACfJAmqdTJTYzsFh5Rbt94j5Ef6ZZ8jZpLFwApmnfrVt uV0w== X-Gm-Message-State: AOAM532mBUBfjarNqWlE9j5HWN6VdOxJ4DEw/V/gXSaD2/lhD8jIehTP mqEmlwTWHmO0KkDqkZf57OtT1A== X-Google-Smtp-Source: ABdhPJzbRa4dAsAzugKpjzOIhWptwA1zAERFnuxhOgrcEveqI1bRWNiT7yGNRTf9jNNznRD5lbePTw== X-Received: by 2002:adf:ed02:: with SMTP id a2mr46518594wro.110.1594019605697; Mon, 06 Jul 2020 00:13:25 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id d13sm22969218wrq.89.2020.07.06.00.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 00:13:24 -0700 (PDT) Date: Mon, 6 Jul 2020 08:13:22 +0100 From: Lee Jones To: Daniel Thompson Subject: Re: [PATCH 5/8] backlight: ili922x: Add missing kerneldoc description for ili922x_reg_dump()'s arg Message-ID: <20200706071322.GB2821869@dell> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-6-lee.jones@linaro.org> <20200625094318.h6t22gkgi5d7wbv4@holly.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200625094318.h6t22gkgi5d7wbv4@holly.lan> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , jingoohan1@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Software Engineering , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCAyNSBKdW4gMjAyMCwgRGFuaWVsIFRob21wc29uIHdyb3RlOgoKPiBPbiBXZWQsIEp1 biAyNCwgMjAyMCBhdCAwMzo1NzoxOFBNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBLZXJu ZWxkb2Mgc3ludGF4IGlzIHVzZWQsIGJ1dCBub3QgY29tcGxldGUuICBEZXNjcmlwdGlvbnMgcmVx dWlyZWQuCj4gPiAKPiA+IFByZXZlbnRzIHdhcm5pbmdzIGxpa2U6Cj4gPiAKPiA+ICBkcml2ZXJz L3ZpZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmM6Mjk4OiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0 ZXIgb3IgbWVtYmVyICdzcGknIG5vdCBkZXNjcmliZWQgaW4gJ2lsaTkyMnhfcmVnX2R1bXAnCj4g PiAKPiA+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4KPiA+IENjOiBCYXJ0bG9taWVqIFpv bG5pZXJraWV3aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+Cj4gPiBDYzogU29mdHdhcmUg RW5naW5lZXJpbmcgPHNiYWJpY0BkZW54LmRlPgo+ID4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVz IDxsZWUuam9uZXNAbGluYXJvLm9yZz4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvdmlkZW8vYmFja2xp Z2h0L2lsaTkyMnguYyB8IDIgKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCsp Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmMg Yi9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9pbGk5MjJ4LmMKPiA+IGluZGV4IGNkNDE0MzNiODdh ZWIuLjI2MTkzZjM4MjM0ZTcgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdo dC9pbGk5MjJ4LmMKPiA+ICsrKyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2lsaTkyMnguYwo+ ID4gQEAgLTI5NSw2ICsyOTUsOCBAQCBzdGF0aWMgaW50IGlsaTkyMnhfd3JpdGUoc3RydWN0IHNw aV9kZXZpY2UgKnNwaSwgdTggcmVnLCB1MTYgdmFsdWUpCj4gPiAgI2lmZGVmIERFQlVHCj4gPiAg LyoqCj4gPiAgICogaWxpOTIyeF9yZWdfZHVtcCAtIGR1bXAgYWxsIHJlZ2lzdGVycwo+ID4gKyAq Cj4gPiArICogQHNwaTogcG9pbnRlciB0byB0aGUgY29udHJvbGxlciBzaWRlIHByb3h5IGZvciBh biBTUEkgc2xhdmUgZGV2aWNlCj4gCj4gU2ltaWxhciB0byBwcmV2aW91cy4uLiBhbmQgSSBhbHNv IG5vdGljZWQgdGhhdCB0aGVyZSBhcmUgc2V2ZXJhbCBvdGhlcgo+IGV4aXN0aW5nIEBzcGkgZGVz Y3JpcHRpb25zIGluIHRoaXMgZmlsZSBhbmQgaXQgd291bGQgYmUgZ29vZCB0byBtYWtlCj4gdGhl bSBjb25zaXN0ZW50LgoKSSd2ZSBmaXhlZCB0aGlzIGFuZCBhcHBsaWVkIHRoZSBwYXRjaC4KCi0t IApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVy IFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29D cwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86054C433DF for ; Mon, 6 Jul 2020 07:13:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6133C2074F for ; Mon, 6 Jul 2020 07:13:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AAikv23Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728871AbgGFHN2 (ORCPT ); Mon, 6 Jul 2020 03:13:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728466AbgGFHN1 (ORCPT ); Mon, 6 Jul 2020 03:13:27 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E839BC061794 for ; Mon, 6 Jul 2020 00:13:26 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id q5so39588160wru.6 for ; Mon, 06 Jul 2020 00:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=RMGnvxquvbu4QyMyyHqPaCsBLX3LZtSdXGrqjMwfS7E=; b=AAikv23ZIqKM8pfJvjReSBC3OGv4L4hsLmToMzvt7T4/lJmoiQ+k4CdAGRb0cV7S2W 5X8g98k0ELBNX7r3ltxzvzV7Us/w7LOjcAmp/SXbx8utOSJSEuFc7U0259FgO+PDubaM k24kALm57sxDO8COLitP2s3SUPG757vsPnwL9+lCTMT28+RB1XbGNbSOw46k+xJDdaBB VuFjAMTV3L6YEJCKAgb19Z1QDdVmigQUrNGym9PJiCpMP5CfkmNXCk2xvhJegjTQQ3vX WUTgp7t8gDULlaBYcJc9JBvRnTkdKprktwjq6xQVSs0pSfm931CCLVe8qirXmhGyS+aQ R6Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RMGnvxquvbu4QyMyyHqPaCsBLX3LZtSdXGrqjMwfS7E=; b=XU5UIQb3YdQklNBqy3hK1ebSfqbkVnA/sl1gCkUrXUvv2eyd/O2aZEbhRLTs0v2JrK s3B0NnulXbnNZ31+EUIa7oxw0Fo+/oa64cg5UDzUGY1V5O6Xq3dwUDXYue47WwHL3Sum YfRM6HkPQ9+rYfpC1Ykj+4hy+469l2HHVEU/dGJ5WHqa4gJXi5wtRtJqvb3M9JdcFBfe WsonyHCplZ1H71KPbaCZOMKnTG//UlZlthynDzVPVNon/i2A3DMv8NBNDu4YRPL4vHXr 6hzSwiOvy7PgP9WXkP/+J++zpUXE+tjeDaHVeq5gavQwLQrmwZrBhcMz4zb3eKKTt1SA wwBQ== X-Gm-Message-State: AOAM532jBS6apCQdgaatytGYAHTfVXMW80MxUPyZOhDUHVF6QvF87Dmm Wxh6ukQQts8qdUXYLWEMlHkGHQ== X-Google-Smtp-Source: ABdhPJzbRa4dAsAzugKpjzOIhWptwA1zAERFnuxhOgrcEveqI1bRWNiT7yGNRTf9jNNznRD5lbePTw== X-Received: by 2002:adf:ed02:: with SMTP id a2mr46518594wro.110.1594019605697; Mon, 06 Jul 2020 00:13:25 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id d13sm22969218wrq.89.2020.07.06.00.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 00:13:24 -0700 (PDT) Date: Mon, 6 Jul 2020 08:13:22 +0100 From: Lee Jones To: Daniel Thompson Cc: jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bartlomiej Zolnierkiewicz , Software Engineering Subject: Re: [PATCH 5/8] backlight: ili922x: Add missing kerneldoc description for ili922x_reg_dump()'s arg Message-ID: <20200706071322.GB2821869@dell> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-6-lee.jones@linaro.org> <20200625094318.h6t22gkgi5d7wbv4@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200625094318.h6t22gkgi5d7wbv4@holly.lan> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jun 2020, Daniel Thompson wrote: > On Wed, Jun 24, 2020 at 03:57:18PM +0100, Lee Jones wrote: > > Kerneldoc syntax is used, but not complete. Descriptions required. > > > > Prevents warnings like: > > > > drivers/video/backlight/ili922x.c:298: warning: Function parameter or member 'spi' not described in 'ili922x_reg_dump' > > > > Cc: > > Cc: Bartlomiej Zolnierkiewicz > > Cc: Software Engineering > > Signed-off-by: Lee Jones > > --- > > drivers/video/backlight/ili922x.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c > > index cd41433b87aeb..26193f38234e7 100644 > > --- a/drivers/video/backlight/ili922x.c > > +++ b/drivers/video/backlight/ili922x.c > > @@ -295,6 +295,8 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value) > > #ifdef DEBUG > > /** > > * ili922x_reg_dump - dump all registers > > + * > > + * @spi: pointer to the controller side proxy for an SPI slave device > > Similar to previous... and I also noticed that there are several other > existing @spi descriptions in this file and it would be good to make > them consistent. I've fixed this and applied the patch. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog