From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 206FBC433E0 for ; Mon, 6 Jul 2020 07:32:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0D93206CD for ; Mon, 6 Jul 2020 07:32:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fgfVbC55"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ql6Xa+1g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0D93206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xe467EXmdIA2NimOoW03mGvTpmgLu0mYo/cZO2b6L6E=; b=fgfVbC55StRA/jTCuflBCtI7A YsZzcCsERkpVGzLfwU9m/mEaEnwFTiuFQ5TgUZIxBwwYiUPFnsgRlHjBFrD8se2tPTMW092rw5vRk STH+aY/y7EtQTYQCYGK6koeZS//Nez53CKHIf2lyL88N4guDtUFi/tK+cJvQeH+7m+oVtWxC/zb5t iX2b146pFQzO8eMtuuaUJwfTk3NQK9KrDRBSFuzwf5hFa3AUVtaSHBZb8hubiIh79LJXpRsZyuQ/U l9jVKoGEscEImZcE4QEeCshnzINApan7F1fLkvs8jhlUYoP+mOiU1EPqnwrkUbvbnv0y3yN07gwZE myHcmL0xw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsLaw-0000ru-ML; Mon, 06 Jul 2020 07:31:18 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsLat-0000rX-Ax for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 07:31:16 +0000 Received: by mail-wm1-x343.google.com with SMTP id q15so38132821wmj.2 for ; Mon, 06 Jul 2020 00:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Ij0JRwK8ga/rncVIV9YKY5BwGhFS/NPZFYIdNVKTzqc=; b=ql6Xa+1gVBCsxErRijzq8GkAk+NPNDVoSojqePD/z4CAU26jaa/7uB5xGq/72Cjxdf 3d24hdR93nqxIx0LJ7NrYnAFtEUlSM90YsNpILMJ11Qe1CkaQtzv/3rQvZmBLK+SEKqO FA/4Vwg0DOIpRQipFZrVoTuAI4RpxpnELJ2+OWEmwEHDSf/jUIcbWAo77Kz/Dk93DZK2 +nhzkHcv2jonehE8ZN8EwinoOoRqZsBcrWXBnUryeCk4bqHWZOviXdU/2XAxXwdE060w jOeqJSbimEDQmTpIpruMkKOSp3fSbAO0AaGrWfwlrSUWWeX8q2XZDnW5hFFu/xSAc4vs fKmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Ij0JRwK8ga/rncVIV9YKY5BwGhFS/NPZFYIdNVKTzqc=; b=IbS6eQKf5vIz9UkdPc3FgY4WvimnRF1nIOmh+06U/VkZovhyeLCvHearS9QV6IdZ2B Du97JdYtgBrCpszfMsZelhw5e+zit5NRiT/C2dfAQlZyPeNRRsyiP81Q03KW9/JEABge vBWbg47ysN6OHaxZqJ1b4toHB5jcO5c6m7Z2SAPkvfD/i+3bmZyh1FQZF18d2rucLPX3 9Dw444EAC57tLkWPDdzb1AV74TAJHmTSi6OYt4lbPNywGbfVHagdg2akkkE+isiCWdjr bqyItp/wjQbxVwDTyVHsu+8BgQoVEE7vEt6gAAEqm5xoIXxG8IGkCRwG0oMRVNrCyMUN Z4vQ== X-Gm-Message-State: AOAM531kgbxHrgsWN9VLqg0aXtTKNGcKyUmhZKukqBdV9ml+Bq5MqDLs 5+e5MAN0fIx/jbSixCQ0ciD7Qg== X-Google-Smtp-Source: ABdhPJwFe74liwklMNgNlDDfUptR2TDgiF8T0WWjCvFSkv/sy8CiCpkIoPKmbqGh9O9/kku8SGb+Dw== X-Received: by 2002:a1c:bb44:: with SMTP id l65mr50526517wmf.51.1594020673878; Mon, 06 Jul 2020 00:31:13 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id c15sm12304424wme.23.2020.07.06.00.31.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 00:31:12 -0700 (PDT) Date: Mon, 6 Jul 2020 08:31:11 +0100 From: Lee Jones To: Chen-Yu Tsai Subject: Re: [PATCH 5/5] mfd: axp20x-i2c: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Message-ID: <20200706073111.GD2821869@dell> References: <20200629123215.1014747-1-lee.jones@linaro.org> <20200629123215.1014747-6-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_033115_673168_926BF994 X-CRM114-Status: GOOD ( 21.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Carlo Caione , linux-kernel , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyOSBKdW4gMjAyMCwgQ2hlbi1ZdSBUc2FpIHdyb3RlOgoKPiBBZGRpbmcgSGFucyB0 byB0aGUgbGlzdCBhcyBoZSdzIHRoZSBvbmUgdGhhdCBkZWFscyB3aXRoIGFsbCB0aGUgeDg2Cj4g cGxhdGZvcm1zIHRoYXQgdXNlIHRoaXMgc2VyaWVzIG9mIGNoaXBzLgo+IAo+IE9uIE1vbiwgSnVu IDI5LCAyMDIwIGF0IDg6MzIgUE0gTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4gd3Jv dGU6Cj4gPgo+ID4gU2luY2UgQUNQSV9QVFIoKSBpcyB1c2VkIHRvIE5VTExpZnkgdGhlIHZhbHVl IHdoZW4gIUNPTkZJR19BQ1BJLAo+ID4gc3RydWN0IGF4cDIweF9pMmNfYWNwaV9tYXRjaCBiZWNv bWVzIGRlZmluZWQgYnkgdW51c2VkLgo+ID4KPiA+IFRoaXMgc3F1YXNoZXMgdGhlIGN1cnJlbnQg Vz0xIGtlcm5lbCBidWlsZHMgd2FybmluZzoKPiA+Cj4gPiAgZHJpdmVycy9tZmQvYXhwMjB4LWky Yy5jOjgyOjM2OiB3YXJuaW5nOiDigJhheHAyMHhfaTJjX2FjcGlfbWF0Y2jigJkgZGVmaW5lZCBi dXQgbm90IHVzZWQgWy1XdW51c2VkLWNvbnN0LXZhcmlhYmxlPV0KPiA+Cj4gPiBDYzogQ2hlbi1Z dSBUc2FpIDx3ZW5zQGNzaWUub3JnPgo+ID4gQ2M6IENhcmxvIENhaW9uZSA8Y2FybG9AY2Fpb25l Lm9yZz4KPiA+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+ Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL21mZC9heHAyMHgtaTJjLmMgfCAyICsrCj4gPiAgMSBmaWxl IGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21m ZC9heHAyMHgtaTJjLmMgYi9kcml2ZXJzL21mZC9heHAyMHgtaTJjLmMKPiA+IGluZGV4IDE0Zjlk Zjc0Zjg1NWMuLjNkZDY1MDEyNWMyMzkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL21mZC9heHAy MHgtaTJjLmMKPiA+ICsrKyBiL2RyaXZlcnMvbWZkL2F4cDIweC1pMmMuYwo+ID4gQEAgLTc5LDYg Kzc5LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBpMmNfZGV2aWNlX2lkIGF4cDIweF9pMmNfaWRb XSA9IHsKPiA+ICB9Owo+ID4gIE1PRFVMRV9ERVZJQ0VfVEFCTEUoaTJjLCBheHAyMHhfaTJjX2lk KTsKPiA+Cj4gPiArI2lmIElTX0VOQUJMRUQoQ09ORklHX0FDUEkpCj4gPiAgc3RhdGljIGNvbnN0 IHN0cnVjdCBhY3BpX2RldmljZV9pZCBheHAyMHhfaTJjX2FjcGlfbWF0Y2hbXSA9IHsKPiAKPiBJ J2QgcmF0aGVyIHVzZSAiX19tYXliZV91bnVzZWQiIGlmIHBvc3NpYmxlIHRvIGF0IGxlYXN0IGdl dCBhIGNvbXBpbGUKPiBjaGVjaywgYW5kIGFsc28gYmVjYXVzZSAiQUNQSV9QVFIgTlVMTGlmaWVz IHRoZSB2YWx1ZSIgbWlnaHQgbm90IGJlCj4gd2VsbCBrbm93biB0byBwZW9wbGUgbm90IHdvcmtp bmcgb24gQUNQSS1iYXNlZCBwbGF0Zm9ybXMuCgpGWUksIEkndmUgZ29uZSBiYWNrIHRvIHRoaXMg cGF0Y2gsIGFzIGl0IHNlZW1zIHRvIGJlIHRoZSBjb21tb24KY2Vuc3VzIGFjcm9zcyB0aGUgcmVz dCBvZiB0aGUga2VybmVsLCBkdWUgdG8gdGhlIGV4dHJhIHNwYWNlIHNhdmluZy4KClRoZSBjb2Rl IHdpbGwgZ2V0IGNvbXBpbGUgY2hlY2tzIHdoZW4gY29tcGlsZWQgd2l0aCBkaWZmZXJlbnQKYXJj aGl0ZWN0dXJlcywgYW5kIEknbSBub3Qgc3VyZSBJIHVuZGVyc3RhbmQgdGhlIGxhc3QgcG9pbnQg eW91IG1hZGUuCgo+IEVpdGhlciB3YXksCj4gCj4gQWNrZWQtYnk6IENoZW4tWXUgVHNhaSA8d2Vu c0Bjc2llLm9yZz4KCkkndmUgYXBwbGllZCB0aGlzIHRvIHRoZSBwYXRjaC4gIFRoYW5rcy4KCj4g PiAgICAgICAgIHsKPiA+ICAgICAgICAgICAgICAgICAuaWQgPSAiSU5UMzNGNCIsCj4gPiBAQCAt ODcsNiArODgsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZGV2aWNlX2lkIGF4cDIweF9p MmNfYWNwaV9tYXRjaFtdID0gewo+ID4gICAgICAgICB7IH0sCj4gPiAgfTsKPiA+ICBNT0RVTEVf REVWSUNFX1RBQkxFKGFjcGksIGF4cDIweF9pMmNfYWNwaV9tYXRjaCk7Cj4gPiArI2VuZGlmCj4g Pgo+ID4gIHN0YXRpYyBzdHJ1Y3QgaTJjX2RyaXZlciBheHAyMHhfaTJjX2RyaXZlciA9IHsKPiA+ ICAgICAgICAgLmRyaXZlciA9IHsKPiA+CgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlv ciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVu IHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBU d2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7DCAC433DF for ; Mon, 6 Jul 2020 07:31:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80B71206CD for ; Mon, 6 Jul 2020 07:31:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ql6Xa+1g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728915AbgGFHbQ (ORCPT ); Mon, 6 Jul 2020 03:31:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728079AbgGFHbP (ORCPT ); Mon, 6 Jul 2020 03:31:15 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46D1DC061794 for ; Mon, 6 Jul 2020 00:31:15 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id j18so38130096wmi.3 for ; Mon, 06 Jul 2020 00:31:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Ij0JRwK8ga/rncVIV9YKY5BwGhFS/NPZFYIdNVKTzqc=; b=ql6Xa+1gVBCsxErRijzq8GkAk+NPNDVoSojqePD/z4CAU26jaa/7uB5xGq/72Cjxdf 3d24hdR93nqxIx0LJ7NrYnAFtEUlSM90YsNpILMJ11Qe1CkaQtzv/3rQvZmBLK+SEKqO FA/4Vwg0DOIpRQipFZrVoTuAI4RpxpnELJ2+OWEmwEHDSf/jUIcbWAo77Kz/Dk93DZK2 +nhzkHcv2jonehE8ZN8EwinoOoRqZsBcrWXBnUryeCk4bqHWZOviXdU/2XAxXwdE060w jOeqJSbimEDQmTpIpruMkKOSp3fSbAO0AaGrWfwlrSUWWeX8q2XZDnW5hFFu/xSAc4vs fKmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Ij0JRwK8ga/rncVIV9YKY5BwGhFS/NPZFYIdNVKTzqc=; b=qj2e50uO7MmuPsN4EBHvOcO+/gJkCQ2DnUesCo+l2lf4HrQGM5N27AyySoESdIvxhr 3zvYn3KD/xvY5MFDZjNLkYqWAZryRYNZRi8msCB3z8chAviQoFo/sXKlG0yFODhh+3mr lgBQbK5KnuXrh0UUC62kWmkDuIgx2xKlW390VI75u2krsZjUHbCUaBjJ9TRyVUFtqiEm 1BYPUNFsQx+h/7AHt595E26ZjaAII+82Y+AUko9fZLK3blNBoYhR338qIcg1aS56Zn2P GEdAb4KC5eLyXZbI9zTSErrUU+GPmoXmeP1CBU0VLLi8n3XSmNXuWQHM1yhAQydrXjpP scOA== X-Gm-Message-State: AOAM532ZfYGUARU7bRNlYe/flNLTCOiGUSYXCKhHGK0Nibd4EQg50m4Q FibSpJyTDBsXDglZZEjtdTr+0bgsQuE= X-Google-Smtp-Source: ABdhPJwFe74liwklMNgNlDDfUptR2TDgiF8T0WWjCvFSkv/sy8CiCpkIoPKmbqGh9O9/kku8SGb+Dw== X-Received: by 2002:a1c:bb44:: with SMTP id l65mr50526517wmf.51.1594020673878; Mon, 06 Jul 2020 00:31:13 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id c15sm12304424wme.23.2020.07.06.00.31.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 00:31:12 -0700 (PDT) Date: Mon, 6 Jul 2020 08:31:11 +0100 From: Lee Jones To: Chen-Yu Tsai Cc: linux-arm-kernel , linux-kernel , Carlo Caione Subject: Re: [PATCH 5/5] mfd: axp20x-i2c: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Message-ID: <20200706073111.GD2821869@dell> References: <20200629123215.1014747-1-lee.jones@linaro.org> <20200629123215.1014747-6-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Jun 2020, Chen-Yu Tsai wrote: > Adding Hans to the list as he's the one that deals with all the x86 > platforms that use this series of chips. > > On Mon, Jun 29, 2020 at 8:32 PM Lee Jones wrote: > > > > Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, > > struct axp20x_i2c_acpi_match becomes defined by unused. > > > > This squashes the current W=1 kernel builds warning: > > > > drivers/mfd/axp20x-i2c.c:82:36: warning: ‘axp20x_i2c_acpi_match’ defined but not used [-Wunused-const-variable=] > > > > Cc: Chen-Yu Tsai > > Cc: Carlo Caione > > Signed-off-by: Lee Jones > > --- > > drivers/mfd/axp20x-i2c.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c > > index 14f9df74f855c..3dd650125c239 100644 > > --- a/drivers/mfd/axp20x-i2c.c > > +++ b/drivers/mfd/axp20x-i2c.c > > @@ -79,6 +79,7 @@ static const struct i2c_device_id axp20x_i2c_id[] = { > > }; > > MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id); > > > > +#if IS_ENABLED(CONFIG_ACPI) > > static const struct acpi_device_id axp20x_i2c_acpi_match[] = { > > I'd rather use "__maybe_unused" if possible to at least get a compile > check, and also because "ACPI_PTR NULLifies the value" might not be > well known to people not working on ACPI-based platforms. FYI, I've gone back to this patch, as it seems to be the common census across the rest of the kernel, due to the extra space saving. The code will get compile checks when compiled with different architectures, and I'm not sure I understand the last point you made. > Either way, > > Acked-by: Chen-Yu Tsai I've applied this to the patch. Thanks. > > { > > .id = "INT33F4", > > @@ -87,6 +88,7 @@ static const struct acpi_device_id axp20x_i2c_acpi_match[] = { > > { }, > > }; > > MODULE_DEVICE_TABLE(acpi, axp20x_i2c_acpi_match); > > +#endif > > > > static struct i2c_driver axp20x_i2c_driver = { > > .driver = { > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog