From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Pengfei Xu <pengfei.xu@intel.com>, Shuah Khan <shuah@kernel.org>,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>, Heng Su <heng.su@intel.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Kai Svahn <kai.svahn@intel.com>
Subject: Re: [PATCH v4] selftests: tpm: upgrade TPM2 tests from Python 2 to Python 3
Date: Tue, 7 Jul 2020 02:02:03 +0300 [thread overview]
Message-ID: <20200706230203.GB20770@linux.intel.com> (raw)
In-Reply-To: <444c90ba-3ad3-6ce1-d83e-bb918856079f@linuxfoundation.org>
On Mon, Jul 06, 2020 at 02:32:13PM -0600, Shuah Khan wrote:
> On 7/6/20 2:12 PM, Shuah Khan wrote:
> > On 7/2/20 7:20 PM, Pengfei Xu wrote:
> > > Thanks a lot Jarkko and Shuah!
> > >
> > > BR.
> > > Thanks!
> > >
> > > On 2020-07-02 at 15:32:49 -0600, Shuah Khan wrote:
> > > > On 7/2/20 1:44 PM, Jarkko Sakkinen wrote:
> > > > > On Fri, Jun 26, 2020 at 11:40:52AM +0800, Pengfei Xu wrote:
> > > > > > Python 2 is no longer supported by the Python upstream project, so
> > > > > > upgrade TPM2 tests to Python 3.
> > > > > >
> > > > > > Signed-off-by: Pengfei Xu <pengfei.xu@intel.com>
> > > > >
> > > > > I think that it's perfect now. Thank you.
> > > > >
> > > > > Also
> > > > >
> > > > > 1. I checked that scripts/checkpatch.pl did not report any errors.
> > > > > 2. sudo python3 -m unittest -v tpm2_tests.SmokeTest
> > > > > 3. sudo python3 -m unittest -v tpm2_tests.SpaceTest
> > > > >
> > > > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > > > > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > > > >
> > > > > Shuah, I could pick this up after your PR (with my earlier fixes) lands
> > > > > to mainline, and sort out possible merge conflicts if they uprise. Is
> > > > > this fine by you?
> > > > >
> > > >
> >
> > I started applying this and then passed.
> >
> > Doesn't this test fail if python3 isn't installed? Do you have to
> > support both versions?
> >
>
> Never mind. Tested it on with python2. All is well. Applied to
> linux-kselftest fixes for Linux 5.8-rc5
>
> thanks,
> -- Shuah
OK, great, thanks a lot!
/Jarkko
prev parent reply other threads:[~2020-07-06 23:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 3:40 [PATCH v4] selftests: tpm: upgrade TPM2 tests from Python 2 to Python 3 Pengfei Xu
2020-07-02 19:44 ` Jarkko Sakkinen
2020-07-02 21:32 ` Shuah Khan
2020-07-03 1:20 ` Pengfei Xu
2020-07-06 20:12 ` Shuah Khan
2020-07-06 20:32 ` Shuah Khan
2020-07-06 23:02 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706230203.GB20770@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=heng.su@intel.com \
--cc=kai.svahn@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pengfei.xu@intel.com \
--cc=qiuxu.zhuo@intel.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.