From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0927548558505706944==" MIME-Version: 1.0 From: Dan Carpenter To: kbuild-all@lists.01.org Subject: [staging:staging-testing 32/135] drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c:1722:6: warning: Variable 'ret' is reassigned a value before the old one has been used. Date: Tue, 07 Jul 2020 17:27:36 +0300 Message-ID: <20200707142736.GD2549@kadam> List-Id: --===============0927548558505706944== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git = staging-testing head: 14442181d20490945f341644bb8257e334b01447 commit: b18ee53ad297264a79cf4ea566663f20786b6455 [32/135] staging: bcm2835:= Break MMAL support out from camera compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot cppcheck warnings: (new ones prefixed by >>) >> drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c:1722:6: warning: V= ariable 'ret' is reassigned a value before the old one has been used. [redu= ndantAssignment] ret =3D destroy_component(instance, component); ^ drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c:1720:7: note: Vari= able 'ret' is reassigned a value before the old one has been used. ret =3D disable_component(instance, component); ^ drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c:1722:6: note: Vari= able 'ret' is reassigned a value before the old one has been used. ret =3D destroy_component(instance, component); ^ vim +/ret +1722 drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1711 int vchiq_mmal_component_finalise(struct vchiq_mma= l_instance *instance, 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1712 struct vchiq_mmal_component *component) 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1713 { 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1714 int ret; 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1715 = 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1716 if (mutex_lock_interruptible(&instance->vchiq_mut= ex)) 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1717 return -EINTR; 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1718 = 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1719 if (component->enabled) 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1720 ret =3D disable_component(instance, component); = ^^^^^^ Not used. 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1721 = 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 @1722 ret =3D destroy_component(instance, component); 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1723 = 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1724 mutex_unlock(&instance->vchiq_mutex); 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1725 = 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1726 return ret; 7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric A= nholt 2017-01-27 1727 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org _______________________________________________ devel mailing list devel(a)linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel --===============0927548558505706944==--