From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FAC3C433E0 for ; Tue, 7 Jul 2020 15:10:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E46742078D for ; Tue, 7 Jul 2020 15:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594134643; bh=PYh1fCQG7WWfJwewoYwDkRwfFV62qVto3c/0VQwHKQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PoXE0ul2kgQNkHG/WvutNb4xrYVSHxOKrY10ms2aIzvlgD/2X63H6XC7qFCoUCeAF hhtBOfTZg4UMBLkATeBnaKJxESz7GsBkOmdWyl6ABNN7FE686x5bnAsggnyEX5mA9b xYeoNNM62K877yQA7gO1SdN89ugnN4lDRX0f9XwA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728418AbgGGPKi (ORCPT ); Tue, 7 Jul 2020 11:10:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:51342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727079AbgGGPKf (ORCPT ); Tue, 7 Jul 2020 11:10:35 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B782920663; Tue, 7 Jul 2020 15:10:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594134635; bh=PYh1fCQG7WWfJwewoYwDkRwfFV62qVto3c/0VQwHKQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Su6f7jq7fZDMtzdkxDp8n8XD7N974asHei64Y2TXk3nDZJ8xiPyAHk9923MV92d2U udhK+qPcNtVy6qaFbnF3v+KNwHWrWMzGf+7aL/qv7IvFtggwVcqKd/mdgnFK4m8OfW vyzLzSh6I3CLugGzyzbKt5bxpDq//wiLzkDXwDbs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hou Tao , Stefano Garzarella , Ming Lei , Jens Axboe , Sasha Levin Subject: [PATCH 4.4 12/19] virtio-blk: free vblk-vqs in error path of virtblk_probe() Date: Tue, 7 Jul 2020 17:10:15 +0200 Message-Id: <20200707145748.120342745@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200707145747.493710555@linuxfoundation.org> References: <20200707145747.493710555@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hou Tao [ Upstream commit e7eea44eefbdd5f0345a0a8b80a3ca1c21030d06 ] Else there will be memory leak if alloc_disk() fails. Fixes: 6a27b656fc02 ("block: virtio-blk: support multi virt queues per virtio-blk device") Signed-off-by: Hou Tao Reviewed-by: Stefano Garzarella Reviewed-by: Ming Lei Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/virtio_blk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 1e5cd39d0cc2f..bdc3efacd0d25 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -757,6 +757,7 @@ static int virtblk_probe(struct virtio_device *vdev) put_disk(vblk->disk); out_free_vq: vdev->config->del_vqs(vdev); + kfree(vblk->vqs); out_free_vblk: kfree(vblk); out_free_index: -- 2.25.1