From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BEB8C433E1 for ; Wed, 8 Jul 2020 01:36:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E458B20774 for ; Wed, 8 Jul 2020 01:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594172169; bh=qcbZMOsf+PZnops4wxmQpE3tL1Fo9+d/2GUsJmsYjRc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=IrlerjY46et5XnB3rJaG6LEpt6vbFMlHdyMEYGTPcFukynMiIWRGMcglYU/UKjaTC F+5RuACy2OhrOrKU4sb8o4OvOF7mXzZyqCuEWQKe+/kK75zvKu1WulWENDGECUkIRy mRCPVdTB8nIj+6LrzGmnHEKdEiqoCNKppfnTREx0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728486AbgGHBgE (ORCPT ); Tue, 7 Jul 2020 21:36:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:48932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728191AbgGHBgD (ORCPT ); Tue, 7 Jul 2020 21:36:03 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B10C206DF; Wed, 8 Jul 2020 01:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594172163; bh=qcbZMOsf+PZnops4wxmQpE3tL1Fo9+d/2GUsJmsYjRc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pIPsXsDLGfJZLRa1uNPa8ep30GgD6VKtvrZTTnemio7/ps8+6BWHWzAWJQ3kgCdbJ SLzHPVMXTtzp7DK5m8QY5tcgIMCxcEwoJBid15CKOrWRwHBUsiwjH+7AtJ5wLO9ZZC c4Hzd9QK+N+6zgugVMC3ygDzISmy6Lm2tQYB99aE= Date: Tue, 7 Jul 2020 18:36:01 -0700 From: Eric Biggers To: Daniel Rosenberg Cc: Theodore Ts'o , linux-ext4@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, Alexander Viro , Andreas Dilger , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Gabriel Krisman Bertazi , kernel-team@android.com Subject: Re: [PATCH v10 1/4] unicode: Add utf8_casefold_hash Message-ID: <20200708013601.GF839@sol.localdomain> References: <20200707113123.3429337-1-drosen@google.com> <20200707113123.3429337-2-drosen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200707113123.3429337-2-drosen@google.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Jul 07, 2020 at 04:31:20AM -0700, Daniel Rosenberg wrote: > This adds a case insensitive hash function to allow taking the hash > without needing to allocate a casefolded copy of the string. > > The existing d_hash implementations for casefolding allocates memory > within rcu-walk, by avoiding it we can be more efficient and avoid > worrying about a failed allocation. > > Signed-off-by: Daniel Rosenberg You can add: Reviewed-by: Eric Biggers If you have a chance please fix the grammar in the commit message though: "The existing d_hash implementations for casefolding allocate memory within rcu-walk. By avoiding this we can be more efficient and avoid worrying about a failed allocation." - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB5EC433DF for ; Wed, 8 Jul 2020 01:36:13 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D195206DF for ; Wed, 8 Jul 2020 01:36:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="MythMP8B"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="Q6bYxTAU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pIPsXsDL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D195206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jsz0N-0001mH-Ln; Wed, 08 Jul 2020 01:36:11 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsz0M-0001mA-3n for linux-f2fs-devel@lists.sourceforge.net; Wed, 08 Jul 2020 01:36:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lzr4muBW+6GXVcwhu8syVP9/mqLAIrY9hj2JrkO1l04=; b=MythMP8BRJ1zh3J5vqEwpzmib7 mKE4PIM/GJMdZEUiyr3ufNbMogLN+kxSHr8vJ45yqMuWkq0QtNZ+fhadSCBcX4Lc+43Kal5ailZX1 0+c0yNyWqzLMus5E6bSZtRwHAHSHa+mDpldzkO5DjI/3AbRjUOakpN9eO9ZZmywRL/tI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lzr4muBW+6GXVcwhu8syVP9/mqLAIrY9hj2JrkO1l04=; b=Q6bYxTAUfOv92naOqUeGLtYVbi jxhIUkMdETWBqx6aATnTNZiZ9gpuL0kbGQFHu+5eDtqSdURkSTseX5n3Q0M+yqQiTsDJMlrErstfx ZEZf5VUPZbwaWFqSJZFen7p3fOQ/Ls6u4wNPbY4iFyqKpyKNw9suxscDr8yNEHv/KgbU=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jsz0K-00Ak4n-Vr for linux-f2fs-devel@lists.sourceforge.net; Wed, 08 Jul 2020 01:36:10 +0000 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B10C206DF; Wed, 8 Jul 2020 01:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594172163; bh=qcbZMOsf+PZnops4wxmQpE3tL1Fo9+d/2GUsJmsYjRc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pIPsXsDLGfJZLRa1uNPa8ep30GgD6VKtvrZTTnemio7/ps8+6BWHWzAWJQ3kgCdbJ SLzHPVMXTtzp7DK5m8QY5tcgIMCxcEwoJBid15CKOrWRwHBUsiwjH+7AtJ5wLO9ZZC c4Hzd9QK+N+6zgugVMC3ygDzISmy6Lm2tQYB99aE= Date: Tue, 7 Jul 2020 18:36:01 -0700 From: Eric Biggers To: Daniel Rosenberg Message-ID: <20200708013601.GF839@sol.localdomain> References: <20200707113123.3429337-1-drosen@google.com> <20200707113123.3429337-2-drosen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200707113123.3429337-2-drosen@google.com> X-Headers-End: 1jsz0K-00Ak4n-Vr Subject: Re: [f2fs-dev] [PATCH v10 1/4] unicode: Add utf8_casefold_hash X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Theodore Ts'o , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, Andreas Dilger , Alexander Viro , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, Gabriel Krisman Bertazi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Jul 07, 2020 at 04:31:20AM -0700, Daniel Rosenberg wrote: > This adds a case insensitive hash function to allow taking the hash > without needing to allocate a casefolded copy of the string. > > The existing d_hash implementations for casefolding allocates memory > within rcu-walk, by avoiding it we can be more efficient and avoid > worrying about a failed allocation. > > Signed-off-by: Daniel Rosenberg You can add: Reviewed-by: Eric Biggers If you have a chance please fix the grammar in the commit message though: "The existing d_hash implementations for casefolding allocate memory within rcu-walk. By avoiding this we can be more efficient and avoid worrying about a failed allocation." - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel