From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: sandeen@sandeen.net, Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs_repair: complain about ag header crc errors
Date: Wed, 8 Jul 2020 07:36:23 +0100 [thread overview]
Message-ID: <20200708063623.GA9080@infradead.org> (raw)
In-Reply-To: <159370361687.3579756.17807287829667417464.stgit@magnolia>
On Thu, Jul 02, 2020 at 08:26:56AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Repair doesn't complain about crc errors in the AG headers, and it
> should. Otherwise, this gives the admin the wrong impression about the
> state of the filesystem after a nomodify check.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-07-08 6:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 15:26 [PATCH v2 0/3] xfs_repair: more fixes Darrick J. Wong
2020-07-02 15:26 ` [PATCH 1/3] xfs_repair: complain about ag header crc errors Darrick J. Wong
2020-07-06 22:53 ` Allison Collins
2020-07-08 6:36 ` Christoph Hellwig [this message]
2020-07-02 15:27 ` [PATCH 2/3] xfs_repair: simplify free space btree calculations in init_freespace_cursors Darrick J. Wong
2020-07-06 22:53 ` Allison Collins
2020-07-07 12:58 ` Brian Foster
2020-07-08 6:40 ` Christoph Hellwig
2020-07-02 15:27 ` [PATCH 3/3] xfs_repair: try to fill the AGFL before we fix the freelist Darrick J. Wong
2020-07-07 12:59 ` Brian Foster
2020-07-07 14:07 ` Darrick J. Wong
2020-07-07 14:13 ` Brian Foster
2020-07-08 15:34 ` [PATCH v2 " Darrick J. Wong
2020-07-09 13:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708063623.GA9080@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.