From: Lee Jones <lee.jones@linaro.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Carlo Caione <carlo@caione.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd/axp20x-i2c: Fix "CONFIG_ACPI" is not defined warning
Date: Wed, 8 Jul 2020 08:30:29 +0100 [thread overview]
Message-ID: <20200708073029.GO3500@dell> (raw)
In-Reply-To: <20200707110058.976371-1-axel.lin@ingics.com>
On Tue, 07 Jul 2020, Axel Lin wrote:
> Fix below build warning:
>
> drivers/mfd/axp20x-i2c.c:82:5: warning: "CONFIG_ACPI" is not defined, evaluates to 0 [-Wundef]
> 82 | #if CONFIG_ACPI
> | ^~~~~~~~~~~
>
> Fixes: 20f359cb236b ("mfd: axp20x-i2c: Do not define 'struct acpi_device_id' when !CONFIG_ACPI")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/axp20x-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This should already be fixed.
Thanks anyway Axel.
> diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
> index bd271fbe1ec1..3c930316d48b 100644
> --- a/drivers/mfd/axp20x-i2c.c
> +++ b/drivers/mfd/axp20x-i2c.c
> @@ -79,7 +79,7 @@ static const struct i2c_device_id axp20x_i2c_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
>
> -#if CONFIG_ACPI
> +#ifdef CONFIG_ACPI
> static const struct acpi_device_id axp20x_i2c_acpi_match[] = {
> {
> .id = "INT33F4",
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2020-07-08 7:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 11:00 [PATCH] mfd/axp20x-i2c: Fix "CONFIG_ACPI" is not defined warning Axel Lin
2020-07-08 7:30 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708073029.GO3500@dell \
--to=lee.jones@linaro.org \
--cc=axel.lin@ingics.com \
--cc=carlo@caione.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.