From: Stephen Hemminger <stephen@networkplumber.org>
To: Sarosh Arif <sarosh.arif@emumba.com>
Cc: rsanford@akamai.com, erik.g.carrillo@intel.com, dev@dpdk.org,
stable@dpdk.org, h.mikita89@gmail.com
Subject: Re: [dpdk-dev] [PATCH v2] lib/librte_timer:fix corruption with reset
Date: Wed, 8 Jul 2020 08:08:48 -0700 [thread overview]
Message-ID: <20200708080848.569e8dcd@hermes.lan> (raw)
In-Reply-To: <20200708050626.23512-1-sarosh.arif@emumba.com>
On Wed, 8 Jul 2020 10:06:26 +0500
Sarosh Arif <sarosh.arif@emumba.com> wrote:
> rte_timer_stop_sync(struct rte_timer *tim)
> {
> + struct rte_timer_data *timer_data;
> + TIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data, -EINVAL);
> + unsigned int lcore_id = rte_lcore_id();
This mixing code and declarations. since the macro has a return statement.
Maybe:
struct rte_timer_data *timer_data;
unsigned int lcore_id = rte_lcore_id();
TIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data, -EINVAL);
next prev parent reply other threads:[~2020-07-08 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 9:03 [dpdk-dev] [PATCH] lib/librte_timer:fix corruption with reset Sarosh Arif
2020-07-07 16:09 ` Stephen Hemminger
2020-07-08 5:06 ` [dpdk-dev] [PATCH v2] " Sarosh Arif
2020-07-08 15:07 ` Stephen Hemminger
2020-07-09 7:05 ` Sarosh Arif
2020-07-08 15:08 ` Stephen Hemminger [this message]
2020-07-09 7:02 ` Sarosh Arif
2020-07-10 6:59 ` [dpdk-dev] [PATCH v3] " Sarosh Arif
2020-07-10 15:19 ` Stephen Hemminger
2020-07-28 19:04 ` Carrillo, Erik G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708080848.569e8dcd@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=h.mikita89@gmail.com \
--cc=rsanford@akamai.com \
--cc=sarosh.arif@emumba.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.