All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: James Morris <jmorris@namei.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Daniel Colascione <dancol@google.com>
Subject: linux-next: build failure after merge of the security tree
Date: Wed, 8 Jul 2020 14:00:34 +1000	[thread overview]
Message-ID: <20200708140034.546298ff@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2134 bytes --]

Hi all,

After merging the security tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/anon_inodes.c: In function 'anon_inode_make_secure_inode':
fs/anon_inodes.c:70:10: error: implicit declaration of function 'security_inode_init_security_anon'; did you mean 'security_inode_init_security'? [-Werror=implicit-function-declaration]
   70 |  error = security_inode_init_security_anon(
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |          security_inode_init_security

Caused by commit

  2749d3f84a70 ("Add a new LSM-supporting anonymous inode interface")

# CONFIG_SECURITY is not set

Also, the explicit include of linux/security.h is missing ...

I have added the following patch for today.

From b2bae25c9b715e06f7e802ec7b51cfbfec046e6c Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 8 Jul 2020 13:43:01 +1000
Subject: [PATCH] fix up for "Add a new LSM-supporting anonymous inode interface"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/anon_inodes.c         | 1 +
 include/linux/security.h | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c
index f87f221167cf..25d92c64411e 100644
--- a/fs/anon_inodes.c
+++ b/fs/anon_inodes.c
@@ -21,6 +21,7 @@
 #include <linux/magic.h>
 #include <linux/anon_inodes.h>
 #include <linux/pseudo_fs.h>
+#include <linux/security.h>
 
 #include <linux/uaccess.h>
 
diff --git a/include/linux/security.h b/include/linux/security.h
index 95c133a8f8bb..7c6b3dcf4721 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -735,6 +735,13 @@ static inline int security_inode_init_security(struct inode *inode,
 	return 0;
 }
 
+static inline int security_inode_init_security_anon(struct inode *inode,
+						    const struct qstr *name,
+						    const struct inode *context_inode)
+{
+	return 0;
+}
+
 static inline int security_old_inode_init_security(struct inode *inode,
 						   struct inode *dir,
 						   const struct qstr *qstr,
-- 
2.27.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2020-07-08  4:00 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08  4:00 Stephen Rothwell [this message]
2020-07-13  2:04 ` linux-next: build failure after merge of the security tree Stephen Rothwell
2020-07-13  2:06   ` Stephen Rothwell
2020-07-29 23:35   ` Stephen Rothwell
2020-07-30  2:35     ` James Morris
2020-07-30  2:59       ` Stephen Rothwell
2020-07-30  5:03         ` Stephen Rothwell
2020-08-04  3:36         ` James Morris
  -- strict thread matches above, loose matches on Subject: below --
2026-06-02 16:16 Mark Brown
2026-06-02 16:31 ` Paul Moore
2026-06-02 16:52   ` Daniel Borkmann
2026-06-02 17:26     ` Paul Moore
2026-06-02 18:40   ` Paul Moore
2026-06-02 19:16     ` Mark Brown
2026-06-02 20:13       ` Paul Moore
2026-06-02 21:45       ` Paul Moore
2026-06-03 12:42         ` Mark Brown
2026-06-03 14:43           ` Paul Moore
2025-03-24  4:37 Stephen Rothwell
2025-02-10  1:18 Stephen Rothwell
2025-02-10  3:44 ` Paul Moore
2025-02-10  3:53   ` Stephen Rothwell
2025-02-10 14:51     ` Paul Moore
2019-08-12  4:58 Stephen Rothwell
2019-08-12 17:34 ` Kees Cook
2019-08-19  3:21   ` Stephen Rothwell
2019-08-19  3:38     ` Stephen Rothwell
2019-08-21 16:39     ` James Morris
2017-08-23 11:12 Stephen Rothwell
2017-08-17  2:51 Stephen Rothwell
2017-08-17  3:24 ` Kees Cook
2016-05-19  4:01 Stephen Rothwell
2016-05-19  4:01 ` Stephen Rothwell
     [not found] ` <20160519140120.23b345a1-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2016-05-19 10:11   ` David Howells
2016-05-19 10:11     ` David Howells
2016-05-19 23:14   ` Stephen Rothwell
2016-05-19 23:14     ` Stephen Rothwell
2016-05-19 23:14     ` Stephen Rothwell
2016-05-20  3:07     ` Steve French
2015-08-17  5:29 Stephen Rothwell
2015-08-17  6:04 ` Stephen Rothwell
2015-08-26 14:45   ` David Howells
2014-07-25  9:21 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200708140034.546298ff@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=dancol@google.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.