From: Mike Snitzer <snitzer@redhat.com>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>, dm-devel@redhat.com
Subject: Re: [PATCH 2/2] dm zoned: Remove set but unused variables
Date: Wed, 8 Jul 2020 10:12:24 -0400 [thread overview]
Message-ID: <20200708141223.GA7582@redhat.com> (raw)
In-Reply-To: <20200708002023.738147-3-damien.lemoal@wdc.com>
On Tue, Jul 07 2020 at 8:20pm -0400,
Damien Le Moal <damien.lemoal@wdc.com> wrote:
> In dmz_reclaim_work(), the variables nr_unmap_rnd and nr_rnd are set but
> unused. Remove them.
>
> Fixes: f97809aec589 ("dm zoned: per-device reclaim")
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> drivers/md/dm-zoned-reclaim.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/md/dm-zoned-reclaim.c b/drivers/md/dm-zoned-reclaim.c
> index 9c6e264465bc..9c0ecc9568a4 100644
> --- a/drivers/md/dm-zoned-reclaim.c
> +++ b/drivers/md/dm-zoned-reclaim.c
> @@ -503,7 +503,7 @@ static void dmz_reclaim_work(struct work_struct *work)
> {
> struct dmz_reclaim *zrc = container_of(work, struct dmz_reclaim, work.work);
> struct dmz_metadata *zmd = zrc->metadata;
> - unsigned int p_unmap, nr_unmap_rnd = 0, nr_rnd = 0;
> + unsigned int p_unmap;
> int ret;
>
> if (dmz_dev_is_dying(zmd))
> @@ -529,9 +529,6 @@ static void dmz_reclaim_work(struct work_struct *work)
> zrc->kc_throttle.throttle = min(75U, 100U - p_unmap / 2);
> }
>
> - nr_unmap_rnd = dmz_nr_unmap_rnd_zones(zmd, zrc->dev_idx);
> - nr_rnd = dmz_nr_rnd_zones(zmd, zrc->dev_idx);
> -
> DMDEBUG("(%s/%u): Reclaim (%u): %s, %u%% free zones (%u/%u cache %u/%u random)",
> dmz_metadata_label(zmd), zrc->dev_idx,
> zrc->kc_throttle.throttle,
> --
> 2.26.2
>
I picked up the same change, that was submitted earlier, for 5.8:
https://patchwork.kernel.org/patch/11641031/
next prev parent reply other threads:[~2020-07-08 14:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 0:20 [PATCH 0/2] dm zoned fixes for 5.8 Damien Le Moal
2020-07-08 0:20 ` [PATCH 1/2] dm zoned: Fix zone reclaim trigger Damien Le Moal
2020-07-08 7:06 ` Hannes Reinecke
2020-07-08 0:20 ` [PATCH 2/2] dm zoned: Remove set but unused variables Damien Le Moal
2020-07-08 7:06 ` Hannes Reinecke
2020-07-08 14:12 ` Mike Snitzer [this message]
2020-07-09 1:44 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708141223.GA7582@redhat.com \
--to=snitzer@redhat.com \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.