All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leonro@mellanox.com>
To: Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@mellanox.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next 2/2] RDMA/core: Update write interface to use automatic object lifetime
Date: Wed, 8 Jul 2020 21:49:19 +0300	[thread overview]
Message-ID: <20200708184919.GC1276673@unreal> (raw)
In-Reply-To: <20200708110554.1270613-3-leon@kernel.org>

On Wed, Jul 08, 2020 at 02:05:54PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
>
> The automatic object lifetime model allows us to change write() interface
> to have same logic as ioctl() path. Update the create/alloc functions to be
> in the following format, so code flow will be the same:
>  * Allocate objects
>  * Initialize them
>  * Call to the drivers, this is last step that is allowed to fail
>  * Finalize object
>  * Return response and allow to core code to handle abort/commit
>    respectively.
>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  drivers/infiniband/core/uverbs_cmd.c | 299 ++++++++-------------------
>  1 file changed, 90 insertions(+), 209 deletions(-)

Please drop this patch, I came to realization that create_cq() can be
simplfied much more, I'll send v1 after will get results from the
verification.

Thanks

      reply	other threads:[~2020-07-08 18:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 11:05 [PATCH rdma-next 0/2] Align write() and ioctl() paths Leon Romanovsky
2020-07-08 11:05 ` [PATCH rdma-next 1/2] RDMA/core: Align abort/commit object scheme for " Leon Romanovsky
2020-07-08 11:05 ` [PATCH rdma-next 2/2] RDMA/core: Update write interface to use automatic object lifetime Leon Romanovsky
2020-07-08 18:49   ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200708184919.GC1276673@unreal \
    --to=leonro@mellanox.com \
    --cc=dledford@redhat.com \
    --cc=jgg@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.