Re: [PATCH 2/2] clk: scmi: Fix min and max rate when registering clocks with discrete rates

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2756 bytes --]

Hi Sudeep,

I love your patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on rockchip/for-next shawnguo/for-next soc/for-next linus/master v5.8-rc4 next-20200707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sudeep-Holla/firmware-arm_scmi-Keep-the-discrete-clock-rates-sorted/20200708-190957
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/clk/clk-scmi.c: In function 'scmi_clk_ops_init':
>> drivers/clk/clk-scmi.c:126:39: error: expected ';' before 'max_rate'
     126 |   min_rate = sclk->info->list.rates[0]
         |                                       ^
         |                                       ;
     127 |   max_rate = sclk->info->list.rates[num_rates - 1];
         |   ~~~~~~~~                             

vim +126 drivers/clk/clk-scmi.c

   102	
   103	static int scmi_clk_ops_init(struct device *dev, struct scmi_clk *sclk)
   104	{
   105		int ret;
   106		unsigned long min_rate, max_rate;
   107	
   108		struct clk_init_data init = {
   109			.flags = CLK_GET_RATE_NOCACHE,
   110			.num_parents = 0,
   111			.ops = &scmi_clk_ops,
   112			.name = sclk->info->name,
   113		};
   114	
   115		sclk->hw.init = &init;
   116		ret = devm_clk_hw_register(dev, &sclk->hw);
   117		if (ret)
   118			return ret;
   119	
   120		if (sclk->info->rate_discrete) {
   121			int num_rates = sclk->info->list.num_rates;
   122	
   123			if (num_rates <= 0)
   124				return -EINVAL;
   125	
 > 126			min_rate = sclk->info->list.rates[0]
   127			max_rate = sclk->info->list.rates[num_rates - 1];
   128		} else {
   129			min_rate = sclk->info->range.min_rate;
   130			max_rate = sclk->info->range.max_rate;
   131		}
   132	
   133		clk_hw_set_rate_range(&sclk->hw, min_rate, max_rate);
   134		return ret;
   135	}
   136	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 66257 bytes --]