From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A226C433E0 for ; Fri, 10 Jul 2020 03:20:51 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 583EF20657; Fri, 10 Jul 2020 03:20:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="Lan30kOs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="gBVJ5bBp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RM+jp5A3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 583EF20657 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jtjak-0002tw-6K; Fri, 10 Jul 2020 03:20:50 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtjai-0002tp-Hg for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Jul 2020 03:20:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1F/M8sTQY28bE1T1W/Z3pMbWTVz2B3L2eqNajIbuqQc=; b=Lan30kOsP66yZ3Lq0NzxQSXu2y jmcY/MvF9v7CgiJvms6s9HyS8IQMRWDs0Fo9hGlxmzzcqjC8AqiEPDES8jBwFVgkmz6bM3TdYBkkm BVwI9YDTMJRB2vq1cg1rxEEl2BhAeiD2E2N4yPt9eCbVy3o7/aAoQubmQOgemVF5geJM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1F/M8sTQY28bE1T1W/Z3pMbWTVz2B3L2eqNajIbuqQc=; b=gBVJ5bBpB7NCuoKR61PTl48MQl JEN35PCU+FYVaTqHTOm7HJ3ZlRGGCP8D5tf/ARafg3I6y5gGzfU8Bnz93/qPyQUEUTf1dpi8wtJL4 x9K6fZLqJ4ldvi8UgKYqxf4xsEoXai/d6iCvdH3RQ8bmCpyN7uNSTtKwGriTTMAxMDsQ=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jtjag-00CoOv-CA for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Jul 2020 03:20:48 +0000 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2130B20657; Fri, 10 Jul 2020 03:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594351236; bh=XReK43l5KBhtSYgtoFBk5br0uXqKW/BoDECZFioWyXY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RM+jp5A3CPHLVfl7472aQS9ZE6OGOxY0fX3HrOCfrYdtoUpJl/KfOIpDOMvbLjR6B USXz7zhntA/C59YAHYW9QpkZSgzGtrt65jttrJmXVpL7Lda75BR+N6CGEoyNQIL07Y Ui63RRoDhUxgfDfYnp5mqhbKHzb8ZHlfnZMT/vxc= Date: Thu, 9 Jul 2020 20:20:35 -0700 From: Jaegeuk Kim To: Daeho Jeong Message-ID: <20200710032035.GB545837@google.com> References: <20200710021505.2405872-1-daeho43@gmail.com> <20200710030246.GA545837@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1jtjag-00CoOv-CA Subject: Re: [f2fs-dev] [PATCH] f2fs: change the way of handling range.len in F2FS_IOC_SEC_TRIM_FILE X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daeho Jeong , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMDcvMTAsIERhZWhvIEplb25nIHdyb3RlOgo+IDEuIFRoZSB2YWxpZCBkYXRhIHdpbGwgYmUg d2l0aGluIGlfc2l6ZS4KPiAyLiBBbGwgdGhlIHRyaW0gb3BlcmF0aW9ucyB3aWxsIGJlIGRvbmUg aW4gYSB1bml0IG9mIGJsb2NrLCBldmVuIGlmCj4gaV9zaXplIGlzIG5vdCBhbGlnbmVkIHdpdGgg QkxLU0laRSBsaWtlIHRoZSBiZWxvdy4KPiAKPiAgICAgICAgIGluZGV4ID0gRjJGU19CWVRFU19U T19CTEsocmFuZ2Uuc3RhcnQpOwo+ICAgICAgICAgcGdfZW5kID0gRElWX1JPVU5EX1VQKGVuZF9h ZGRyLCBGMkZTX0JMS1NJWkUpOyAgICAgPD0gQkxLU0laRSBhbGlnbmVkCj4gCj4gQXJlIHlvdSB3 b3JyaWVkIGFib3V0IHRoZSBjYXNlIHRoYXQgc3VkZGVuIHBvd2VyLW9mZiBvY2N1cnMgd2hpbGUg YQo+IGZpbGUgaXMgYmVpbmcgdHJ1bmNhdGVkPwo+IGV4KSAxR0IgZmlsZSBpcyBiZWluZyB0cnVu Y2F0ZWQgdG8gNEtCIC0+IHN1ZGRlbiBwb3dlci1vZmYgLT4KPiBpX3NpemUoNEtCKSwgaV9ibG9j a3MobWF5YmUgc29tZXdoZXJlIGJldHdlZW4gNEtCIGFuZCAxR0IpCgpZZXMuIEJhc2ljYWxseSwg SSBiZWxpZXZlIHdlIGNhbiBoYXZlIHNvbWUgZGF0YSBiZXlvbmQgaV9zaXplIGxpa2UgZnN2ZXJp dHkuCgo+IAo+IDIwMjDrhYQgN+yblCAxMOydvCAo6riIKSDsmKTtm4QgMTI6MDIsIEphZWdldWsg S2ltIDxqYWVnZXVrQGtlcm5lbC5vcmc+64uY7J20IOyekeyEsToKPiA+Cj4gPiBPbiAwNy8xMCwg RGFlaG8gSmVvbmcgd3JvdGU6Cj4gPiA+IEZyb206IERhZWhvIEplb25nIDxkYWVob2plb25nQGdv b2dsZS5jb20+Cj4gPiA+Cj4gPiA+IENoYW5nZWQgdGhlIHdheSBvZiBoYW5kbGluZyByYW5nZS5s ZW4gb2YgRjJGU19JT0NfU0VDX1RSSU1fRklMRS4KPiA+ID4gIDEuIEFkZGVkIC0xIHZhbHVlIHN1 cHBvcnQgZm9yIHJhbmdlLmxlbiB0byBzaWduaWZ5IHRoZSBlbmQgb2YgZmlsZS4KPiA+ID4gIDIu IElmIHRoZSBlbmQgb2YgdGhlIHJhbmdlIHBhc3NlcyBvdmVyIHRoZSBlbmQgb2YgZmlsZSwgaXQg bWVhbnMgdW50aWwKPiA+ID4gICAgIHRoZSBlbmQgb2YgZmlsZS4KPiA+ID4gIDMuIGlnbm9yZWQg dGhlIGNhc2Ugb2YgdGhhdCByYW5nZS5sZW4gaXMgemVybyB0byBwcmV2ZW50IHRoZSBmdW5jdGlv bgo+ID4gPiAgICAgZnJvbSBtYWtpbmcgZW5kX2FkZHIgemVybyBhbmQgdHJpZ2dlcmluZyBkaWZm ZXJlbnQgYmVoYXZpb3VyIG9mCj4gPiA+ICAgICB0aGUgZnVuY3Rpb24uCj4gPiA+Cj4gPiA+IFNp Z25lZC1vZmYtYnk6IERhZWhvIEplb25nIDxkYWVob2plb25nQGdvb2dsZS5jb20+Cj4gPiA+IC0t LQo+ID4gPiAgZnMvZjJmcy9maWxlLmMgfCAxNiArKysrKysrLS0tLS0tLS0tCj4gPiA+ICAxIGZp bGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+ID4gPgo+ID4gPiBk aWZmIC0tZ2l0IGEvZnMvZjJmcy9maWxlLmMgYi9mcy9mMmZzL2ZpbGUuYwo+ID4gPiBpbmRleCAz NjhjODBmOGUyYTEuLjFjNDYwMWY5OTMyNiAxMDA2NDQKPiA+ID4gLS0tIGEvZnMvZjJmcy9maWxl LmMKPiA+ID4gKysrIGIvZnMvZjJmcy9maWxlLmMKPiA+ID4gQEAgLTM4MTMsMjEgKzM4MTMsMTkg QEAgc3RhdGljIGludCBmMmZzX3NlY190cmltX2ZpbGUoc3RydWN0IGZpbGUgKmZpbHAsIHVuc2ln bmVkIGxvbmcgYXJnKQo+ID4gPiAgICAgICBmaWxlX3N0YXJ0X3dyaXRlKGZpbHApOwo+ID4gPiAg ICAgICBpbm9kZV9sb2NrKGlub2RlKTsKPiA+ID4KPiA+ID4gLSAgICAgaWYgKGYyZnNfaXNfYXRv bWljX2ZpbGUoaW5vZGUpIHx8IGYyZnNfY29tcHJlc3NlZF9maWxlKGlub2RlKSkgewo+ID4gPiAr ICAgICBpZiAoZjJmc19pc19hdG9taWNfZmlsZShpbm9kZSkgfHwgZjJmc19jb21wcmVzc2VkX2Zp bGUoaW5vZGUpIHx8Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICByYW5nZS5zdGFydCA+PSBp bm9kZS0+aV9zaXplKSB7Cj4gPiA+ICAgICAgICAgICAgICAgcmV0ID0gLUVJTlZBTDsKPiA+ID4g ICAgICAgICAgICAgICBnb3RvIGVycjsKPiA+ID4gICAgICAgfQo+ID4gPgo+ID4gPiAtICAgICBp ZiAocmFuZ2Uuc3RhcnQgPj0gaW5vZGUtPmlfc2l6ZSkgewo+ID4gPiAtICAgICAgICAgICAgIHJl dCA9IC1FSU5WQUw7Cj4gPiA+ICsgICAgIGlmIChyYW5nZS5sZW4gPT0gMCkKPiA+ID4gICAgICAg ICAgICAgICBnb3RvIGVycjsKPiA+ID4gLSAgICAgfQo+ID4gPgo+ID4gPiAtICAgICBpZiAoaW5v ZGUtPmlfc2l6ZSAtIHJhbmdlLnN0YXJ0IDwgcmFuZ2UubGVuKSB7Cj4gPiA+IC0gICAgICAgICAg ICAgcmV0ID0gLUUyQklHOwo+ID4gPiAtICAgICAgICAgICAgIGdvdG8gZXJyOwo+ID4gPiAtICAg ICB9Cj4gPiA+IC0gICAgIGVuZF9hZGRyID0gcmFuZ2Uuc3RhcnQgKyByYW5nZS5sZW47Cj4gPiA+ ICsgICAgIGlmIChyYW5nZS5sZW4gPT0gKHU2NCktMSB8fCBpbm9kZS0+aV9zaXplIC0gcmFuZ2Uu c3RhcnQgPCByYW5nZS5sZW4pCj4gPiA+ICsgICAgICAgICAgICAgZW5kX2FkZHIgPSBpbm9kZS0+ aV9zaXplOwo+ID4KPiA+IEhtbSwgd2hhdCBpZiB0aGVyZSBhcmUgYmxvY2tzIGJleW9uZCBpX3Np emU/IERvIHdlIG5lZWQgdG8gY2hlY2sgaV9ibG9ja3MgZm9yCj4gPiBlbmRpbmcgY3JpdGVyaWE/ Cj4gPgo+ID4gPiArICAgICBlbHNlCj4gPiA+ICsgICAgICAgICAgICAgZW5kX2FkZHIgPSByYW5n ZS5zdGFydCArIHJhbmdlLmxlbjsKPiA+ID4KPiA+ID4gICAgICAgdG9fZW5kID0gKGVuZF9hZGRy ID09IGlub2RlLT5pX3NpemUpOwo+ID4gPiAgICAgICBpZiAoIUlTX0FMSUdORUQocmFuZ2Uuc3Rh cnQsIEYyRlNfQkxLU0laRSkgfHwKPiA+ID4gLS0KPiA+ID4gMi4yNy4wLjM4My5nMDUwMzE5YzJh ZS1nb29nCj4gPiA+Cj4gPiA+Cj4gPiA+Cj4gPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCj4gPiA+IExpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0 Cj4gPiA+IExpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cj4gPiA+IGh0dHBz Oi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1m MmZzLWRldmVsIG1haWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdl Lm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51eC1m MmZzLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5E8CC433DF for ; Fri, 10 Jul 2020 03:20:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A75D320674 for ; Fri, 10 Jul 2020 03:20:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594351238; bh=XReK43l5KBhtSYgtoFBk5br0uXqKW/BoDECZFioWyXY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ci8H4iZcYIfiTy7lnfngtDZrsKzEfegr7Uyve/PQmXqF4ixNx3VFeIYXYElZsdjRH gNnIF2NyI5bse/g8C1Yw+lEnXe34KWnN9wbgPmUauRoORaa3FHCZg7xvmAAk/xEBg2 hm/8RvnyUIxMNUp7Zg7bJV+0+8YDP4Bvbnm6LtIY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726830AbgGJDUh (ORCPT ); Thu, 9 Jul 2020 23:20:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:51762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726495AbgGJDUh (ORCPT ); Thu, 9 Jul 2020 23:20:37 -0400 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2130B20657; Fri, 10 Jul 2020 03:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594351236; bh=XReK43l5KBhtSYgtoFBk5br0uXqKW/BoDECZFioWyXY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RM+jp5A3CPHLVfl7472aQS9ZE6OGOxY0fX3HrOCfrYdtoUpJl/KfOIpDOMvbLjR6B USXz7zhntA/C59YAHYW9QpkZSgzGtrt65jttrJmXVpL7Lda75BR+N6CGEoyNQIL07Y Ui63RRoDhUxgfDfYnp5mqhbKHzb8ZHlfnZMT/vxc= Date: Thu, 9 Jul 2020 20:20:35 -0700 From: Jaegeuk Kim To: Daeho Jeong Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Daeho Jeong Subject: Re: [f2fs-dev] [PATCH] f2fs: change the way of handling range.len in F2FS_IOC_SEC_TRIM_FILE Message-ID: <20200710032035.GB545837@google.com> References: <20200710021505.2405872-1-daeho43@gmail.com> <20200710030246.GA545837@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/10, Daeho Jeong wrote: > 1. The valid data will be within i_size. > 2. All the trim operations will be done in a unit of block, even if > i_size is not aligned with BLKSIZE like the below. > > index = F2FS_BYTES_TO_BLK(range.start); > pg_end = DIV_ROUND_UP(end_addr, F2FS_BLKSIZE); <= BLKSIZE aligned > > Are you worried about the case that sudden power-off occurs while a > file is being truncated? > ex) 1GB file is being truncated to 4KB -> sudden power-off -> > i_size(4KB), i_blocks(maybe somewhere between 4KB and 1GB) Yes. Basically, I believe we can have some data beyond i_size like fsverity. > > 2020년 7월 10일 (금) 오후 12:02, Jaegeuk Kim 님이 작성: > > > > On 07/10, Daeho Jeong wrote: > > > From: Daeho Jeong > > > > > > Changed the way of handling range.len of F2FS_IOC_SEC_TRIM_FILE. > > > 1. Added -1 value support for range.len to signify the end of file. > > > 2. If the end of the range passes over the end of file, it means until > > > the end of file. > > > 3. ignored the case of that range.len is zero to prevent the function > > > from making end_addr zero and triggering different behaviour of > > > the function. > > > > > > Signed-off-by: Daeho Jeong > > > --- > > > fs/f2fs/file.c | 16 +++++++--------- > > > 1 file changed, 7 insertions(+), 9 deletions(-) > > > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > > index 368c80f8e2a1..1c4601f99326 100644 > > > --- a/fs/f2fs/file.c > > > +++ b/fs/f2fs/file.c > > > @@ -3813,21 +3813,19 @@ static int f2fs_sec_trim_file(struct file *filp, unsigned long arg) > > > file_start_write(filp); > > > inode_lock(inode); > > > > > > - if (f2fs_is_atomic_file(inode) || f2fs_compressed_file(inode)) { > > > + if (f2fs_is_atomic_file(inode) || f2fs_compressed_file(inode) || > > > + range.start >= inode->i_size) { > > > ret = -EINVAL; > > > goto err; > > > } > > > > > > - if (range.start >= inode->i_size) { > > > - ret = -EINVAL; > > > + if (range.len == 0) > > > goto err; > > > - } > > > > > > - if (inode->i_size - range.start < range.len) { > > > - ret = -E2BIG; > > > - goto err; > > > - } > > > - end_addr = range.start + range.len; > > > + if (range.len == (u64)-1 || inode->i_size - range.start < range.len) > > > + end_addr = inode->i_size; > > > > Hmm, what if there are blocks beyond i_size? Do we need to check i_blocks for > > ending criteria? > > > > > + else > > > + end_addr = range.start + range.len; > > > > > > to_end = (end_addr == inode->i_size); > > > if (!IS_ALIGNED(range.start, F2FS_BLKSIZE) || > > > -- > > > 2.27.0.383.g050319c2ae-goog > > > > > > > > > > > > _______________________________________________ > > > Linux-f2fs-devel mailing list > > > Linux-f2fs-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel