From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kcmp: add separate Kconfig symbol for kcmp syscall
Date: Fri, 10 Jul 2020 12:37:21 +0300 [thread overview]
Message-ID: <20200710093721.GE1999@grain> (raw)
In-Reply-To: <14b4a1f0-3caf-75e4-600a-3de877a92950@rasmusvillemoes.dk>
On Fri, Jul 10, 2020 at 11:05:11AM +0200, Rasmus Villemoes wrote:
> >> I deliberately drop the ifdef in the eventpoll.h header rather than
> >> replace with KCMP_SYSCALL; it's harmless to declare a function that
> >> isn't defined anywhere.
> >
> > Could you please point why setting #fidef KCMP_SYSCALL in eventpoll.h
> > is not suitable?
>
> It's just from a general "avoid ifdef clutter if possible" POV. The
> conditional declaration of the function doesn't really serve any
> purpose.
OK, thanks for explanation.
next prev parent reply other threads:[~2020-07-10 9:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 7:56 [PATCH] kcmp: add separate Kconfig symbol for kcmp syscall Rasmus Villemoes
2020-07-10 8:30 ` Cyrill Gorcunov
2020-07-10 9:05 ` Rasmus Villemoes
2020-07-10 9:37 ` Cyrill Gorcunov [this message]
2020-07-10 15:51 ` Randy Dunlap
2020-07-10 15:57 ` Matthew Wilcox
2020-10-13 19:45 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710093721.GE1999@grain \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.