From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D36C433EA for ; Fri, 10 Jul 2020 12:09:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4794620748 for ; Fri, 10 Jul 2020 12:09:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WLup1zPT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4794620748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtrqS-0005Gn-K2 for qemu-devel@archiver.kernel.org; Fri, 10 Jul 2020 08:09:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtrog-0003f4-Hs for qemu-devel@nongnu.org; Fri, 10 Jul 2020 08:07:46 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:28429 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jtrod-0000km-SV for qemu-devel@nongnu.org; Fri, 10 Jul 2020 08:07:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594382862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xilYkgB0PZ/XOy/E5cw08wrW1nC4VeY/hDyOZ/Tx8Xk=; b=WLup1zPTj/7XeLTEYqj3qaxggutwojTOQSgplYM7Lns6gfS7WqwD8FAoCviN9dRcih8DNN vsLgyZzleyxVIVWzhm+1QNqz6d90/1uLZDMPyyRaQGkmkQTngCGMqzac+0ywLulpHYN9uO dndSbqGJzaoqbA4CNPT2+ZwAXDjUkwI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-279-X2p58j07NSmJyahQJ0_cGw-1; Fri, 10 Jul 2020 08:07:39 -0400 X-MC-Unique: X2p58j07NSmJyahQJ0_cGw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5CFA4107ACCA; Fri, 10 Jul 2020 12:07:38 +0000 (UTC) Received: from linux.fritz.box (ovpn-114-57.ams2.redhat.com [10.36.114.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E10912DE60; Fri, 10 Jul 2020 12:07:32 +0000 (UTC) Date: Fri, 10 Jul 2020 14:07:31 +0200 From: Kevin Wolf To: Peter Maydell Subject: Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes Message-ID: <20200710120731.GE6641@linux.fritz.box> References: <20200707132116.26207-1-f4bug@amsat.org> <20200707132116.26207-3-f4bug@amsat.org> <3f1bf3ba-d6c3-a148-9850-076b2caa64d0@amsat.org> <20200710095827.GD6641@linux.fritz.box> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/09 23:35:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qemu-block , Alistair Francis , Alistair Francis , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Wainer dos Santos Moschetta , "qemu-devel@nongnu.org Developers" , Niek Linnenbank , Cleber Rosa , Paolo Bonzini , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 10.07.2020 um 11:59 hat Peter Maydell geschrieben: > On Fri, 10 Jul 2020 at 10:58, Kevin Wolf wrote: > > > > Am 09.07.2020 um 16:15 hat Peter Maydell geschrieben: > > > dd/truncate etc won't work if the image file is not raw (eg if > > > it's qcow2). The only chance you have of something that's actually > > > generic would probably involve "qemu-img resize". But I'm a bit > > > wary of having an error message that recommends that, because > > > what if we got it wrong? > > > > What is your concern that we might get wrong? The suggestion is always > > extending the size rather than shrinking, so it should be harmless and > > easy to undo. (Hm, we should finally make --shrink mandatory for > > shrinking. We've printed a deprecation warning for almost three years.) > > If there's a qemu-img command line that will always only > extend the image size and never let the user accidentally > shrink it and throw away data, then great. I'd happily > recommend that. I think removing deprecated behaviour is a change that we can still make in the early freeze. So if you agree, I'll send a patch that makes shrinking an image without --shrink a hard error in 5.1. Kevin