All of lore.kernel.org
 help / color / mirror / Atom feed
From: <dan.carpenter@oracle.com>
To: <daniele.ceraolospurio@intel.com>
Subject: [Intel-gfx] [bug report] drm/i915: Move the engine mask to intel_gt_info
Date: Fri, 10 Jul 2020 17:11:47 +0300	[thread overview]
Message-ID: <20200710141147.GA135232@mwanda> (raw)

Hello Daniele Ceraolo Spurio,

This is a semi-automatic email about new static checker warnings.

The patch 792592e72aba: "drm/i915: Move the engine mask to
intel_gt_info" from Jul 7, 2020, leads to the following Smatch
complaint:

    drivers/gpu/drm/i915/i915_gpu_error.c:801 __err_print_to_sgl()
    error: we previously assumed 'error->gt' could be null (see line 792)

drivers/gpu/drm/i915/i915_gpu_error.c
   791	
   792		if (error->gt)
                    ^^^^^^^^^
Existing code checks for NULL.

   793			err_print_gt(m, error->gt);
   794	
   795		if (error->overlay)
   796			intel_overlay_print_error_state(m, error->overlay);
   797	
   798		if (error->display)
   799			intel_display_print_error_state(m, error->display);
   800	
   801		err_print_capabilities(m, error);
                                          ^^^^^
Unchecked dereference inside function call.

   802		err_print_params(m, &error->params);
   803	}

regards,
dan carpenter
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

                 reply	other threads:[~2020-07-10 17:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200710141147.GA135232@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=daniele.ceraolospurio@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.