From: sdf@google.com
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf <bpf@vger.kernel.org>
Subject: Re: Occasionally hanging sockopts selftests
Date: Fri, 10 Jul 2020 13:20:56 -0700 [thread overview]
Message-ID: <20200710202056.GA184844@google.com> (raw)
In-Reply-To: <CAEf4BzY0-bVNHmCkMFPgObs=isUAyg-dFzGDY7QWYkmm7rmTSg@mail.gmail.com>
On 07/10, Andrii Nakryiko wrote:
> Hey Stanislav,
> I've noticed that on 5.5 kernel libbpf Travis CI test runs
> occasionally fail due to selftests hanging indefinitely. It seems like
> it always happens after sockopt tests succeed, and while
> sockopt_inherit test is running. Doesn't seem like the latest kernel
> is affected (I haven't found hangs for the latest kernel in recent
> history).
> This is the latest version of selftests, but running on an older (5.5)
> version of kernel. So whatever fixes went into selftests are there
> already. So I wonder if there were any kernel bugs that were fixed
> already but could cause hangs on 5.5?
> I can disable that specific test for 5.5, but though I should bring
> this up first, just in case there are still some bugs in selftests.
> Thanks for checking!
> Two most recent failures (not that they are helpful, because there is
> no output until tests completes, but still):
> - https://travis-ci.com/github/libbpf/libbpf/jobs/359067538
> - https://travis-ci.com/github/libbpf/libbpf/jobs/359784775
Nothing pops up, I don't think we did any fixes to address any
occasional failles like that.
The only fixes we did are:
d8fe449a9c51 - bpf: Don't return EINVAL from {get,set}sockopt when optlen >
PAGE_SIZE
9babe825da76 - bpf: always allocate at least 16 bytes for setsockopt hook
And I don't see how this test can hang without any of those (should
either always pass or fail).
Let's maybe try to disable it, as you suggested, and see if that's
indeed this sockopt_inherit test that's misbehaving?
I can try to find some time next week to reproduce.
next prev parent reply other threads:[~2020-07-10 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 18:01 Occasionally hanging sockopts selftests Andrii Nakryiko
2020-07-10 20:20 ` sdf [this message]
2020-07-10 20:47 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710202056.GA184844@google.com \
--to=sdf@google.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.