From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:5042:0:0:0:0:0 with SMTP id a2csp1177383lfm; Fri, 10 Jul 2020 16:51:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznY113G8BPc419wqOHQ9Iit7Ks0qsNNmbabqnGPW8DU0eoyzqNpPLD1b5ccxjS0LoCt54u X-Received: by 2002:a25:bb07:: with SMTP id z7mr64783445ybg.343.1594425063333; Fri, 10 Jul 2020 16:51:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594425063; cv=none; d=google.com; s=arc-20160816; b=Kcr7A4BJYSVDvZHQdZF+gi1ZV8JLlWs3KzJJkgeZNtCgsy3INAeS/MhUKjfESLVAPF NUHup3nlZpt5YbVUz470+DVshRb3cboKiFCvnDC5pUgBJ2WD4dwCdrtO5c+o/XOzqiRL SpCOfnaPQF1lAkxAYZvEAfZYhtH4tFxra5m/jFm8LRekhNC1VOo9lpWIPtkJ2+TpH0be n5NwPdLgyyryDE6CjI35iwSA9+yTwH3MMPVUS02KbZIQHsHSkWri+HZnihCH/THWCGOa QkDM0icPOYu43n79bVudM5LNBQAkFCI9uKTrUZ0hRhl9MupvkDF8pkFxsR1czNrnEWNe lJig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:user-agent :in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=EZEzUt7O1ol2Sg+jnXkibkoEj5o4nuVGVLftXtZDboc=; b=wyICeisUWYCb6kYS/rKzDtIUutNA+2FU+FritBlBT+DXuTvvVsc4c39Pya7izV6Kg5 kzx4QGxnE4dSMlnQFee5uau0M/UWnhsqBupMK1PCsey3dl2NcLNYo3qB6kGIxOlJVbIi u/phH/T/0dl7TD2eeP1j7vIBs4H3fLrDlJos5zQv/8wGOewnk6yH5mIZGbNRwRAb5AyX 0Wgzm92SNC7B11sLtylVi3rvOYEEOlrjj1eRQCovih+YIvZpj6SNa+hvZlr+a0sW62W1 LciOeJkj5HItDyqbTXd2Ka9if2hSZ8uD2Fg49wYVTP3mFDovrvRdhZzCzk9X4IJDT0pM T9mQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="XDco+x/h"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 128si7036667ybq.226.2020.07.10.16.51.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Jul 2020 16:51:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="XDco+x/h"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Received: from localhost ([::1]:54464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ju2nG-0005AH-OM for alex.bennee@linaro.org; Fri, 10 Jul 2020 19:51:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ju2mg-0004Ol-Hu; Fri, 10 Jul 2020 19:50:26 -0400 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]:39748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ju2me-00035G-TD; Fri, 10 Jul 2020 19:50:26 -0400 Received: by mail-oi1-x241.google.com with SMTP id w17so6184383oie.6; Fri, 10 Jul 2020 16:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=EZEzUt7O1ol2Sg+jnXkibkoEj5o4nuVGVLftXtZDboc=; b=XDco+x/hfNHB0P2uWyPJGW/c9o6tXTvig9zHCsCFnCA9dnlDYEAhxKlU1LHhhKxpfR GTU59cwQwccu+OCIau0C38LE7gcGMBNZyOF+lvLh9UrVd7M/cqOi8WUVhGNRa0wNim+g d4xUji7jh4M9HmW2hWerRQTZWhc+VnSeKFZPFFcJ90FbYJ1woIz3WJTveAtuQBopWma8 NfaQWRtt2L0UN6KvcbgiuKP301jilRKrAWyUOTHFcApVmwSQya/ZgRwpl49yINR1RlFz 1Hqzzc6PNpM8SGg5pDr90CxDdj2LUv/xcE4sskWqR8hGryp0XdFjJdYIuNdTMXs/MCgk gmTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=EZEzUt7O1ol2Sg+jnXkibkoEj5o4nuVGVLftXtZDboc=; b=qdPKiWUJWbiCN53YAAsyCavmP1bO8yWjH+NzYl1jO9vd8T/G8XThK/gvG9qrIxySuB JQkO0tuoSzPV2QoHu5IiFLnVUU/UWpulDYfH9/eIobjqsisGSgjBwBZeZQABHVo2GOLX /5lhsAyp3jy/6MwLbyT26PUIhC9z4aijs37VKWf3hmxLH/ef8CGId0WXoeinvdrpYrey kntnJag0eWLb04sJQfW7LNJqouu4MVPuLN4joAU5Zhe6+mJYufATU1lpt8oCBOD//AZB 1epIIEPn8EBVzURApzF0K/QPc9ZkLaGeQLv16sfu6C9OJeRXxl14S3QvMKJrOlsElr6Q EZGQ== X-Gm-Message-State: AOAM533WpGjnE67xm3dMcN8LvAKFKFEgNkXn+WM1CyNqHxVoDDA+q2CV WgRD2ykEipSJ6pLSV/OoCA== X-Received: by 2002:a54:4595:: with SMTP id z21mr6027517oib.157.1594425022256; Fri, 10 Jul 2020 16:50:22 -0700 (PDT) Received: from serve.minyard.net ([47.184.146.204]) by smtp.gmail.com with ESMTPSA id 95sm1367866ott.6.2020.07.10.16.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 16:50:20 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:5810:6df8:8a6e:345]) by serve.minyard.net (Postfix) with ESMTPSA id DBBE9180714; Fri, 10 Jul 2020 23:50:19 +0000 (UTC) Date: Fri, 10 Jul 2020 18:50:18 -0500 From: Corey Minyard To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v2 0/5] hw/i2c: Rename method names for consistency and add documentation Message-ID: <20200710235018.GC3235@minyard.net> References: <20200705224154.16917-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Received-SPF: pass client-ip=2607:f8b0:4864:20::241; envelope-from=tcminyard@gmail.com; helo=mail-oi1-x241.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: Corey Minyard , Peter Maydell , Andrew Jeffery , qemu-devel@nongnu.org, Markus Armbruster , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater , Jan Kiszka , David Gibson , Joel Stanley Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: +ZTPRcINKp4N On Fri, Jul 10, 2020 at 11:53:13AM +0200, Philippe Mathieu-Daudé wrote: > Corey, this series is now fully reviewed :) Ok, I've pulled this in and added the extra reviews that came in. I'll work on getting it out Monday. Thanks, -corey > > On 7/6/20 12:41 AM, Philippe Mathieu-Daudé wrote: > > In commit d88c42ff2c we added 2 methods: i2c_try_create_slave() > > and i2c_realize_and_unref(). > > Markus noted their name could be improved for consistency [1], > > and Peter reported the lack of documentation [2]. Fix that now. > > > > Since v1: > > - Addressed Markus review comments > > - Added Markus/Corey R-b tags > > > > [1] https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg07060.html > > [2] https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg08997.html > > > > $ git backport-diff -u -v1 > > Key: > > [----] : patches are identical > > [####] : number of functional differences between upstream/downstream patch > > [down] : patch is downstream-only > > The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively > > > > 001/5:[----] [--] 'hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus()' > > 002/5:[0006] [FC] 'hw/i2c: Rename i2c_try_create_slave() as i2c_slave_new()' > > 003/5:[0004] [FC] 'hw/i2c: Rename i2c_realize_and_unref() as i2c_slave_realize_and_unref()' > > 004/5:[0006] [FC] 'hw/i2c: Rename i2c_create_slave() as i2c_slave_create_simple()' > > 005/5:[0012] [FC] 'hw/i2c: Document the I2C qdev helpers' >