From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 15/23] seq_file: switch over direct seq_read method calls to seq_read_iter Date: Sat, 11 Jul 2020 08:48:57 +0200 Message-ID: <20200711064857.GA29078@lst.de> References: <20200707174801.4162712-1-hch@lst.de> <20200707174801.4162712-16-hch@lst.de> <5a2a97f1-58b5-8068-3c69-bb06130ffb35@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5a2a97f1-58b5-8068-3c69-bb06130ffb35-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jon Hunter Cc: Christoph Hellwig , Al Viro , Linus Torvalds , Stephen Rothwell , Luis Chamberlain , Matthew Wilcox , Kees Cook , Iurii Zaikin , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra List-Id: linux-tegra@vger.kernel.org Please try this one: --- >From 5e86146296fbcd7593da1d9d39b9685a5e6b83be Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Sat, 11 Jul 2020 08:46:10 +0200 Subject: debugfs: add a proxy stub for ->read_iter debugfs registrations typically go through a set of proxy ops to deal with refcounting, which need to support every method that can be supported. Add ->read_iter to the proxy ops to prepare for seq_file to be switch to ->read_iter. Reported-by: Jon Hunter Signed-off-by: Christoph Hellwig --- fs/debugfs/file.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 8ba32c2feb1b73..dcd7bdaf67417f 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -231,6 +231,10 @@ FULL_PROXY_FUNC(read, ssize_t, filp, loff_t *ppos), ARGS(filp, buf, size, ppos)); +FULL_PROXY_FUNC(read_iter, ssize_t, iocb->ki_filp, + PROTO(struct kiocb *iocb, struct iov_iter *iter), + ARGS(iocb, iter)); + FULL_PROXY_FUNC(write, ssize_t, filp, PROTO(struct file *filp, const char __user *buf, size_t size, loff_t *ppos), @@ -286,6 +290,8 @@ static void __full_proxy_fops_init(struct file_operations *proxy_fops, proxy_fops->llseek = full_proxy_llseek; if (real_fops->read) proxy_fops->read = full_proxy_read; + if (real_fops->read_iter) + proxy_fops->read_iter = full_proxy_read_iter; if (real_fops->write) proxy_fops->write = full_proxy_write; if (real_fops->poll) -- 2.26.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 989D0C433E2 for ; Sat, 11 Jul 2020 06:49:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DA26206F0 for ; Sat, 11 Jul 2020 06:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728056AbgGKGtB (ORCPT ); Sat, 11 Jul 2020 02:49:01 -0400 Received: from verein.lst.de ([213.95.11.211]:45371 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727867AbgGKGtA (ORCPT ); Sat, 11 Jul 2020 02:49:00 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9B60168AEF; Sat, 11 Jul 2020 08:48:57 +0200 (CEST) Date: Sat, 11 Jul 2020 08:48:57 +0200 From: Christoph Hellwig To: Jon Hunter Cc: Christoph Hellwig , Al Viro , Linus Torvalds , Stephen Rothwell , Luis Chamberlain , Matthew Wilcox , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-tegra Subject: Re: [PATCH 15/23] seq_file: switch over direct seq_read method calls to seq_read_iter Message-ID: <20200711064857.GA29078@lst.de> References: <20200707174801.4162712-1-hch@lst.de> <20200707174801.4162712-16-hch@lst.de> <5a2a97f1-58b5-8068-3c69-bb06130ffb35@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a2a97f1-58b5-8068-3c69-bb06130ffb35@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Please try this one: --- >From 5e86146296fbcd7593da1d9d39b9685a5e6b83be Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Sat, 11 Jul 2020 08:46:10 +0200 Subject: debugfs: add a proxy stub for ->read_iter debugfs registrations typically go through a set of proxy ops to deal with refcounting, which need to support every method that can be supported. Add ->read_iter to the proxy ops to prepare for seq_file to be switch to ->read_iter. Reported-by: Jon Hunter Signed-off-by: Christoph Hellwig --- fs/debugfs/file.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 8ba32c2feb1b73..dcd7bdaf67417f 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -231,6 +231,10 @@ FULL_PROXY_FUNC(read, ssize_t, filp, loff_t *ppos), ARGS(filp, buf, size, ppos)); +FULL_PROXY_FUNC(read_iter, ssize_t, iocb->ki_filp, + PROTO(struct kiocb *iocb, struct iov_iter *iter), + ARGS(iocb, iter)); + FULL_PROXY_FUNC(write, ssize_t, filp, PROTO(struct file *filp, const char __user *buf, size_t size, loff_t *ppos), @@ -286,6 +290,8 @@ static void __full_proxy_fops_init(struct file_operations *proxy_fops, proxy_fops->llseek = full_proxy_llseek; if (real_fops->read) proxy_fops->read = full_proxy_read; + if (real_fops->read_iter) + proxy_fops->read_iter = full_proxy_read_iter; if (real_fops->write) proxy_fops->write = full_proxy_write; if (real_fops->poll) -- 2.26.2