From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2507207742615111282==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [PATCH] mt6625l: fix itnull.cocci warnings Date: Sun, 12 Jul 2020 20:19:10 +0800 Message-ID: <20200712121910.GA72436@f669aaa75a90> In-Reply-To: <202007122043.encHIg4V%lkp@intel.com> List-Id: --===============2507207742615111282== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kernel test robot drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_rlm.c:414:7-15: ERROR= : iterator variable bound on line 412 cannot be NULL Many iterators have the property that the first argument is always bound to a real list element, never NULL. Semantic patch information: False positives arise for some iterators that do not have this property, or in cases when the loop cursor is reassigned. The latter should only happen when the matched code is on the way to a loop exit (break, goto, or return). Generated by: scripts/coccinelle/iterators/itnull.cocci Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder") Signed-off-by: kernel test robot --- tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc head: ca0d6f7786586ca7ba424d5967d780dd3c75748b commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wi= fi-folder Please take the patch only if it's a positive warning. Thanks! p2p_rlm.c | 4 ---- 1 file changed, 4 deletions(-) --- a/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_rlm.c +++ b/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_rlm.c @@ -411,10 +411,6 @@ VOID rlmUpdateParamsForAP(P_ADAPTER_T pr = LINK_FOR_EACH_ENTRY(prStaRec, prStaList, rLinkEntry, STA_RECORD_T) { /* ASSERT(prStaRec); */ - if (!prStaRec) { - DBGLOG(P2P, TRACE, "prStaRec is NULL in rlmUpdateParamsForAP()\n"); - break; - } if (prStaRec->fgIsInUse && prStaRec->ucStaState =3D=3D STA_STATE_3 && prStaRec->ucNetTypeIndex =3D=3D prBssInfo->ucNetTypeIndex) { if (!(prStaRec->ucPhyTypeSet & (PHY_TYPE_SET_802_11GN | PHY_TYPE_SET_80= 2_11A))) { --===============2507207742615111282==--