From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1488768979709116446==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [PATCH] mt6625l: fix returnvar.cocci warnings Date: Sun, 12 Jul 2020 20:19:16 +0800 Message-ID: <20200712121916.GA72871@f669aaa75a90> In-Reply-To: <202007122043.encHIg4V%lkp@intel.com> List-Id: --===============1488768979709116446== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kernel test robot drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c:3012:13-20: Unn= eeded variable: "rStatus". Return "WLAN_STATUS_SUCCESS" on line 3022 drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c:3068:13-24: Unn= eeded variable: "rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 3091 drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c:3036:13-24: Unn= eeded variable: "rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 3049 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder") Signed-off-by: kernel test robot --- tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc head: ca0d6f7786586ca7ba424d5967d780dd3c75748b commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wi= fi-folder Please take the patch only if it's a positive warning. Thanks! p2p_fsm.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) --- a/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c +++ b/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_fsm.c @@ -3009,8 +3009,6 @@ WLAN_STATUS p2pRunEventAAAComplete(IN P_ /*------------------------------------------------------------------------= ----*/ WLAN_STATUS p2pRunEventAAASuccess(IN P_ADAPTER_T prAdapter, IN P_STA_RECOR= D_T prStaRec) { - WLAN_STATUS rStatus =3D WLAN_STATUS_SUCCESS; - do { ASSERT_BREAK((prAdapter !=3D NULL) && (prStaRec !=3D NULL)); = @@ -3019,7 +3017,7 @@ WLAN_STATUS p2pRunEventAAASuccess(IN P_A = } while (FALSE); = - return rStatus; + return WLAN_STATUS_SUCCESS; } /* p2pRunEventAAASuccess */ = /*------------------------------------------------------------------------= ----*/ @@ -3033,7 +3031,6 @@ WLAN_STATUS p2pRunEventAAASuccess(IN P_A /*------------------------------------------------------------------------= ----*/ WLAN_STATUS p2pRxPublicActionFrame(IN P_ADAPTER_T prAdapter, IN P_SW_RFB_T= prSwRfb) { - WLAN_STATUS rWlanStatus =3D WLAN_STATUS_SUCCESS; P_P2P_PUBLIC_ACTION_FRAME_T prPublicActionFrame =3D (P_P2P_PUBLIC_ACTION_= FRAME_T) NULL; P_P2P_FSM_INFO_T prP2pFsmInfo =3D (P_P2P_FSM_INFO_T) NULL; = @@ -3046,7 +3043,7 @@ WLAN_STATUS p2pRxPublicActionFrame(IN P_ DBGLOG(P2P, TRACE, "RX Public Action Frame Token:%d.\n", prPublicActionFr= ame->ucDialogToken); = if (prPublicActionFrame->ucCategory !=3D CATEGORY_PUBLIC_ACTION) - return rWlanStatus; + return WLAN_STATUS_SUCCESS; = switch (prPublicActionFrame->ucAction) { case ACTION_PUBLIC_WIFI_DIRECT: @@ -3060,12 +3057,11 @@ WLAN_STATUS p2pRxPublicActionFrame(IN P_ break; } = - return rWlanStatus; + return WLAN_STATUS_SUCCESS; } /* p2pRxPublicActionFrame */ = WLAN_STATUS p2pRxActionFrame(IN P_ADAPTER_T prAdapter, IN P_SW_RFB_T prSwR= fb) { - WLAN_STATUS rWlanStatus =3D WLAN_STATUS_SUCCESS; P_P2P_ACTION_FRAME_T prP2pActionFrame =3D (P_P2P_ACTION_FRAME_T) NULL; UINT_8 aucOui[3] =3D VENDOR_OUI_WFA_SPECIFIC; = @@ -3088,7 +3084,7 @@ WLAN_STATUS p2pRxActionFrame(IN P_ADAPTE = } while (FALSE); = - return rWlanStatus; + return WLAN_STATUS_SUCCESS; } /* p2pRxActionFrame */ = VOID --===============1488768979709116446==--