From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2867412155944647116==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [PATCH] mt6625l: fix returnvar.cocci warnings Date: Sun, 12 Jul 2020 20:19:17 +0800 Message-ID: <20200712121917.GA72958@f669aaa75a90> In-Reply-To: <202007122043.encHIg4V%lkp@intel.com> List-Id: --===============2867412155944647116== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kernel test robot drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_func.c:2056:9-26: Unn= eeded variable: "fgIsReplyProbeRsp". Return "FALSE" on line 2077 drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_func.c:1301:13-24: Un= needed variable: "rWlanStatus". Return "WLAN_STATUS_SUCCESS" on line 1373 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder") Signed-off-by: kernel test robot --- tree: https://github.com/frank-w/BPI-R2-4.14 5.8-rc head: ca0d6f7786586ca7ba424d5967d780dd3c75748b commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wi= fi-folder Please take the patch only if it's a positive warning. Thanks! p2p_func.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_func.c +++ b/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_func.c @@ -1298,7 +1298,6 @@ WLAN_STATUS p2pFuncTxMgmtFrame(IN P_ADAPTER_T prAdapter, IN P_P2P_MGMT_TX_REQ_INFO_T prMgmtTxReqInfo, IN P_MSDU_INFO_T prMgmtT= xMsdu, IN UINT_64 u8Cookie) { - WLAN_STATUS rWlanStatus =3D WLAN_STATUS_SUCCESS; P_MSDU_INFO_T prTxMsduInfo =3D (P_MSDU_INFO_T) NULL; P_WLAN_MAC_HEADER_T prWlanHdr =3D (P_WLAN_MAC_HEADER_T) NULL; P_STA_RECORD_T prStaRec =3D (P_STA_RECORD_T) NULL; @@ -1370,7 +1369,7 @@ p2pFuncTxMgmtFrame(IN P_ADAPTER_T prAdap = } while (FALSE); = - return rWlanStatus; + return WLAN_STATUS_SUCCESS; } /* p2pFuncTxMgmtFrame */ = VOID p2pFuncSetChannel(IN P_ADAPTER_T prAdapter, IN P_RF_CHANNEL_INFO_T pr= RfChannelInfo) @@ -2053,7 +2052,6 @@ BOOLEAN p2pFuncParseCheckForP2PInfoElem( /*------------------------------------------------------------------------= ----*/ BOOLEAN p2pFuncValidateProbeReq(IN P_ADAPTER_T prAdapter, IN P_SW_RFB_T pr= SwRfb, OUT PUINT_32 pu4ControlFlags) { - BOOLEAN fgIsReplyProbeRsp =3D FALSE; P_P2P_FSM_INFO_T prP2pFsmInfo =3D (P_P2P_FSM_INFO_T) NULL; = DEBUGFUNC("p2pFuncValidateProbeReq"); @@ -2074,7 +2072,7 @@ BOOLEAN p2pFuncValidateProbeReq(IN P_ADA = } while (FALSE); = - return fgIsReplyProbeRsp; + return FALSE; = } /* end of p2pFuncValidateProbeReq() */ =20 --===============2867412155944647116==--