Re: [PATCH v2 1/2] ARM: dts: imx6q-tbs2910: Pass phy-reset-duration

[Shawn Guo <shawnguo@kernel.org>]

On Thu, Jun 25, 2020 at 06:29:22PM +0200, Soeren Moch wrote:
> Hi Fabio,
> 
> On 25.06.20 13:18, Fabio Estevam wrote:
> > According to the AR8035 datasheet:
> >
> > "When using crystal, the clock is generated internally after power is
> > stable. For a reliable power on reset, suggest to keep asserting the reset
> > low long enough (10ms) to ensure the clock is stable and clock-to-reset 1ms
> > requirement is satisfied."
> >
> > Pass the 'phy-reset-duration' property to meet such requirement.
> >
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> "phy-reset-duration" is listed as deprecated in
> Documentation/devicetree/bindings/net/fsl-fec.txt .

Good point.  There must be some new way we should do this properly.

Shawn

> So maybe it is not the best option, but it should work.
> 
> Reviewed-by: Soeren Moch <smoch@web.de>
> 
> Thanks,
> Soeren
> > ---
> > Changes since v1:
> > - None.
> >
> >  arch/arm/boot/dts/imx6q-tbs2910.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6q-tbs2910.dts b/arch/arm/boot/dts/imx6q-tbs2910.dts
> > index bfff87ce2e1f..7b03b2787430 100644
> > --- a/arch/arm/boot/dts/imx6q-tbs2910.dts
> > +++ b/arch/arm/boot/dts/imx6q-tbs2910.dts
> > @@ -100,6 +100,7 @@
> >  	pinctrl-0 = <&pinctrl_enet>;
> >  	phy-mode = "rgmii-id";
> >  	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> > +	phy-reset-duration = <10>;
> >  	status = "okay";
> >  };
> >
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel