From: Lee Jones <lee.jones@linaro.org>
To: Xu Yilun <yilun.xu@intel.com>
Cc: linux-kernel@vger.kernel.org, trix@redhat.com,
matthew.gerlach@linux.intel.com, russell.h.weight@intel.com,
lgoncalv@redhat.com, Wu Hao <hao.wu@intel.com>
Subject: Re: [PATCH 1/2] mfd: intel-m10-bmc: add Max10 BMC chip support for Intel FPGA PAC
Date: Mon, 13 Jul 2020 10:17:08 +0100 [thread overview]
Message-ID: <20200713091708.GC3500@dell> (raw)
In-Reply-To: <1594614896-16606-2-git-send-email-yilun.xu@intel.com>
On Mon, 13 Jul 2020, Xu Yilun wrote:
> This patch implements the basic functions of the BMC chip for some Intel
> FPGA PCIe Acceleration Cards (PAC). The BMC is implemented using the
> intel max10 CPLD.
>
> This BMC chip is connected to FPGA by a SPI bus. To provide reliable
> register access from FPGA, an Avalon Memory-Mapped (Avmm) transaction
> protocol over the SPI bus is used between host and slave.
>
> This driver implements the basic register access with the regmap framework.
> The mfd cells array is empty now as a placeholder.
>
> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> Signed-off-by: Wu Hao <hao.wu@intel.com>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> .../ABI/testing/sysfs-driver-intel-m10-bmc | 15 +
> drivers/mfd/Kconfig | 13 +
> drivers/mfd/Makefile | 3 +
> drivers/mfd/intel-m10-bmc-main.c | 176 ++++
> drivers/mfd/intel-spi-avmm.c | 904 +++++++++++++++++++++
This does not belong in MFD.
Please consider moving it to drivers/spi.
> drivers/mfd/intel-spi-avmm.h | 35 +
> include/linux/mfd/intel-m10-bmc.h | 57 ++
> 7 files changed, 1203 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-driver-intel-m10-bmc
> create mode 100644 drivers/mfd/intel-m10-bmc-main.c
> create mode 100644 drivers/mfd/intel-spi-avmm.c
> create mode 100644 drivers/mfd/intel-spi-avmm.h
> create mode 100644 include/linux/mfd/intel-m10-bmc.h
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-07-13 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 4:34 [PATCH 0/2] add Intel Max10 BMC chip support Xu Yilun
2020-07-13 4:34 ` [PATCH 1/2] mfd: intel-m10-bmc: add Max10 BMC chip support for Intel FPGA PAC Xu Yilun
2020-07-13 9:17 ` Lee Jones [this message]
2020-07-14 6:05 ` Xu Yilun
2020-07-14 6:50 ` Lee Jones
2020-07-14 6:52 ` Xu Yilun
2020-07-13 4:34 ` [PATCH 2/2] mfd: intel-m10-bmc: start with the last SOP on phy rx buffer parsing Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713091708.GC3500@dell \
--to=lee.jones@linaro.org \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.