From: Tony Lindgren <tony@atomide.com>
To: Drew Fustini <drew@beagleboard.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Jason Kridner <jkridner@beagleboard.org>,
Robert Nelson <robertcnelson@gmail.com>
Subject: Re: gpio-omap: handle bias flag for gpio line
Date: Mon, 13 Jul 2020 11:05:19 -0700 [thread overview]
Message-ID: <20200713180519.GN5849@atomide.com> (raw)
In-Reply-To: <20200713174747.GA1424108@x1>
* Drew Fustini <drew@beagleboard.org> [200713 17:47]:
> Do you mean you would like to see the mapping added as a column in the pins file?
>
> debian@beaglebone:~$ sudo cat /sys/kernel/debug/pinctrl/44e10800.pinmux-pinctrl-single/pins |head
> registered pins: 142
> pin 0 (PIN0) 44e10800 00000027 pinctrl-single
> pin 1 (PIN1) 44e10804 00000027 pinctrl-single
> pin 2 (PIN2) 44e10808 00000027 pinctrl-single
> pin 3 (PIN3) 44e1080c 00000027 pinctrl-single
> pin 4 (PIN4) 44e10810 00000027 pinctrl-single
> pin 5 (PIN5) 44e10814 00000027 pinctrl-single
> pin 6 (PIN6) 44e10818 00000027 pinctrl-single
> pin 7 (PIN7) 44e1081c 00000027 pinctrl-single
> pin 8 (PIN8) 44e10820 00000027 pinctrl-single
>
> So that could be:
>
> debian@beaglebone:~$ sudo cat /sys/kernel/debug/pinctrl/44e10800.pinmux-pinctrl-single/pins |head
> registered pins: 142
> pin 0 (PIN0) 44e10800 00000027 pinctrl-single GPIO-32
> pin 1 (PIN1) 44e10804 00000027 pinctrl-single GPIO-33
> pin 2 (PIN2) 44e10808 00000027 pinctrl-single GPIO-34
> pin 3 (PIN3) 44e1080c 00000027 pinctrl-single GPIO-35
> pin 4 (PIN4) 44e10810 00000027 pinctrl-single GPIO-36
> pin 5 (PIN5) 44e10814 00000027 pinctrl-single GPIO-37
> pin 6 (PIN6) 44e10818 00000027 pinctrl-single GPIO-38
> pin 7 (PIN7) 44e1081c 00000027 pinctrl-single GPIO-39
> pin 8 (PIN8) 44e10820 00000027 pinctrl-single GPIO-22
Yes that would make the debugfs output more understandable and
easier to use.
> Should I try to add that in pcs_pin_dbg_show()?
>
> It currently prints:
>
> seq_printf(s, "%zx %08x %s ", pa, val, DRIVER_NAME);
>
> so I could change that to include the GPIO number if mapping exists.
Sounds good to me yeah :) However, the issue of relying on
debugfs for this still remains unsolved. But seems that
probably should be done with the existing GPIO related
API instead and a different issue from the pinctrl
changes.
Regards,
Tony
next prev parent reply other threads:[~2020-07-13 18:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 0:27 gpio-omap: handle bias flag for gpio line Drew Fustini
2020-07-07 12:38 ` Linus Walleij
2020-07-12 21:56 ` Drew Fustini
2020-07-13 15:02 ` Tony Lindgren
2020-07-13 17:47 ` Drew Fustini
2020-07-13 18:05 ` Tony Lindgren [this message]
2020-07-17 1:42 ` Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713180519.GN5849@atomide.com \
--to=tony@atomide.com \
--cc=drew@beagleboard.org \
--cc=jkridner@beagleboard.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.