From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
f.fainelli@gmail.com, vivien.didelot@gmail.com,
xiyou.wangcong@gmail.com, ap420073@gmail.com
Subject: Re: [PATCH net] net: dsa: link interfaces with the DSA master to get rid of lockdep warnings
Date: Mon, 13 Jul 2020 20:59:35 +0200 [thread overview]
Message-ID: <20200713185935.GL1078057@lunn.ch> (raw)
In-Reply-To: <20200713174227.p6owrtgyccxfbuj5@skbuf>
> One difference from VLAN is that in that case, the entire
> register_vlan_device() function runs under RTNL.
> When those bugs that you talk about are found, who starts using the
> network interface too early? User space or someone else? Would RTNL be
> enough to avoid that?
NFS root. Registering the interface causes autoconfig to start,
sending a DHCP request, or if the IP addresses are fixed, it could
send an ARP for the NFS server.
It is just nice to have if it is before register_netdev(). I don't
think there is an actual issues in this case, being able to
send/receive packets should not depend on the upper/lower linkage for
DSA.
Andrew
next prev parent reply other threads:[~2020-07-13 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 16:24 [PATCH net] net: dsa: link interfaces with the DSA master to get rid of lockdep warnings Vladimir Oltean
2020-07-13 16:47 ` Andrew Lunn
2020-07-13 17:30 ` Vladimir Oltean
2020-07-13 17:33 ` Vladimir Oltean
2020-07-13 17:42 ` Vladimir Oltean
2020-07-13 18:59 ` Andrew Lunn [this message]
2020-07-14 0:48 ` David Miller
2020-07-13 18:39 ` Florian Fainelli
2020-07-16 23:06 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713185935.GL1078057@lunn.ch \
--to=andrew@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.