From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gregkh@linuxfoundation.org>
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by galois.linutronix.de (Postfix) with ESMTPS id 4440B404ED
	for <speck@linutronix.de>; Tue, 14 Jul 2020 07:58:30 +0200 (CEST)
Date: Tue, 14 Jul 2020 07:58:27 +0200
From: Greg KH <gregkh@linuxfoundation.org>
Subject: [MODERATED] Re: [PATCH] Raffle 0
Message-ID: <20200714055827.GA656406@kroah.com>
References: <5f0cf7c5.1c69fb81.99805.3f5fSMTPIN_ADDED_BROKEN@mx.google.com>
MIME-Version: 1.0
In-Reply-To: <5f0cf7c5.1c69fb81.99805.3f5fSMTPIN_ADDED_BROKEN@mx.google.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
To: speck@linutronix.de
List-ID: <speck.linutronix.de>

On Mon, Jul 13, 2020 at 05:03:44PM -0700, speck for Pawan Gupta wrote:
> From: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
> Subject: [PATCH] powercap: restrict energy meter to root access
> 
> From: Len Brown <len.brown@intel.com>
> 
> Remove non-privileged user access to power data contained in
> /sys/class/powercap/intel_rapl/*/energy_uj
> 
> Non-privileged users currently have read access to power data and can
> use this data to form a security attack.  Some privileged
> drivers/applications need read access to this data but don't expose it
> to non-privileged users.
> 
> For example, thermald uses this data to ensure that power management
> works correctly.  Thus removing non-privileged access is preferred over
> completely disabling this power reporting capability with
> CONFIG_INTEL_RAPL=n.
> 
> Fixes: 95677a9a3847 ("PowerCap: Fix mode for energy counter")
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
>  drivers/powercap/powercap_sys.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Also, any reason you didn't run this through checkpatch.pl first?