Re: [PATCH v2] USB: serial: add support for MaxLinear XR21V1412

[Johan Hovold <johan@kernel.org>]

On Fri, Jul 10, 2020 at 12:21:26AM +0200, Angelo Dureghello wrote:
> From some researches, this driver is available from the IC
> constructor site, but for older kernel versions. From there, decided
> to add a much simplier mainline version, written from scratch.

Do you have a pointer to the vendor sources for reference?

> This initial simple version is implemented without any flow control,
> tested mainly at 115200, but all standard baud rates are supported
> and applied as per serial terminal settings.
> 
> Signed-off-by: Angelo Dureghello <angelo.dureghello@timesys.com>
> Reported-by: kernel test robot <lkp@intel.com>

No need for a reported-by if the robot catches issues during review.
Just mention it in the changelog as you already did below.

> ---
> Changes for v2:
> - fix test robot warning, PARITY_ defines renamed
> ---
>  drivers/usb/serial/Kconfig     |   9 +
>  drivers/usb/serial/Makefile    |   1 +
>  drivers/usb/serial/xr21v1412.c | 361 +++++++++++++++++++++++++++++++++
>  3 files changed, 371 insertions(+)
>  create mode 100644 drivers/usb/serial/xr21v1412.c

Thanks for the submitting this.

There was another driver for this device posted recently, and which
appears to have more features:

	https://lore.kernel.org/r/20200607162350.21297-2-mani@kernel.org

Would you mind taking a look and see if that one would work for you?

I had some comments on the latest version that needs to be addressed,
but I'm assuming Manivannan is working on a v5?

Johan