From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/scons: explicitly specify host Python 3
Date: Tue, 14 Jul 2020 10:15:10 +0200 [thread overview]
Message-ID: <20200714101510.378d1909@windsurf.home> (raw)
In-Reply-To: <20200714033927.1516172-1-hancock@sedsystems.ca>
On Mon, 13 Jul 2020 21:39:27 -0600
Robert Hancock <hancock@sedsystems.ca> wrote:
> All packages using scons are now using Python 3 to run it, so
> explicitly set scons as using host-python3. This avoids a
> spurious host Python 2 dependency if BR2_PACKAGE_PYTHON3 is not
> set (for example, if no Python is packaged for the target).
>
> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
> ---
> package/scons/scons.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/scons/scons.mk b/package/scons/scons.mk
> index da2ccceb08..a95fa7fd69 100644
> --- a/package/scons/scons.mk
> +++ b/package/scons/scons.mk
> @@ -10,6 +10,8 @@ SCONS_LICENSE = MIT
> SCONS_LICENSE_FILES = LICENSE.txt
> SCONS_SETUP_TYPE = distutils
>
> +HOST_SCONS_NEEDS_HOST_PYTHON = python3
I am just wondering if we should do our usual dance that consists in
relying on python2 if enabled, i.e something like this:
HOST_SCONS_NEEDS_HOST_PYTHON = $(if ($(BR2_PACKAGE_PYTHON),python,python3)
or if we simply stop doing this and say that we switch to just python3.
Titouan, what do you think ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-07-14 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 3:39 [Buildroot] [PATCH] package/scons: explicitly specify host Python 3 Robert Hancock
2020-07-14 8:15 ` Thomas Petazzoni [this message]
2020-07-14 13:31 ` Titouan Christophe
2020-07-14 13:51 ` Thomas Petazzoni
2020-07-14 16:23 ` Robert Hancock
2022-01-08 11:20 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714101510.378d1909@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.