From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: paul@mawsonlakes.org
Cc: soc@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Changes blacklist to blocklist in ecode.c file
Date: Tue, 14 Jul 2020 15:20:41 +0100 [thread overview]
Message-ID: <20200714142040.GD1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200714140557.401403-2-paul@mawsonlakes.org>
On Tue, Jul 14, 2020 at 11:35:57PM +0930, paul@mawsonlakes.org wrote:
> From: Paul Schulz <paul@mawsonlakes.org>
>
> ---
> arch/arm/mach-rpc/ecard.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/mach-rpc/ecard.c b/arch/arm/mach-rpc/ecard.c
> index 75cfad2cb143..b3d70389ac9a 100644
> --- a/arch/arm/mach-rpc/ecard.c
> +++ b/arch/arm/mach-rpc/ecard.c
> @@ -63,7 +63,7 @@ struct ecard_request {
> struct completion *complete;
> };
>
> -struct expcard_blacklist {
> +struct expcard_blocklist {
I don't like this change - this is not about "blocking" anything, so
this change results in nonsense.
expcard_quirklist would be better.
> unsigned short manufacturer;
> unsigned short product;
> const char *type;
> @@ -79,7 +79,7 @@ static void atomwide_3p_quirk(ecard_t *ec);
> /* List of descriptions of cards which don't have an extended
> * identification, or chunk directories containing a description.
> */
> -static struct expcard_blacklist __initdata blacklist[] = {
> +static struct expcard_blocklist __initdata blocklist[] = {
Reading the comment above illustrates my point above; this list is
not about blocking anything, so calling it a "block" list is just
rediculous.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-07-14 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 14:05 [PATCH] arm: Changes 'blacklist' to 'blocklist' in ecode.c file paul
2020-07-14 14:05 ` [PATCH] Changes blacklist to blocklist " paul
2020-07-14 14:20 ` Russell King - ARM Linux admin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714142040.GD1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=paul@mawsonlakes.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.