Re: [PATCH v3 2/6] dt-bindings: power: supply: Extend max17040 compatibility

[Rob Herring <robh@kernel.org>]

On Tue, Jul 14, 2020 at 11:49:44AM +0300, Iskren Chernev wrote:
> 
> On 7/13/20 10:03 PM, Rob Herring wrote:
> > On Wed, Jun 24, 2020 at 06:56:29PM +0300, Iskren Chernev wrote:
> >> Maxim max17040 is a fuel gauge from a larger family utilising the Model
> >> Gauge technology. Document all different compatible strings that the
> >> max17040 driver recognizes.
> >>
> >> Some devices in the wild report double the capacity. The
> >> maxim,double-soc (from State-Of-Charge) property fixes that.
> >>
> >> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
> >> ---
> >>  .../bindings/power/supply/max17040_battery.txt    | 15 ++++++++++++++-
> >>  1 file changed, 14 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/power/supply/max17040_battery.txt b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> >> index 4e0186b8380fa..554bce82a08e6 100644
> >> --- a/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> >> +++ b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> >> @@ -2,7 +2,9 @@ max17040_battery
> >>  ~~~~~~~~~~~~~~~~
> >>
> >>  Required properties :
> >> - - compatible : "maxim,max17040" or "maxim,max77836-battery"
> >> + - compatible : "maxim,max17040", "maxim,max17041", "maxim,max17043",
> >> +         "maxim,max17044", "maxim,max17048", "maxim,max17049",
> >> +        "maxim,max17058", "maxim,max17059" or "maxim,max77836-battery"
> >>   - reg: i2c slave address
> >>
> >>  Optional properties :
> >> @@ -11,6 +13,10 @@ Optional properties :
> >>                  generated. Can be configured from 1 up to 32
> >>                  (%). If skipped the power up default value of
> >>                  4 (%) will be used.
> >> +- maxim,double-soc :         Certain devices return double the capacity.
> >> +                Specify this boolean property to divide the
> >> +                reported value in 2 and thus normalize it.
> >> +                SOC == State of Charge == Capacity.
> >
> > This can't be implied by the compatible string?
> >
> 
> >From what I can tell - no. Here are multiple examples of downstream code:

Okay,

Reviewed-by: Rob Herring <robh@kernel.org>