From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 1/2] sched/core: Rename and move schedutil_cpu_util to core.c
Date: Tue, 14 Jul 2020 21:05:18 +0800 [thread overview]
Message-ID: <202007142126.cce7w0AU%lkp@intel.com> (raw)
In-Reply-To: <83d42cb2e589235750d68c9beada882ec93aeedd.1594707424.git.viresh.kumar@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 24319 bytes --]
Hi Viresh,
I love your patch! Yet something to improve:
[auto build test ERROR on tip/sched/core]
[cannot apply to tip/auto-latest pm/linux-next linus/master v5.8-rc5 next-20200713]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Viresh-Kumar/cpufreq_cooling-Get-effective-CPU-utilization-from-scheduler/20200714-144059
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 9d246053a69196c7c27068870e9b4b66ac536f68
config: x86_64-allnoconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 02946de3802d3bc65bc9f2eb9b8d4969b5a7add8)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2493:23: error: no member named 'avg_dl' in 'struct rq'
return READ_ONCE(rq->avg_dl.util_avg);
~~ ^
include/linux/compiler.h:291:33: note: expanded from macro 'READ_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/linux/compiler.h:405:35: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler_types.h:300:10: note: expanded from macro '__native_word'
(sizeof(t) == sizeof(char) || sizeof(t) == sizeof(short) || \
^
include/linux/compiler.h:392:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler.h:380:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler.h:372:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2493:23: error: no member named 'avg_dl' in 'struct rq'
return READ_ONCE(rq->avg_dl.util_avg);
~~ ^
include/linux/compiler.h:291:33: note: expanded from macro 'READ_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/linux/compiler.h:405:35: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler_types.h:300:39: note: expanded from macro '__native_word'
(sizeof(t) == sizeof(char) || sizeof(t) == sizeof(short) || \
^
include/linux/compiler.h:392:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler.h:380:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler.h:372:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2493:23: error: no member named 'avg_dl' in 'struct rq'
return READ_ONCE(rq->avg_dl.util_avg);
~~ ^
include/linux/compiler.h:291:33: note: expanded from macro 'READ_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/linux/compiler.h:405:35: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler_types.h:301:10: note: expanded from macro '__native_word'
sizeof(t) == sizeof(int) || sizeof(t) == sizeof(long))
^
include/linux/compiler.h:392:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler.h:380:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler.h:372:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2493:23: error: no member named 'avg_dl' in 'struct rq'
return READ_ONCE(rq->avg_dl.util_avg);
~~ ^
include/linux/compiler.h:291:33: note: expanded from macro 'READ_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/linux/compiler.h:405:35: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler_types.h:301:38: note: expanded from macro '__native_word'
sizeof(t) == sizeof(int) || sizeof(t) == sizeof(long))
^
include/linux/compiler.h:392:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler.h:380:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler.h:372:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2493:23: error: no member named 'avg_dl' in 'struct rq'
return READ_ONCE(rq->avg_dl.util_avg);
~~ ^
include/linux/compiler.h:291:33: note: expanded from macro 'READ_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/linux/compiler.h:405:48: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler.h:392:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler.h:380:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler.h:372:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2493:23: error: no member named 'avg_dl' in 'struct rq'
return READ_ONCE(rq->avg_dl.util_avg);
~~ ^
include/linux/compiler.h:292:21: note: expanded from macro 'READ_ONCE'
__READ_ONCE_SCALAR(x); \
^
include/linux/compiler.h:284:25: note: expanded from macro '__READ_ONCE_SCALAR'
__unqual_scalar_typeof(x) __x = __READ_ONCE(x); \
^
include/linux/compiler_types.h:288:13: note: expanded from macro '__unqual_scalar_typeof'
_Generic((x), \
^
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2493:23: error: no member named 'avg_dl' in 'struct rq'
return READ_ONCE(rq->avg_dl.util_avg);
~~ ^
include/linux/compiler.h:292:21: note: expanded from macro 'READ_ONCE'
__READ_ONCE_SCALAR(x); \
^
include/linux/compiler.h:284:46: note: expanded from macro '__READ_ONCE_SCALAR'
__unqual_scalar_typeof(x) __x = __READ_ONCE(x); \
^
include/linux/compiler.h:280:65: note: expanded from macro '__READ_ONCE'
#define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
^
include/linux/compiler_types.h:288:13: note: expanded from macro '__unqual_scalar_typeof'
_Generic((x), \
^
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2493:23: error: no member named 'avg_dl' in 'struct rq'
return READ_ONCE(rq->avg_dl.util_avg);
~~ ^
include/linux/compiler.h:292:21: note: expanded from macro 'READ_ONCE'
__READ_ONCE_SCALAR(x); \
^
include/linux/compiler.h:284:46: note: expanded from macro '__READ_ONCE_SCALAR'
__unqual_scalar_typeof(x) __x = __READ_ONCE(x); \
^
include/linux/compiler.h:280:72: note: expanded from macro '__READ_ONCE'
#define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
^
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2493:23: error: no member named 'avg_dl' in 'struct rq'
return READ_ONCE(rq->avg_dl.util_avg);
~~ ^
include/linux/compiler.h:292:21: note: expanded from macro 'READ_ONCE'
__READ_ONCE_SCALAR(x); \
^
include/linux/compiler.h:286:10: note: expanded from macro '__READ_ONCE_SCALAR'
(typeof(x))__x; \
^
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2493:9: error: returning 'void' from a function with incompatible result type 'unsigned long'
return READ_ONCE(rq->avg_dl.util_avg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler.h:289:28: note: expanded from macro 'READ_ONCE'
#define READ_ONCE(x) \
^
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2498:41: error: no member named 'avg' in 'struct cfs_rq'
unsigned long util = READ_ONCE(rq->cfs.avg.util_avg);
~~~~~~~ ^
include/linux/compiler.h:291:33: note: expanded from macro 'READ_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/linux/compiler.h:405:35: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler_types.h:300:10: note: expanded from macro '__native_word'
(sizeof(t) == sizeof(char) || sizeof(t) == sizeof(short) || \
^
include/linux/compiler.h:392:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler.h:380:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler.h:372:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2498:41: error: no member named 'avg' in 'struct cfs_rq'
unsigned long util = READ_ONCE(rq->cfs.avg.util_avg);
~~~~~~~ ^
include/linux/compiler.h:291:33: note: expanded from macro 'READ_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/linux/compiler.h:405:35: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler_types.h:300:39: note: expanded from macro '__native_word'
(sizeof(t) == sizeof(char) || sizeof(t) == sizeof(short) || \
^
include/linux/compiler.h:392:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler.h:380:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler.h:372:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2498:41: error: no member named 'avg' in 'struct cfs_rq'
unsigned long util = READ_ONCE(rq->cfs.avg.util_avg);
~~~~~~~ ^
include/linux/compiler.h:291:33: note: expanded from macro 'READ_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/linux/compiler.h:405:35: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler_types.h:301:10: note: expanded from macro '__native_word'
sizeof(t) == sizeof(int) || sizeof(t) == sizeof(long))
^
include/linux/compiler.h:392:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler.h:380:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler.h:372:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2498:41: error: no member named 'avg' in 'struct cfs_rq'
unsigned long util = READ_ONCE(rq->cfs.avg.util_avg);
~~~~~~~ ^
include/linux/compiler.h:291:33: note: expanded from macro 'READ_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/linux/compiler.h:405:35: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler_types.h:301:38: note: expanded from macro '__native_word'
sizeof(t) == sizeof(int) || sizeof(t) == sizeof(long))
^
include/linux/compiler.h:392:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler.h:380:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler.h:372:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2498:41: error: no member named 'avg' in 'struct cfs_rq'
unsigned long util = READ_ONCE(rq->cfs.avg.util_avg);
~~~~~~~ ^
include/linux/compiler.h:291:33: note: expanded from macro 'READ_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/linux/compiler.h:405:48: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler.h:392:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler.h:380:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler.h:372:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2498:41: error: no member named 'avg' in 'struct cfs_rq'
unsigned long util = READ_ONCE(rq->cfs.avg.util_avg);
~~~~~~~ ^
include/linux/compiler.h:292:21: note: expanded from macro 'READ_ONCE'
__READ_ONCE_SCALAR(x); \
^
include/linux/compiler.h:284:25: note: expanded from macro '__READ_ONCE_SCALAR'
__unqual_scalar_typeof(x) __x = __READ_ONCE(x); \
^
include/linux/compiler_types.h:288:13: note: expanded from macro '__unqual_scalar_typeof'
_Generic((x), \
^
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2498:41: error: no member named 'avg' in 'struct cfs_rq'
unsigned long util = READ_ONCE(rq->cfs.avg.util_avg);
~~~~~~~ ^
include/linux/compiler.h:292:21: note: expanded from macro 'READ_ONCE'
__READ_ONCE_SCALAR(x); \
^
include/linux/compiler.h:284:46: note: expanded from macro '__READ_ONCE_SCALAR'
__unqual_scalar_typeof(x) __x = __READ_ONCE(x); \
^
include/linux/compiler.h:280:65: note: expanded from macro '__READ_ONCE'
#define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
^
include/linux/compiler_types.h:288:13: note: expanded from macro '__unqual_scalar_typeof'
_Generic((x), \
^
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2498:41: error: no member named 'avg' in 'struct cfs_rq'
unsigned long util = READ_ONCE(rq->cfs.avg.util_avg);
~~~~~~~ ^
include/linux/compiler.h:292:21: note: expanded from macro 'READ_ONCE'
__READ_ONCE_SCALAR(x); \
^
include/linux/compiler.h:284:46: note: expanded from macro '__READ_ONCE_SCALAR'
__unqual_scalar_typeof(x) __x = __READ_ONCE(x); \
^
include/linux/compiler.h:280:72: note: expanded from macro '__READ_ONCE'
#define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
^
In file included from kernel/sched/core.c:13:
>> kernel/sched/sched.h:2498:41: error: no member named 'avg' in 'struct cfs_rq'
unsigned long util = READ_ONCE(rq->cfs.avg.util_avg);
~~~~~~~ ^
include/linux/compiler.h:292:21: note: expanded from macro 'READ_ONCE'
__READ_ONCE_SCALAR(x); \
^
include/linux/compiler.h:286:10: note: expanded from macro '__READ_ONCE_SCALAR'
(typeof(x))__x; \
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
vim +2493 kernel/sched/sched.h
d4edd662ac1657 Juri Lelli 2017-12-04 2490
8cc90515a4fa41 Vincent Guittot 2018-06-28 2491 static inline unsigned long cpu_util_dl(struct rq *rq)
8cc90515a4fa41 Vincent Guittot 2018-06-28 2492 {
8cc90515a4fa41 Vincent Guittot 2018-06-28 @2493 return READ_ONCE(rq->avg_dl.util_avg);
8cc90515a4fa41 Vincent Guittot 2018-06-28 2494 }
8cc90515a4fa41 Vincent Guittot 2018-06-28 2495
d4edd662ac1657 Juri Lelli 2017-12-04 2496 static inline unsigned long cpu_util_cfs(struct rq *rq)
d4edd662ac1657 Juri Lelli 2017-12-04 2497 {
a07630b8b2c16f Patrick Bellasi 2018-03-09 @2498 unsigned long util = READ_ONCE(rq->cfs.avg.util_avg);
a07630b8b2c16f Patrick Bellasi 2018-03-09 2499
a07630b8b2c16f Patrick Bellasi 2018-03-09 2500 if (sched_feat(UTIL_EST)) {
a07630b8b2c16f Patrick Bellasi 2018-03-09 2501 util = max_t(unsigned long, util,
a07630b8b2c16f Patrick Bellasi 2018-03-09 2502 READ_ONCE(rq->cfs.avg.util_est.enqueued));
a07630b8b2c16f Patrick Bellasi 2018-03-09 2503 }
a07630b8b2c16f Patrick Bellasi 2018-03-09 2504
a07630b8b2c16f Patrick Bellasi 2018-03-09 2505 return util;
d4edd662ac1657 Juri Lelli 2017-12-04 2506 }
371bf42732694d Vincent Guittot 2018-06-28 2507
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 7531 bytes --]
next prev parent reply other threads:[~2020-07-14 13:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 6:36 [PATCH 0/2] cpufreq_cooling: Get effective CPU utilization from scheduler Viresh Kumar
2020-07-14 6:36 ` [PATCH 1/2] sched/core: Rename and move schedutil_cpu_util to core.c Viresh Kumar
2020-07-14 12:52 ` Rafael J. Wysocki
2020-07-14 13:05 ` kernel test robot [this message]
2020-07-15 3:50 ` Viresh Kumar
2020-07-15 5:07 ` Rong Chen
2020-07-14 6:36 ` [PATCH 2/2] thermal: cpufreq_cooling: Reuse effective_cpu_util() Viresh Kumar
2020-07-14 8:23 ` Peter Zijlstra
2020-07-14 13:05 ` Rafael J. Wysocki
2020-07-15 7:32 ` Viresh Kumar
2020-07-15 12:47 ` Rafael J. Wysocki
2020-07-16 11:56 ` Peter Zijlstra
2020-07-16 14:24 ` Lukasz Luba
2020-07-16 15:43 ` Peter Zijlstra
2020-07-17 9:55 ` Lukasz Luba
2020-07-17 9:46 ` Vincent Guittot
2020-07-17 10:30 ` Lukasz Luba
2020-07-17 12:13 ` Vincent Guittot
2020-07-30 6:24 ` Viresh Kumar
2020-07-30 11:16 ` Lukasz Luba
2020-10-19 7:40 ` Viresh Kumar
2020-10-19 11:10 ` Lukasz Luba
2020-10-22 8:32 ` Viresh Kumar
2020-10-22 9:05 ` Peter Zijlstra
2020-10-22 11:06 ` Viresh Kumar
2020-10-22 11:30 ` Rafael J. Wysocki
2020-10-22 11:57 ` Peter Zijlstra
2020-10-22 12:07 ` Rafael J. Wysocki
2020-10-22 11:39 ` Peter Zijlstra
2020-07-17 10:14 ` Quentin Perret
2020-07-17 10:33 ` Quentin Perret
2020-07-17 10:43 ` Quentin Perret
2020-07-22 9:13 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007142126.cce7w0AU%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.