From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2087C433E8 for ; Wed, 15 Jul 2020 06:47:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CB0F206D5 for ; Wed, 15 Jul 2020 06:47:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XGBsIWWQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728866AbgGOGru (ORCPT ); Wed, 15 Jul 2020 02:47:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728671AbgGOGrt (ORCPT ); Wed, 15 Jul 2020 02:47:49 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75500C061794 for ; Tue, 14 Jul 2020 23:47:49 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o8so4184158wmh.4 for ; Tue, 14 Jul 2020 23:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=pFEdwPrFAGXygP0PLmBw7h9OMC5JQetuJaGwPug3T84=; b=XGBsIWWQ4rQmBhLUNdm6ehB4cRfkZzVoo4evT3I5MZ7SfXhse4jI7tKro6tlGtAKvx vcNzSB6Y57nsLmW1KhHblZDArOxm5UCyl04aTLIywFjrAO6Bb420IPRy+hJfGCI/Nwjf IPzjST6rchSVPzMXhsSXZ/Bpx5vG4JxqkeYf57lar4VEG6Twy7oe/ew/R1EeWc5epv+O z9LPHPkZpbgNmnq/TAqRkLbGPBZgSqrF7GCZ4Km2IernIXhXtNVrqPi5Kc+j+Szq5/a1 kvfGT3WcEan0m5hUkC2tLVzin5iVOaSvKqUYm+4lw1rjmisSWY35681iqCSc/NbwDyBq N08w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=pFEdwPrFAGXygP0PLmBw7h9OMC5JQetuJaGwPug3T84=; b=rQYGRDHjUZGSF8eOlMfvu+9r+ouQ069qIs4139oZAe+JT9dURMhyLa3FoibxpiH4/O mx2k9M0yRijdGGUxoWDDJ6/pZYcqXEm0uoaQpV3tcXsDUBm5Hvp40seoZhsvTTFwtzXM oizVbArLMjGhCIYv1Ss1konFu1eUvkRi4qirN3u1RHGrxtFv71ZQkqj1rMA01YKwaEX6 CLlJ0DYp9Htq39ptIESssb1eHPx+FMskHGbSNQwhjH9CAVfd7rwcSv/hyHW1gwhmtSNa 04pMMKk3nSnbX88yQKdk1uylyzJF5vLTPSy/dZDVa05HUR0pDkpvrUuAIYWgPQVyHaNM MWmA== X-Gm-Message-State: AOAM531Tq5Qr3j0MwBNLySkAxZoIxc7X1i/OgGvgIXmmH5kC+pK3FPRF vSaB1z3ExWlCeaU5osbb5JREoKifEHE= X-Google-Smtp-Source: ABdhPJx+NTfnG9znaTGAktM3qpcuI/D+Sz92/+h/drddXvIQvTwedXSgGSKR6+Zl3zCJHSv8iY4C9A== X-Received: by 2002:a05:600c:2209:: with SMTP id z9mr7012030wml.178.1594795668190; Tue, 14 Jul 2020 23:47:48 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id r28sm2048595wrr.20.2020.07.14.23.47.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 23:47:47 -0700 (PDT) Date: Wed, 15 Jul 2020 07:47:46 +0100 From: Lee Jones To: Kim Phillips Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs Message-ID: <20200715064746.GU1398296@dell> References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-14-lee.jones@linaro.org> <6101e041-41e9-22bc-488d-38124c139bc7@amd.com> <20200714210218.GH1398296@dell> <8f7f2325-8c6a-b005-1f27-67e4b640da31@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8f7f2325-8c6a-b005-1f27-67e4b640da31@amd.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, 14 Jul 2020, Kim Phillips wrote: > On 7/14/20 4:02 PM, Lee Jones wrote: > > On Tue, 14 Jul 2020, Kim Phillips wrote: > >> On 7/14/20 9:50 AM, Lee Jones wrote: > >>> Can't see them being used anywhere and the compiler doesn't complain > >>> that they're missing, so ... > >>> > >>> Fixes the following W=1 kernel build warning(s): > >>> > >>> drivers/cpufreq/amd_freq_sensitivity.c:147:32: warning: ‘amd_freq_sensitivity_ids’ defined but not used [-Wunused-const-variable=] > >>> 147 | static const struct x86_cpu_id amd_freq_sensitivity_ids[] = { > >>> | ^~~~~~~~~~~~~~~~~~~~~~~~ > >>> > >>> Cc: Jacob Shin > >>> Signed-off-by: Lee Jones > >>> --- > >> > >> Same comment as for patch 9/13: these are used automatic module loading. > > > > How does that work? > > > > Could you point me to the code which handles that please? > > It's MODULE_DEVICE_TABLE magic. I'll look into that. Thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62DA4C433DF for ; Wed, 15 Jul 2020 06:49:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31FD720663 for ; Wed, 15 Jul 2020 06:49:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PIp6J+0V"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XGBsIWWQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31FD720663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1xBbAMfZTALpU2QnPBMDm+l7HutG7/Mc/pYXnJ2BmFw=; b=PIp6J+0V2d7MF+oYxOMKP18Ra HXtgpSHUo/yQKlM3Bh6DNaebHqalRuQf0fSeV+eonmwXRjbnKff0V6PzguHB1NEoQ8hS5+VQf504j M0tILEHXy6PC8MPrO8c2bL1ODMyesUvxdsLP9ItjagsHSFC0dowWZA+TZZcgKm6PYCNNfbYZBRvrP OA3RwEoO7XYWdXfbVJSnkuBeEuttq1VX3hjAe4V0KWkLUrnjSqJ/7f2yfjzsfFjxGpc5PoHRyyxv5 R38A89eQ2/1FcqV/iIj8DIysCfIdP1h/NkGXgTMm0sYK+6jgWduphr3C2rjqCOgRyDMbdiWjeDPZc wUy2JkiBg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvbCq-0004Iy-Ib; Wed, 15 Jul 2020 06:47:52 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvbCn-0004Hl-7n for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 06:47:50 +0000 Received: by mail-wm1-x342.google.com with SMTP id w3so4378553wmi.4 for ; Tue, 14 Jul 2020 23:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=pFEdwPrFAGXygP0PLmBw7h9OMC5JQetuJaGwPug3T84=; b=XGBsIWWQ4rQmBhLUNdm6ehB4cRfkZzVoo4evT3I5MZ7SfXhse4jI7tKro6tlGtAKvx vcNzSB6Y57nsLmW1KhHblZDArOxm5UCyl04aTLIywFjrAO6Bb420IPRy+hJfGCI/Nwjf IPzjST6rchSVPzMXhsSXZ/Bpx5vG4JxqkeYf57lar4VEG6Twy7oe/ew/R1EeWc5epv+O z9LPHPkZpbgNmnq/TAqRkLbGPBZgSqrF7GCZ4Km2IernIXhXtNVrqPi5Kc+j+Szq5/a1 kvfGT3WcEan0m5hUkC2tLVzin5iVOaSvKqUYm+4lw1rjmisSWY35681iqCSc/NbwDyBq N08w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=pFEdwPrFAGXygP0PLmBw7h9OMC5JQetuJaGwPug3T84=; b=XWYdPCTYpBm6oqhs1aiqV3hL3dH5vTLHlQpfoGV5DiEZ2KjXnFj7tVMYcBycLZexHD DcFHQypTaBgBJeN50QKhA8Ur2gCQGcYsPDfTkF9+ILdAyYQNjQfrtiwfCW3lFED4xcHZ NmWbawHkTuA4HlI/n3wR+zuTgWoVSNhR6xqxgZIV18SJ1LjRERka0mPCo9ZKfFvNnBsu FZVAd8s7XSJ8LUoKWlKZfMjX+/f6tcFsSrZCc2NkIuPt8su7RukgFj/13/lQ9ECYOvio CKTbzZGrWFqJrLT6DqjcxCmOQ/LkXfTrqFZR0LR4PXoAFtBPtyVuWySuej/onKs1vAaF 3HYg== X-Gm-Message-State: AOAM531V4NUXnTmKc1j9FGEN6KPg+VMYlYjDjihEZW5z+6XUN1UW9qZT LBTne/cAnRdJGhn1IsSZ+GvmKA== X-Google-Smtp-Source: ABdhPJx+NTfnG9znaTGAktM3qpcuI/D+Sz92/+h/drddXvIQvTwedXSgGSKR6+Zl3zCJHSv8iY4C9A== X-Received: by 2002:a05:600c:2209:: with SMTP id z9mr7012030wml.178.1594795668190; Tue, 14 Jul 2020 23:47:48 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id r28sm2048595wrr.20.2020.07.14.23.47.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 23:47:47 -0700 (PDT) Date: Wed, 15 Jul 2020 07:47:46 +0100 From: Lee Jones To: Kim Phillips Subject: Re: [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs Message-ID: <20200715064746.GU1398296@dell> References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-14-lee.jones@linaro.org> <6101e041-41e9-22bc-488d-38124c139bc7@amd.com> <20200714210218.GH1398296@dell> <8f7f2325-8c6a-b005-1f27-67e4b640da31@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8f7f2325-8c6a-b005-1f27-67e4b640da31@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_024749_319259_A4A839C2 X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: viresh.kumar@linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxNCBKdWwgMjAyMCwgS2ltIFBoaWxsaXBzIHdyb3RlOgoKPiBPbiA3LzE0LzIwIDQ6 MDIgUE0sIExlZSBKb25lcyB3cm90ZToKPiA+IE9uIFR1ZSwgMTQgSnVsIDIwMjAsIEtpbSBQaGls bGlwcyB3cm90ZToKPiA+PiBPbiA3LzE0LzIwIDk6NTAgQU0sIExlZSBKb25lcyB3cm90ZToKPiA+ Pj4gQ2FuJ3Qgc2VlIHRoZW0gYmVpbmcgdXNlZCBhbnl3aGVyZSBhbmQgdGhlIGNvbXBpbGVyIGRv ZXNuJ3QgY29tcGxhaW4KPiA+Pj4gdGhhdCB0aGV5J3JlIG1pc3NpbmcsIHNvIC4uLgo+ID4+Pgo+ ID4+PiBGaXhlcyB0aGUgZm9sbG93aW5nIFc9MSBrZXJuZWwgYnVpbGQgd2FybmluZyhzKToKPiA+ Pj4KPiA+Pj4gIGRyaXZlcnMvY3B1ZnJlcS9hbWRfZnJlcV9zZW5zaXRpdml0eS5jOjE0NzozMjog d2FybmluZzog4oCYYW1kX2ZyZXFfc2Vuc2l0aXZpdHlfaWRz4oCZIGRlZmluZWQgYnV0IG5vdCB1 c2VkIFstV3VudXNlZC1jb25zdC12YXJpYWJsZT1dCj4gPj4+ICAxNDcgfCBzdGF0aWMgY29uc3Qg c3RydWN0IHg4Nl9jcHVfaWQgYW1kX2ZyZXFfc2Vuc2l0aXZpdHlfaWRzW10gPSB7Cj4gPj4+ICB8 IF5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fgo+ID4+Pgo+ID4+PiBDYzogSmFjb2IgU2hpbiA8amFj b2Iuc2hpbkBhbWQuY29tPgo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25l c0BsaW5hcm8ub3JnPgo+ID4+PiAtLS0KPiA+Pgo+ID4+IFNhbWUgY29tbWVudCBhcyBmb3IgcGF0 Y2ggOS8xMzogdGhlc2UgYXJlIHVzZWQgYXV0b21hdGljIG1vZHVsZSBsb2FkaW5nLgo+ID4gCj4g PiBIb3cgZG9lcyB0aGF0IHdvcms/Cj4gPiAKPiA+IENvdWxkIHlvdSBwb2ludCBtZSB0byB0aGUg Y29kZSB3aGljaCBoYW5kbGVzIHRoYXQgcGxlYXNlPwo+IAo+IEl0J3MgTU9EVUxFX0RFVklDRV9U QUJMRSBtYWdpYy4KCkknbGwgbG9vayBpbnRvIHRoYXQuICBUaGFua3MuCgotLSAKTGVlIEpvbmVz IFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpM aW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExp bmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=